Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-02 00:42:45 +01:00
Code Issues Releases Wiki Activity

#723: code review pre-compute bit array

Browse Source
This commit is contained in:
gorhill 2015-02-07 23:42:07 -05:00
parent ada85ca75e
commit d9244b24c9
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/js/static-net-filtering.js
View File

@ -70,6 +70,16 @@ var typeNameToTypeValue = {
};
var typeOtherValue = typeNameToTypeValue.other;
// All network request types to bitmap
// bring origin to 0 (from 4 -- see typeNameToTypeValue)
// add 2 = number of left shift to use
// left-shift 1 by the above-calculated value
// subtract 4 to set all type bits, *except* for 2 lsb
// https://github.com/gorhill/uBlock/issues/723
// The 2 lsb *must* be zeroed
var allNetRequestTypesBitmap = (1 << (typeOtherValue >>> 4) + 2) - 4;
const BlockAnyTypeAnyParty = BlockAction | AnyType | AnyParty;
const BlockAnyType = BlockAction | AnyType;
const BlockAnyParty = BlockAction | AnyParty;
@ -1384,14 +1394,7 @@ FilterParser.prototype.parseOptType = function(raw, not) {
// Negated type: set all valid network request type bits to 1
if ( this.types === 0 ) {
// bring origin to 0 (from 4 -- see typeNameToTypeValue)
// add 2 = number of left shift to use
// left-shift 1 by the above-calculated value
// subtract 4 to set all type bits, *except* for 2 lsb
// https://github.com/gorhill/uBlock/issues/723
// The 2 lsb *must* be zeroed
this.types = (1 << (typeNameToTypeValue.other >>> 4) + 2) - 4;
this.types = allNetRequestTypesBitmap;
}
this.types &= ~(1 << (type >>> 4));