From e0b3b440807d7229d3ca400717185e4c8cdf5364 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Wed, 28 Jun 2023 18:12:17 -0400 Subject: [PATCH] Skip regex-testing context when no context provided Related issue: - https://github.com/uBlockOrigin/uAssets/issues/18725 Testing the context was causing the deprecated static property RegExp.$1 to be clobbered, causing webpage breakage because this property was subsequently used used by the caller. --- assets/resources/scriptlets.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/resources/scriptlets.js b/assets/resources/scriptlets.js index 9f8487dcb..78869046e 100644 --- a/assets/resources/scriptlets.js +++ b/assets/resources/scriptlets.js @@ -295,7 +295,7 @@ function abortCurrentScriptCore( const e = document.currentScript; if ( e instanceof HTMLScriptElement === false ) { return; } if ( e === thisScript ) { return; } - if ( reContext.test(e.src) === false ) { return; } + if ( context !== '' && reContext.test(e.src) === false ) { return; } if ( log && e.src !== '' ) { safe.uboLog(`matched src: ${e.src}`); } const scriptText = getScriptText(e); if ( reNeedle.test(scriptText) === false ) { return; }