From ef0a7ed5cb807900cb9a6d6a926ec972a57471db Mon Sep 17 00:00:00 2001
From: gorhill <rhill@raymondhill.net>
Date: Fri, 16 Sep 2016 19:12:16 -0400
Subject: [PATCH] code review re. #1997: be sure the setting is persisted

---
 src/js/utils.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/js/utils.js b/src/js/utils.js
index 44b242e76..2d5a66117 100644
--- a/src/js/utils.js
+++ b/src/js/utils.js
@@ -214,7 +214,10 @@
 µBlock.openNewTab = function(details) {
     if ( details.url.startsWith('logger-ui.html') ) {
         if ( details.shiftKey ) {
-            this.userSettings.alwaysDetachLogger = !this.userSettings.alwaysDetachLogger;
+            this.changeUserSettings(
+                'alwaysDetachLogger',
+                !this.userSettings.alwaysDetachLogger
+            );
         }
         details.popup = this.userSettings.alwaysDetachLogger;
     }