Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-07 03:12:33 +01:00
Code Issues Releases Wiki Activity

add TODOs comments

Browse Source
This commit is contained in:
Raymond Hill 2017-12-30 11:21:23 -05:00
parent f7c02e237f
commit f659dc8e49
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/js/traffic.js
View File

@ -672,8 +672,17 @@ var filterDocument = (function() {
this.disconnect(); this.disconnect();
return; return;
} }
// TODO: possibly improve buffer growth, if benchmarking shows it's // TODO:
// worth it. // - Possibly improve buffer growth, if benchmarking shows it's worth
// it.
// - Also evaluate whether keeping a list of buffers and then decoding
// them in sequence using TextDecoder's "stream" option is more
// efficient. Can the data buffers be safely kept around for later
// use?
// - Informal, quick benchmarks seem to show most of the overhead is
// from calling TextDecoder.decode() and TextEncoder.encode(), and if
// confirmed, there is nothing which can be done uBO-side to reduce
// overhead.
if ( filterer.buffer === null ) { if ( filterer.buffer === null ) {
if ( streamJobDone(filterer, ev.data) ) { return; } if ( streamJobDone(filterer, ev.data) ) { return; }
filterer.buffer = new Uint8Array(ev.data); filterer.buffer = new Uint8Array(ev.data);