From fe4cfeba2e3da98f92199d33fdab18808a556910 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Wed, 28 Sep 2022 09:05:04 -0400 Subject: [PATCH] Code review re. attribute serializer Related issue: - https://github.com/uBlockOrigin/uBlock-issues/issues/2300 Related commit: - https://github.com/gorhill/uBlock/commit/7379bafb23b4ca330d93e7894bfe38e33d1f55d9 --- src/js/static-filtering-parser.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/js/static-filtering-parser.js b/src/js/static-filtering-parser.js index 445cc09bb..aebca2280 100644 --- a/src/js/static-filtering-parser.js +++ b/src/js/static-filtering-parser.js @@ -1579,12 +1579,12 @@ Parser.prototype.SelectorCompiler = class { switch ( data.type ) { case 'AttributeSelector': { const name = data.name.name; + if ( data.matcher === null ) { + out.push(`[${name}]`); + break; + } const value = data.value.value || data.value.name; - out.push( - data.matcher - ? `[${name}${data.matcher}"${value}"]` - : `[${name}]` - ); + out.push(`[${name}${data.matcher}"${value}"]`); break; } case 'ClassSelector':