Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-09-15 15:32:28 +02:00
Code Issues Releases Wiki Activity

code review of last commit

Browse Source
This commit is contained in:
gorhill 2015-02-07 15:39:46 -05:00
parent 92e26cb3d7
commit ff2746f276
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/js/popup.js
View File

@ -196,14 +196,18 @@ var updateDynamicFilterCell = function(scope, des, type, rule) {
}
cell.toggleClass('ownRule', ownRule);
if ( scope !== '.' || des === '*' ) {
return;
}
// IMPORTANT: It is completely assumed the first node is a TEXT_NODE, so
// ensure this in the HTML file counterpart when you make
// changes
var textNode = cell.nodeAt(0).firstChild;
// Since this may be a cell from a reused row, we need to clear text
// Remember this may be a cell from a reused row, we need to clear text
// content if we can't compute request counts.
if ( scope !== '.' || des === '*' || popupData.hostnameDict.hasOwnProperty(des) === false ) {
if ( popupData.hostnameDict.hasOwnProperty(des) === false ) {
textNode.nodeValue = ' ';
return;
}