Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-24 11:22:44 +01:00
Code Issues Releases Wiki Activity

Coallesce mousemove events

Browse Source 
Related commit:
- d1995778ff

Related issue:
- https://github.com/uBlockOrigin/uBlock-issues/issues/615
This commit is contained in:
Raymond Hill 2019-11-06 07:01:13 -05:00
parent eae76e3950
commit ffae19270f
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/js/scriptlets/element-picker.js
View File

@ -1519,17 +1519,27 @@ const onScrolled = function() {
const onStartMoving = (( ) => { const onStartMoving = (( ) => {
let mx0 = 0, my0 = 0; let mx0 = 0, my0 = 0;
let mx1 = 0, my1 = 0;
let r0 = 0, b0 = 0; let r0 = 0, b0 = 0;
let rMax = 0, bMax = 0; let rMax = 0, bMax = 0;
let timer;
const move = ev => { const move = ( ) => {
if ( ev.isTrusted === false ) { return; } timer = undefined;
let r1 = Math.min(Math.max(r0 - ev.pageX + mx0, 4), rMax); let r1 = Math.min(Math.max(r0 - mx1 + mx0, 4), rMax);
let b1 = Math.min(Math.max(b0 - ev.pageY + my0, 4), bMax); let b1 = Math.min(Math.max(b0 - my1 + my0, 4), bMax);
dialog.style.setProperty('right', `${r1}px`, 'important'); dialog.style.setProperty('right', `${r1}px`, 'important');
dialog.style.setProperty('bottom', `${b1}px`, 'important'); dialog.style.setProperty('bottom', `${b1}px`, 'important');
};
const moveAsync = ev => {
if ( ev.isTrusted === false ) { return; }
ev.preventDefault(); ev.preventDefault();
ev.stopPropagation(); ev.stopPropagation();
if ( timer !== undefined ) { return; }
mx1 = ev.pageX;
my1 = ev.pageY;
timer = self.requestAnimationFrame(move);
}; };
const stop = ev => { const stop = ev => {
@ -1537,7 +1547,7 @@ const onStartMoving = (( ) => {
if ( dialog.classList.contains('moving') === false ) { return; } if ( dialog.classList.contains('moving') === false ) { return; }
dialog.classList.remove('moving'); dialog.classList.remove('moving');
const pickerWin = pickerRoot.contentWindow; const pickerWin = pickerRoot.contentWindow;
pickerWin.removeEventListener('mousemove', move, { capture: true }); pickerWin.removeEventListener('mousemove', moveAsync, { capture: true });
pickerWin.removeEventListener('mouseup', stop, { capture: true, once: true }); pickerWin.removeEventListener('mouseup', stop, { capture: true, once: true });
ev.preventDefault(); ev.preventDefault();
ev.stopPropagation(); ev.stopPropagation();
@ -1557,7 +1567,7 @@ const onStartMoving = (( ) => {
rMax = pickerBody.clientWidth - 4 - rect.width ; rMax = pickerBody.clientWidth - 4 - rect.width ;
bMax = pickerBody.clientHeight - 4 - rect.height; bMax = pickerBody.clientHeight - 4 - rect.height;
dialog.classList.add('moving'); dialog.classList.add('moving');
pickerWin.addEventListener('mousemove', move, { capture: true }); pickerWin.addEventListener('mousemove', moveAsync, { capture: true });
pickerWin.addEventListener('mouseup', stop, { capture: true, once: true }); pickerWin.addEventListener('mouseup', stop, { capture: true, once: true });
ev.preventDefault(); ev.preventDefault();
ev.stopPropagation(); ev.stopPropagation();