1
0
mirror of https://github.com/gorhill/uBlock.git synced 2024-10-04 16:47:15 +02:00

Updated My answer to web store reviews where appropriate (markdown)

gorhill 2014-09-03 06:49:14 -07:00
parent 66a2144157
commit 747d837dff

@ -32,7 +32,9 @@ See [issue #161](https://github.com/gorhill/uBlock/issues/161). The following fi
##a[href^="http://www.faceporn.net/free?"]
This filter is classified internally by µBlock as a _high-medium generic_ filter. High generic filters are the most challenging to implement performance-wise. High-medium generic filters are implemented as follow: All the high-medium generic filters which matches the 8 first characters of the URL of a link on a web page will be seen as relevant to the web page and thus a CSS selector based on these filters will be injected in the web page, in order to hide the unwanted links. Now the above filter, as per implementation happens to match the ubiquitous links to `WWW.FACEbook.com`, and thus will be inserted as a CSS selector whenever links to Facebook are found on a web page.
High generic filters are the most challenging to implement performance-wise. µBlock internally classifies high generic filters into three sub-categories, _high-low_, _high-medium_ and _high-high_ generic. The filter above is classified internally by µBlock as a _high-medium_ generic filter.
High-medium generic filters are implemented as follow: All the high-medium generic filters which matches the 8 first characters of the URL of a link on a web page will be seen as relevant to the web page and thus a CSS selector based on these filters will be injected in the web page, in order to hide the unwanted links. Now the above filter, as per implementation happens to match the ubiquitous links to `WWW.FACEbook.com`, and thus will be inserted as a CSS selector whenever links to Facebook are found on a web page.
Note that Adblock Plus also injects `a[href^="http://www.faceporn.net/free?"]` in every page, but unlike µBlock, it is inserted in every page unconditionally, while µBlock tries as much as possible for performance-purpose to inject it only where it may be needed.
@ -76,4 +78,4 @@ Ok. I am willing to work to improve it though. But I do realize that regardless
The problem with the comment section at [Star-Telegram](http://www.star-telegram.com/) is due to the use of _EasyPrivacy_ list. I found the problem also occurs with _Adblock Plus_ if _EasyPrivacy_ is checked. ([test page](http://www.star-telegram.com/2014/06/24/5922649/us-plans-child-migrant-processing.html) where I spotted the problem.)
June 28: Found that problem is that `http://media.star-telegram.com/mistats/sites/dfw/startelegram.js` is being filtered by `/mistats/*` in _EasyPrivacy_. `@@||media.star-telegram.com/mistats/sites/dfw/startelegram.js^$domain=star-telegram.com` has been added to the project's own filters to fix the problem.
June 28: Found that problem is that `http://media.star-telegram.com/mistats/sites/dfw/startelegram.js` is being filtered by `/mistats/*` in _EasyPrivacy_. `@@||media.star-telegram.com/mistats/sites/dfw/startelegram.js^$domain=star-telegram.com` has been added to the project's own filters to fix the problem.