Sergey M․
4b5de77bdb
[utils] Process bytestrings in urljoin ( closes #12369 )
2017-03-06 03:57:46 +07:00
Yen Chi Hsuan
f48409c7ac
[utils] Add pkcs1pad
...
Used in daisuki.net (#4738 )
2017-02-28 22:10:31 +08:00
Yen Chi Hsuan
c9619f0a17
[aes] Add aes_cbc_encrypt
...
Used in daisuki.net (#4738 )
2017-02-28 22:10:31 +08:00
Sergey M․
d0d9ade486
[YoutubeDL] Add support for string formatting operations in output template
2017-02-23 22:57:53 +08:00
Yen Chi Hsuan
8936f68a0b
[travis] Run tests in parallel
...
[test_download] Print test names in case of network errors
[test_download] Add comments for nose parameters
[test_download] Modify outtmpl to prevent info JSON filename conflicts
Thanks @jaimeMF for the idea.
[travis] Only download tests should be run in parallel
2017-02-19 21:26:35 +08:00
Sergey M․
398dea3210
[test_YoutubeDL] Fix invalid escape sequences
2017-02-15 23:20:46 +07:00
Sergey M․
db13c16ef8
[utils] Add support for quoted string literals in --match-filter ( closes #8050 , closes #12142 , closes #12144 )
2017-02-15 23:12:10 +07:00
Thomas Christlieb
2af12ad9d2
Introduce get_elements_by_class and get_elements_by_attribute utility functions
2017-02-11 17:16:54 +08:00
Sergey M․
4195096ea8
[utils] Improve comments processing in js_to_json ( closes #11947 )
2017-02-03 03:04:33 +07:00
Michal Čihař
b3ee552e4b
[utils] Handle single-line comments in js_to_json
2017-02-03 03:04:33 +07:00
Sergey M․
15846398ca
[utils] Improve parse_duration
2017-01-26 23:23:08 +07:00
Sergey M․
cb655f34fb
[utils] Add more date formats
2017-01-12 22:39:45 +07:00
Remita Amine
7fe1592073
[common] fix dash codec information for mixed videos and fragment url construction( #11490 )
2016-12-20 12:35:03 +01:00
Sergey M․
b0c65c677f
[utils] Improve urljoin
2016-12-17 18:49:55 +07:00
Sergey M․
e34c33614d
[utils] Add convenience urljoin
2016-12-13 02:23:49 +07:00
Yen Chi Hsuan
582be35847
Update coding style after pycodestyle 2.1.0
...
In pycodestyle 2.1.0, E305 was introduced, which requires two blank
lines after top level declarations, too.
See https://github.com/PyCQA/pycodestyle/issues/400
See also #10689 ; thanks @stepshal for first mentioning this issue and
initial patches
2016-11-17 19:45:42 +08:00
Kacper Michajłow
189935f159
[jsinterp] Fix function calls without arguments.
2016-11-11 15:36:57 +01:00
Sergey M․
02dc0a36b7
[utils] Introduce base_url
2016-11-02 02:30:18 +07:00
Sergey M․
e5a088dc4b
[utils] Fix --match-filter for int-like strings ( closes #11082 )
2016-10-31 23:32:08 +07:00
Yen Chi Hsuan
6f20b65e72
[test/test_http] Update tests
...
After switching to HTML5 extraction helpers in generic.py, the result
info_dict is always a playlist.
2016-10-12 01:41:41 +08:00
Sergey M․
c6eed6b8c0
[utils] Lower priority for rare date formats and add tests
2016-09-29 23:52:29 +07:00
Sergey M․
3e4185c396
[utils] Use native french month names
2016-09-14 23:59:38 +07:00
Sergey M․
f6717dec8a
[utils] Improve month_by_name and add tests
2016-09-14 23:59:38 +07:00
Sergey M․
6562d34a8c
[utils] Improve mimetype2ext
2016-09-02 22:57:48 +07:00
Yen Chi Hsuan
70852b47ca
[utils] Recognize units with full names in parse_filename
...
Reference: https://en.wikipedia.org/wiki/Template:Quantities_of_bytes
2016-08-20 00:17:26 +08:00
Yen Chi Hsuan
e4659b4547
[utils] Correct octal/hexadecimal number detection in js_to_json
2016-08-19 20:37:17 +08:00
Sergey M․
13585d7682
[utils] Recognize lowercase units in parse_filesize
2016-08-18 23:32:00 +07:00
Yen Chi Hsuan
52aa7e7476
[test_verbose_output] Fix tests under Python 3
2016-08-13 17:36:14 +08:00
Remita Amine
5f2c2b7936
[test_utils] add test for option with not str value
2016-08-13 09:54:12 +01:00
Sergey M․
a8795327ca
[utils] Add support TV Parental Guidelines ratings in parse_age_limit
2016-08-07 20:45:18 +07:00
Yen Chi Hsuan
7dc2a74e0a
[utils] Fix unified_timestamp for formats parsed by parsedate_tz()
2016-08-05 11:41:55 +08:00
Sergey M․
b070564efb
[extractor/common] Support multiple properties in _og_search_property
2016-08-02 22:55:14 +07:00
Philipp Hagemeister
ce28252c48
[options] Add test that checks that --password=secret is hidden in verbose output
2016-08-02 17:03:46 +02:00
Yen Chi Hsuan
14a28e705b
[test/test_all_urls] Remove *.cc.com tests
2016-07-26 11:08:09 +08:00
Sergey M․
317f7ab634
[YoutubeDL] Fix format selection with filters ( Closes #10083 )
2016-07-16 00:55:43 +07:00
Yen Chi Hsuan
0b68de3cc1
Merge pull request #8876 from remitamine/html5_media
...
[extractor/common] add helper method to extract html5 media entries
2016-07-10 23:40:45 +08:00
Yen Chi Hsuan
dfe5fa49ae
[compat] Fix compat_shlex_split for non-ASCII input
...
Closes #9871
2016-07-07 17:37:29 +08:00
Yen Chi Hsuan
84c237fb8a
[utils] Add get_element_by_class
...
For #9950
2016-07-06 20:02:52 +08:00
Remita Amine
dfaa86b75e
[test_utils] add test for smuggling a smuggled url
2016-07-04 21:36:32 +01:00
Yen Chi Hsuan
40f3666f6b
[test/test_http] Update tests for 38cce791c7
2016-07-03 23:50:55 +08:00
Jaime Marquínez Ferrándiz
a9eede3913
[test/compat] compat_shlex_split: test with newlines
2016-07-01 03:30:35 +07:00
Sergey M․
fd7a7498a4
[test_all_urls] PEP 8 and change wording
2016-06-27 22:11:45 +07:00
Matthieu Muffato
e3a6747d8f
New test-case: extractor names are supposed to be unique
...
@dstftw explained in
https://github.com/rg3/youtube-dl/pull/9918#issuecomment-228625878 that
extractor names are supposed to be unique. @dstftw has fixed the two
offending extractors, and here I add a test to ensure this does not
happen in the future.
2016-06-27 22:09:29 +07:00
remitamine
4f3c5e0627
[utils] add helper function for parsing codecs
2016-06-26 14:03:58 +01:00
Sergey M․
88d9f6c0c4
[utils] Add support for name list in _html_search_meta
2016-06-26 16:57:14 +07:00
Yen Chi Hsuan
1143535d76
[utils] Add urshift()
...
Used in IqiyiIE and LeIE
2016-06-26 15:16:49 +08:00
Sergey M․
46f59e89ea
[utils] Add unified_timestamp
2016-06-25 23:19:18 +07:00
Yen Chi Hsuan
47212f7bcb
[utils] Don't transform numbers not starting with a zero
...
Fix test_Viidea and maybe others
2016-06-16 11:00:54 +08:00
Yen Chi Hsuan
55b2f099c0
[utils] Decode HTML5 entities
...
Used in test_Vporn_1. Also related to #9270
2016-06-10 15:11:55 +08:00
bzc6p
b96f007eeb
Added sanitization support for Hungarian letters Ő and Ű
2016-06-02 11:39:32 +02:00
Yen Chi Hsuan
54fb199681
[test/test_http] Fix getsockname() on Jython
2016-06-02 15:00:49 +08:00
Yen Chi Hsuan
8c32e5dc32
[test/test_utils] Add test for #9588
2016-06-02 15:00:49 +08:00
Yen Chi Hsuan
eb7941e3e6
[compat] Fix for XML with <!DOCTYPE> in Python 2.7 and 3.2
...
Such XML documents cause DeprecationWarning if python is run
with `-W error`
2016-05-23 01:40:11 +08:00
Sergey M․
46bc9b7d7c
[utils] Allow None in remove_{start,end}
2016-05-19 04:31:30 +06:00
Sergey M․
364cf465dd
[test_utils] PEP 8
2016-05-14 20:46:33 +06:00
Sergey M․
89ac4a19e6
[utils] Process non-base 10 integers in js_to_json
2016-05-14 20:39:58 +06:00
felix
bd1e484448
[utils] js_to_json: various improvements
...
now JS object literals like { /* " */ 0: ",]\xaa<\/p>", } will be correctly converted to JSON.
2016-05-14 20:12:39 +06:00
Yen Chi Hsuan
98d560f205
[test/test_socks] Skip SOCKS tests
...
They occasional trigger errors or blocks
(https://travis-ci.org/rg3/youtube-dl/jobs/130184883 )
2016-05-14 18:48:36 +08:00
Yen Chi Hsuan
778a1ccca7
[utils] Add Œ and œ found in French to ACCENT_CHARS
...
Fixes #9463
2016-05-12 19:48:48 +08:00
Yen Chi Hsuan
c2876afafe
[test/test_socks] Use a different port range
...
Seems on Travis CI, ports in the original range are often used.
2016-05-10 14:51:38 +08:00
Yen Chi Hsuan
e21f17fc86
[test/test_socks] Test with local SOCKS servers
2016-05-10 14:51:38 +08:00
Yen Chi Hsuan
edaa23f822
[compat] Rename struct_(un)pack to compat_struct_(un)pack
2016-05-10 14:51:38 +08:00
Yen Chi Hsuan
72f3289ac4
[test/test_socks] Add tests for SOCKS proxies
2016-05-10 14:51:38 +08:00
Yen Chi Hsuan
dab0daeeb0
[utils,compat] Move struct_pack and struct_unpack to compat.py
2016-05-10 14:51:38 +08:00
Sergey M․
fad7bbec3a
[test_compat] Remove unused import
2016-05-09 22:15:55 +06:00
Sergey M․
20cfdcc910
[test_compat] Avoid None values for compat_setenv
2016-05-09 22:00:14 +06:00
Sergey M․
1292638754
[test_compat] Use compat_setenv
2016-05-09 21:58:38 +06:00
Sergey M․
fe40f9eef2
[compat] Add compat_setenv
2016-05-09 21:55:03 +06:00
Adam Thalhammer
31c4448f6e
Instead of replacing accented characters with an underscore when sanitizing file names in restricted mode, replace them with their non-accented equivalents fixes #9347
2016-05-02 13:25:12 +10:00
Adam Thalhammer
79a2e94e79
Instead of replacing accented characters with an underscore when sanitizing file names in restricted mode, replace them with their non-accented equivalents fixes #9347
2016-05-02 13:21:39 +10:00
Sergey M
b6c0d4f431
Merge pull request #9110 from remitamine/parse_duration
...
[utils] imporove parse_duration to handle more formats
2016-04-21 22:53:16 +07:00
remitamine
acaff49575
[utils] imporove parse_duration to handle more formats
2016-04-21 16:34:54 +01:00
Jaime Marquínez Ferrándiz
1b6182d8f7
[youtube:playlist] Fetch all the videos in a mix ( fixes #3837 )
...
Since there doesn't seem to be any indication, it stops when there aren't new videos in the webpage.
2016-04-17 17:07:57 +02:00
Jaime Marquínez Ferrándiz
6a801f4470
[test/InfoExtractors] add test for _download_json
2016-04-09 23:18:41 +02:00
Jaime Marquínez Ferrándiz
eb9c3edd5e
[test/utils] Add test for date_from_str
2016-04-09 22:40:05 +02:00
Yen Chi Hsuan
6c4c7539f2
[test/helper] Check got values to be strings for md5: fields
...
Seen in PBSIE tests
2016-04-09 22:04:48 +08:00
Yen Chi Hsuan
92d5477d84
[compat] Handle tuples properly in urlencode()
...
Fixes #9055
2016-04-06 18:29:54 +08:00
Sergey M․
e289d6d62c
[test_compat] Add tests for compat_urllib_parse_urlencode
2016-03-26 02:38:33 +06:00
Yen Chi Hsuan
81f36eba88
[test/test_utils] Update for escape_url change (again)
2016-03-23 23:23:26 +08:00
Yen Chi Hsuan
2d60465e44
[test/test_utils] Update for escape_url change
2016-03-23 23:20:28 +08:00
Yen Chi Hsuan
efbed08dc2
[utils] Encode hostnames before passing to urllib
...
With IDN (Internationalized Domain Name) and a proxy, non-ascii URLs
are passed down to urllib/urllib2, causing UnicodeEncodeError
Fixes #8890
2016-03-23 22:24:52 +08:00
Jaime Marquínez Ferrándiz
782b1b5bd1
[utils] lookup_unit_table: Match word boundary instead of end of string
2016-03-19 11:44:49 +01:00
Sergey M․
4c3b16d5d1
[test_YoutubeDL] Add test for format_id format selection
2016-03-19 00:04:26 +06:00
Sergey M․
c5229f3926
[utils] PEP 8
2016-03-16 21:50:04 +06:00
remitamine
83548824c2
Merge pull request #8092 from bpfoley/twitter-thumbnail
...
[utils] Add extract_attributes for extracting html tag attributes
2016-03-16 13:16:27 +01:00
Sergey M․
fb47597b09
[bbc] Generalize unit table lookup and add parse_count
2016-03-13 16:27:20 +06:00
Sergey M․
e0dccdd398
[test_YoutubeDL] PEP 8
2016-03-10 09:04:48 +06:00
Sergey M․
5d583bdf6c
[YoutubeDL] Improve _format_note
2016-03-10 01:03:18 +06:00
remitamine
1255733945
Merge pull request #8739 from remitamine/update_url_params
...
[utils] add update_url_query function to create or update query string params
2016-03-03 19:24:04 +01:00
remitamine
3201a67f61
[test/test_utils] add more tests for update_url_query
2016-03-03 19:18:57 +01:00
remitamine
fb640d0a3d
[test/test_utils] add tests for update_url_query
2016-03-03 18:40:05 +01:00
Yen Chi Hsuan
429491f531
[test/http] Fix failure in Jython
...
make offlinetest passed on the latest Jython hg version with patched
lib-python/2.7/urllib2.py pulled from CPython 2.7.11
2016-03-03 21:55:17 +08:00
Yen Chi Hsuan
e9c0cdd389
[jython] Introduce compat_os_name
...
os.name is always 'java' on Jython
2016-03-03 19:24:24 +08:00
Brian Foley
8bb56eeeea
[utils] Add extract_attributes for extracting html tag attributes
...
This is much more robust than just using regexps, and handles all
the common scenarios, such as empty/no values, repeated attributes,
entity decoding, mixed case names, and the different possible value
quoting schemes.
2016-03-03 10:11:37 +00:00
Yen Chi Hsuan
5eb6bdced4
[utils] Multiple changes to base_n()
...
1. Renamed to encode_base_n()
2. Allow tables longer than 62 characters
3. Raise ValueError instead of AssertionError for invalid input data
4. Return the first character in the table instead of '0' for number 0
5. Add tests
2016-02-27 03:22:52 +08:00
Sergey M․
f160785c5c
[utils] Remove AM/PM from unified_strdate patterns
2016-02-25 00:52:49 +06:00
Yen Chi Hsuan
a4e4d7dfcd
[test_iqiyi_sdk_interpreter] Add test for iQiyi login
2016-02-20 23:10:39 +08:00
Yen Chi Hsuan
5bc880b988
[utils] Add OHDave's RSA encryption function
2016-02-20 19:54:58 +08:00
Sergey M․
86bf29050e
[test_YoutubeDL] Make test pass until more intelligent sort formats ( Closes #8462 )
2016-02-20 03:36:03 +06:00
Sergey M․
8411229bd5
[utils] Allow dot in strip_jsonp
2016-02-07 19:47:09 +06:00
Sergey M․
86296ad2cd
[utils] Add ability to control skipping false values in dict_get
2016-02-07 08:13:04 +06:00
Sergey M․
cbecc9b903
[utils] Add dict_get convenience method
2016-02-07 06:12:53 +06:00
remitamine
91cb6b5065
rename _parse_mpd to _parse_mpd_formats and add default value for mpd namespace
2016-02-06 14:03:48 +01:00
remitamine
920d21b9d3
[test_subtitles] update youtube subtitles tests
2016-02-04 08:50:55 +01:00
Yen Chi Hsuan
1df4141196
[test_YoutubeDL] Fix test_youtube_format_selection
...
Broken since a6c2c24479
. Thanks to
@jaimeMF and @anisse for pointing that out
2016-02-03 03:42:37 +08:00
Yen Chi Hsuan
b286f201a8
[YoutubeDL] Do not override ie_key in url_transparent
2016-02-01 17:05:48 +08:00
Yen Chi Hsuan
189d72d5fd
[test_subtitles] Fix TestRaiSubtitles
...
RaiIE is renamed to RaiTVIE in 06d5556dfa
2016-01-31 20:12:43 +08:00
Yen Chi Hsuan
a7aab0c23e
[test_youtube_lists] Fix TestYoutubeLists.test_youtube_course
...
Youtube entries are now generators
2016-01-31 20:12:43 +08:00
Jaime Marquínez Ferrándiz
70029bc348
[youtube:user] Require 'https?://' in the url ( fixes #8356 )
...
It was matching www.youtube.com/embed/WpfukLMe1TM.
The generic extractor automatically adds http:// if it's missing.
2016-01-29 11:27:11 +01:00
dyn888
b913348d5f
Test codec with a dot '.' in name selection.
2016-01-28 15:07:33 +01:00
Filippo Valsorda
4d318be195
[update] fix (unexploitable) BB'06 vulnerability in rsa_verify
...
The rsa_verify code was vulnerable to a BB'06 attack, allowing to forge
signatures for arbitrary messages if and only if the public key exponent is
3. Since the updates key is hardcoded to 65537, there is no risk for
youtube-dl, but I don't want vulnerable code in the wild.
The new function adopts a way safer approach of encoding-and-comparing to
replace the dangerous parsing code.
2016-01-21 20:12:17 +00:00
Jaime Marquínez Ferrándiz
e37afbe0b8
[YoutubeDL] urlopen: disable the 'file:' protocol ( #8227 )
...
If someone is running youtube-dl on a server to deliver files, the user could input 'file:///some/important/file' and youtube-dl would save that file as a video giving access to sensitive information to the user.
'file:' urls can be filtered, but the user can use an URL to a crafted m3u8 manifest like:
#EXTM3U
#EXT-X-MEDIA-SEQUENCE:0
#EXTINF:10.0
file:///etc/passwd
#EXT-X-ENDLIST
With this patch 'file:' URLs raise URLError like for unknown protocols.
2016-01-14 00:24:04 +01:00
Jakub Wilk
dfb1b1468c
Fix typos
...
Closes #8200 .
2016-01-10 17:24:28 +01:00
remitamine
f11d00fa41
[test_subtitles] remove BlipTV test
2015-12-21 16:52:47 +01:00
Sergey M․
6b77d52b1f
[test_utils] Add tests for encode_compat_str
2015-12-20 07:07:14 +06:00
Yen Chi Hsuan
db2fe38b55
[utils] Support alternative timestamp format in TTML
...
Fixes #7608
2015-12-19 19:29:51 +08:00
Yen Chi Hsuan
d631d5f9f2
[utils] Fix TTML conversion
...
Tolerate invalid timestamps (closes #7909 )
2015-12-19 18:21:42 +08:00
Sergey M․
31b2051e21
[utils] Add remove_quotes
2015-12-14 21:30:58 +06:00
Jaime Marquínez Ferrándiz
47f48f5d85
[test/test_all_urls] Update pbs extractor name
...
It's in lowercase now (since e15e2ef7a0
).
2015-12-08 21:12:13 +01:00
Sergey M․
9cb9a5df77
[utils] Check ext with trailing slash against the list of known extensions
2015-11-22 17:27:13 +06:00
Sergey M․
5035536e3f
[test_utils] Add tests for determine_ext
2015-11-22 06:33:52 +06:00
Sergey M․
7aefc49c40
[utils] Skip invalid/non HTML entities ( Closes #7518 )
2015-11-16 20:20:16 +06:00
Yen Chi Hsuan
ff29bf81f8
[jsinterp] Support alternative function definition form
2015-11-10 12:54:02 +08:00
Yen Chi Hsuan
66d041f250
[test/subtitles] Add test for DemocracynowIE
2015-11-04 00:53:30 +08:00
Jaime Marquínez Ferrándiz
6a75040278
[utils] unified_strdate: Return None if the date format can't be recognized ( fixes #7340 )
...
This issue was introduced with ae12bc3ebb
, it returned 'None'.
2015-11-02 14:08:38 +01:00
Sergey M
30eecc6a04
Merge pull request #7296 from jaimeMF/xml_attrib_unicode
...
Use a wrapper around xml.etree.ElementTree.fromstring in python 2.x (…
2015-10-31 18:15:21 +00:00
Sergey M․
578c074575
[utils] Support list of xpath in xpath_element
2015-10-31 22:39:44 +06:00
Sergey M․
52c3a6e49d
[utils] Improve parse_iso8601
2015-10-28 21:40:22 +06:00
Jaime Marquínez Ferrándiz
f78546272c
[compat] compat_etree_fromstring: also decode the text attribute
...
Deletes parse_xml from utils, because it also does it.
2015-10-26 16:41:24 +01:00
Jaime Marquínez Ferrándiz
387db16a78
[compat] compat_etree_fromstring: only decode bytes objects
2015-10-25 20:30:54 +01:00
Jaime Marquínez Ferrándiz
36e6f62cd0
Use a wrapper around xml.etree.ElementTree.fromstring in python 2.x ( #7178 )
...
Attributes aren't unicode objects, so they couldn't be directly used in info_dict fields (for example '--write-description' doesn't work with bytes).
2015-10-25 20:13:16 +01:00
Jaime Marquínez Ferrándiz
65d49afa48
[test/test_download] Use extract_flat = 'in_playlist' for playlist items
...
Some playlist extractors return a 'url' result, which wouldn't be resolved.
2015-10-23 14:12:46 +02:00
Sergey M․
d01949dc89
[utils:js_to_json] Fix bad escape in double quoted strings
2015-10-20 23:09:51 +06:00
Sergey M․
448ef1f31c
[extractor/common] Allow angle brackets in attributes in _og_regexes ( #7215 )
2015-10-18 09:11:02 +06:00
Sergey M․
8e5b121948
[test_youtube_lists] Add test flat playlist entries' titles
2015-10-18 00:27:06 +06:00
Sergey M․
db0a8ad979
[test_InfoExtractor] Add test for unquoted attribute
2015-10-14 21:11:06 +06:00
Sergey M․
1c29e81e62
[test_InfoExtractor] Add test for 7a6d76a64d
2015-10-14 20:58:52 +06:00
Jaime Marquínez Ferrándiz
7d0ada5ff9
[test/helper] Fix style
...
Use the correct indentation to please flake8
2015-10-02 13:42:11 +02:00
Sergey M․
f88f1b40ce
[test/helper] Clarify field for list length mismatch
2015-09-30 20:33:59 +06:00
Sergey M․
386a7b52d5
[test/helper] Spelling
2015-09-30 20:33:51 +06:00
Sergey M․
2e885de796
[test/helper] Formatting
2015-09-30 20:33:45 +06:00
Qijiang Fan
687c04cbb8
[test] use descriptive variable name
2015-09-30 20:33:35 +06:00
Qijiang Fan
40c931de4b
[test] split expect_dict to two functions
2015-09-30 20:33:30 +06:00
Qijiang Fan
93bc7ef165
[test] recursively check dict and list in expect_info_dict
...
This allows to use md5:, re:, etc within the str inside a list
or dict.
2015-09-30 20:33:20 +06:00
Sergey M․
c6aa838b51
[youtube:history] Enable exractor
2015-09-21 21:28:02 +06:00
Jaime Marquínez Ferrándiz
f005f96ea5
[youtube:history] Explain why it has disabled and skip test
2015-09-20 12:23:13 +02:00
remitamine
c67a055d16
[test/test_write_annotations] fix test filename
...
Closes #6781
2015-09-07 11:18:55 +02:00
Sergey M․
3513d41436
[test_compat] Fix typo
2015-09-05 21:45:52 +06:00
Sergey M․
ee087c79ad
[test_compat] Add test for compat_shlex_split
2015-09-05 21:41:34 +06:00
Sergey M․
f71264490c
[test_utils] Add tests for cli option converters
2015-09-05 03:07:19 +06:00