RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 03:33:20 +01:00
Code Issues Projects Releases Wiki Activity
186e585045
llvm-mirror/test/Linker/comdat_group.ll

19 lines
751 B
LLVM
Raw Normal View History

Ensure ModuleLinker materializes complete comdat groups Summary: The module linker lazy links some "discardable if unused" global values (e.g. linkonce), materializing and linking them only if they are referenced in the module. If a comdat group contains a linkonce member that is not referenced, however, it would not be materialized and linked, leading to an incomplete comdat group. If there are other object files not part of the same LTO link that also define and use that comdat group, the linker may select the incomplete group leading to link time unsats. To solve this, whenever a global value body is linked, make sure we materialize any other members of the same comdat group that are not yet materialized. This ensures they are in the lazy link list and get linked as well. Added new test and adjusted old test to remove parts that didn't make sense with fix. Reviewers: rafael Subscribers: dexonsmith, davidxl, llvm-commits Differential Revision: http://reviews.llvm.org/D14516 llvm-svn: 252647
2015-11-10 22:09:06 +01:00
; Ensure complete comdat group is materialized
Pass .ll directly to llvm-link llvm-svn: 254213
2015-11-28 00:21:45 +01:00
; RUN: llvm-link %s -S | FileCheck %s
Ensure ModuleLinker materializes complete comdat groups Summary: The module linker lazy links some "discardable if unused" global values (e.g. linkonce), materializing and linking them only if they are referenced in the module. If a comdat group contains a linkonce member that is not referenced, however, it would not be materialized and linked, leading to an incomplete comdat group. If there are other object files not part of the same LTO link that also define and use that comdat group, the linker may select the incomplete group leading to link time unsats. To solve this, whenever a global value body is linked, make sure we materialize any other members of the same comdat group that are not yet materialized. This ensures they are in the lazy link list and get linked as well. Added new test and adjusted old test to remove parts that didn't make sense with fix. Reviewers: rafael Subscribers: dexonsmith, davidxl, llvm-commits Differential Revision: http://reviews.llvm.org/D14516 llvm-svn: 252647
2015-11-10 22:09:06 +01:00
; CHECK: $linkoncecomdat = comdat any
; CHECK: @linkoncecomdat = linkonce global i32 2
; CHECK: @linkoncecomdat_unref_var = linkonce global i32 2, comdat($linkoncecomdat)
; CHECK: define linkonce void @linkoncecomdat_unref_func() comdat($linkoncecomdat)
$linkoncecomdat = comdat any
@linkoncecomdat = linkonce global i32 2, comdat($linkoncecomdat)
@linkoncecomdat_unref_var = linkonce global i32 2, comdat($linkoncecomdat)
define linkonce void @linkoncecomdat_unref_func() comdat($linkoncecomdat) {
ret void
}
; Reference one member of comdat so that comdat is generated.
define void @ref_linkoncecomdat() {
load i32, i32* @linkoncecomdat, align 4
ret void
}
Reference in New Issue Copy Permalink