2018-04-24 12:32:08 +02:00
|
|
|
//===------ CFIInstrInserter.cpp - Insert additional CFI instructions -----===//
|
|
|
|
//
|
2019-01-19 09:50:56 +01:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2018-04-24 12:32:08 +02:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
/// \file This pass verifies incoming and outgoing CFA information of basic
|
|
|
|
/// blocks. CFA information is information about offset and register set by CFI
|
|
|
|
/// directives, valid at the start and end of a basic block. This pass checks
|
|
|
|
/// that outgoing information of predecessors matches incoming information of
|
|
|
|
/// their successors. Then it checks if blocks have correct CFA calculation rule
|
|
|
|
/// set and inserts additional CFI instruction at their beginnings if they
|
|
|
|
/// don't. CFI instructions are inserted if basic blocks have incorrect offset
|
|
|
|
/// or register set by previous blocks, as a result of a non-linear layout of
|
|
|
|
/// blocks in a function.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2018-05-07 13:47:48 +02:00
|
|
|
#include "llvm/ADT/DepthFirstIterator.h"
|
2020-02-13 18:23:27 +01:00
|
|
|
#include "llvm/ADT/Optional.h"
|
|
|
|
#include "llvm/ADT/SetOperations.h"
|
2018-04-24 12:32:08 +02:00
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
|
|
#include "llvm/CodeGen/MachineModuleInfo.h"
|
|
|
|
#include "llvm/CodeGen/Passes.h"
|
|
|
|
#include "llvm/CodeGen/TargetFrameLowering.h"
|
|
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
|
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
Sink all InitializePasses.h includes
This file lists every pass in LLVM, and is included by Pass.h, which is
very popular. Every time we add, remove, or rename a pass in LLVM, it
caused lots of recompilation.
I found this fact by looking at this table, which is sorted by the
number of times a file was changed over the last 100,000 git commits
multiplied by the number of object files that depend on it in the
current checkout:
recompiles touches affected_files header
342380 95 3604 llvm/include/llvm/ADT/STLExtras.h
314730 234 1345 llvm/include/llvm/InitializePasses.h
307036 118 2602 llvm/include/llvm/ADT/APInt.h
213049 59 3611 llvm/include/llvm/Support/MathExtras.h
170422 47 3626 llvm/include/llvm/Support/Compiler.h
162225 45 3605 llvm/include/llvm/ADT/Optional.h
158319 63 2513 llvm/include/llvm/ADT/Triple.h
140322 39 3598 llvm/include/llvm/ADT/StringRef.h
137647 59 2333 llvm/include/llvm/Support/Error.h
131619 73 1803 llvm/include/llvm/Support/FileSystem.h
Before this change, touching InitializePasses.h would cause 1345 files
to recompile. After this change, touching it only causes 550 compiles in
an incremental rebuild.
Reviewers: bkramer, asbirlea, bollu, jdoerfert
Differential Revision: https://reviews.llvm.org/D70211
2019-11-13 22:15:01 +01:00
|
|
|
#include "llvm/InitializePasses.h"
|
2018-04-24 12:32:08 +02:00
|
|
|
#include "llvm/Target/TargetMachine.h"
|
|
|
|
using namespace llvm;
|
|
|
|
|
2018-05-07 16:09:33 +02:00
|
|
|
static cl::opt<bool> VerifyCFI("verify-cfiinstrs",
|
|
|
|
cl::desc("Verify Call Frame Information instructions"),
|
|
|
|
cl::init(false),
|
|
|
|
cl::Hidden);
|
|
|
|
|
2018-04-24 12:32:08 +02:00
|
|
|
namespace {
|
|
|
|
class CFIInstrInserter : public MachineFunctionPass {
|
|
|
|
public:
|
|
|
|
static char ID;
|
|
|
|
|
|
|
|
CFIInstrInserter() : MachineFunctionPass(ID) {
|
|
|
|
initializeCFIInstrInserterPass(*PassRegistry::getPassRegistry());
|
|
|
|
}
|
|
|
|
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
|
|
AU.setPreservesAll();
|
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool runOnMachineFunction(MachineFunction &MF) override {
|
2019-10-31 09:55:57 +01:00
|
|
|
if (!MF.needsFrameMoves())
|
2018-04-24 12:32:08 +02:00
|
|
|
return false;
|
|
|
|
|
|
|
|
MBBVector.resize(MF.getNumBlockIDs());
|
|
|
|
calculateCFAInfo(MF);
|
2018-05-07 16:09:33 +02:00
|
|
|
|
|
|
|
if (VerifyCFI) {
|
|
|
|
if (unsigned ErrorNum = verify(MF))
|
|
|
|
report_fatal_error("Found " + Twine(ErrorNum) +
|
|
|
|
" in/out CFI information errors.");
|
|
|
|
}
|
2018-04-24 12:32:08 +02:00
|
|
|
bool insertedCFI = insertCFIInstrs(MF);
|
|
|
|
MBBVector.clear();
|
|
|
|
return insertedCFI;
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
struct MBBCFAInfo {
|
|
|
|
MachineBasicBlock *MBB;
|
|
|
|
/// Value of cfa offset valid at basic block entry.
|
|
|
|
int IncomingCFAOffset = -1;
|
|
|
|
/// Value of cfa offset valid at basic block exit.
|
|
|
|
int OutgoingCFAOffset = -1;
|
|
|
|
/// Value of cfa register valid at basic block entry.
|
|
|
|
unsigned IncomingCFARegister = 0;
|
|
|
|
/// Value of cfa register valid at basic block exit.
|
|
|
|
unsigned OutgoingCFARegister = 0;
|
2020-02-13 18:23:27 +01:00
|
|
|
/// Set of callee saved registers saved at basic block entry.
|
|
|
|
BitVector IncomingCSRSaved;
|
|
|
|
/// Set of callee saved registers saved at basic block exit.
|
|
|
|
BitVector OutgoingCSRSaved;
|
2018-04-24 12:32:08 +02:00
|
|
|
/// If in/out cfa offset and register values for this block have already
|
|
|
|
/// been set or not.
|
|
|
|
bool Processed = false;
|
|
|
|
};
|
|
|
|
|
2020-02-13 18:23:27 +01:00
|
|
|
#define INVALID_REG UINT_MAX
|
|
|
|
#define INVALID_OFFSET INT_MAX
|
|
|
|
/// contains the location where CSR register is saved.
|
|
|
|
struct CSRSavedLocation {
|
|
|
|
CSRSavedLocation(Optional<unsigned> R, Optional<int> O)
|
|
|
|
: Reg(R), Offset(O) {}
|
|
|
|
Optional<unsigned> Reg;
|
|
|
|
Optional<int> Offset;
|
|
|
|
};
|
|
|
|
|
2018-04-24 12:32:08 +02:00
|
|
|
/// Contains cfa offset and register values valid at entry and exit of basic
|
|
|
|
/// blocks.
|
|
|
|
std::vector<MBBCFAInfo> MBBVector;
|
|
|
|
|
2020-02-13 18:23:27 +01:00
|
|
|
/// Map the callee save registers to the locations where they are saved.
|
|
|
|
SmallDenseMap<unsigned, CSRSavedLocation, 16> CSRLocMap;
|
|
|
|
|
2018-04-24 12:32:08 +02:00
|
|
|
/// Calculate cfa offset and register values valid at entry and exit for all
|
|
|
|
/// basic blocks in a function.
|
|
|
|
void calculateCFAInfo(MachineFunction &MF);
|
|
|
|
/// Calculate cfa offset and register values valid at basic block exit by
|
|
|
|
/// checking the block for CFI instructions. Block's incoming CFA info remains
|
|
|
|
/// the same.
|
|
|
|
void calculateOutgoingCFAInfo(MBBCFAInfo &MBBInfo);
|
|
|
|
/// Update in/out cfa offset and register values for successors of the basic
|
|
|
|
/// block.
|
|
|
|
void updateSuccCFAInfo(MBBCFAInfo &MBBInfo);
|
|
|
|
|
|
|
|
/// Check if incoming CFA information of a basic block matches outgoing CFA
|
|
|
|
/// information of the previous block. If it doesn't, insert CFI instruction
|
|
|
|
/// at the beginning of the block that corrects the CFA calculation rule for
|
|
|
|
/// that block.
|
|
|
|
bool insertCFIInstrs(MachineFunction &MF);
|
|
|
|
/// Return the cfa offset value that should be set at the beginning of a MBB
|
|
|
|
/// if needed. The negated value is needed when creating CFI instructions that
|
|
|
|
/// set absolute offset.
|
|
|
|
int getCorrectCFAOffset(MachineBasicBlock *MBB) {
|
2020-05-23 00:18:05 +02:00
|
|
|
return MBBVector[MBB->getNumber()].IncomingCFAOffset;
|
2018-04-24 12:32:08 +02:00
|
|
|
}
|
|
|
|
|
2020-02-13 18:23:27 +01:00
|
|
|
void reportCFAError(const MBBCFAInfo &Pred, const MBBCFAInfo &Succ);
|
|
|
|
void reportCSRError(const MBBCFAInfo &Pred, const MBBCFAInfo &Succ);
|
2018-04-24 12:32:08 +02:00
|
|
|
/// Go through each MBB in a function and check that outgoing offset and
|
|
|
|
/// register of its predecessors match incoming offset and register of that
|
|
|
|
/// MBB, as well as that incoming offset and register of its successors match
|
|
|
|
/// outgoing offset and register of the MBB.
|
|
|
|
unsigned verify(MachineFunction &MF);
|
|
|
|
};
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
char CFIInstrInserter::ID = 0;
|
|
|
|
INITIALIZE_PASS(CFIInstrInserter, "cfi-instr-inserter",
|
|
|
|
"Check CFA info and insert CFI instructions if needed", false,
|
|
|
|
false)
|
|
|
|
FunctionPass *llvm::createCFIInstrInserter() { return new CFIInstrInserter(); }
|
|
|
|
|
|
|
|
void CFIInstrInserter::calculateCFAInfo(MachineFunction &MF) {
|
|
|
|
// Initial CFA offset value i.e. the one valid at the beginning of the
|
|
|
|
// function.
|
|
|
|
int InitialOffset =
|
|
|
|
MF.getSubtarget().getFrameLowering()->getInitialCFAOffset(MF);
|
|
|
|
// Initial CFA register value i.e. the one valid at the beginning of the
|
|
|
|
// function.
|
|
|
|
unsigned InitialRegister =
|
|
|
|
MF.getSubtarget().getFrameLowering()->getInitialCFARegister(MF);
|
2020-02-13 18:23:27 +01:00
|
|
|
const TargetRegisterInfo &TRI = *MF.getSubtarget().getRegisterInfo();
|
|
|
|
unsigned NumRegs = TRI.getNumRegs();
|
2018-04-24 12:32:08 +02:00
|
|
|
|
|
|
|
// Initialize MBBMap.
|
|
|
|
for (MachineBasicBlock &MBB : MF) {
|
|
|
|
MBBCFAInfo MBBInfo;
|
|
|
|
MBBInfo.MBB = &MBB;
|
|
|
|
MBBInfo.IncomingCFAOffset = InitialOffset;
|
|
|
|
MBBInfo.OutgoingCFAOffset = InitialOffset;
|
|
|
|
MBBInfo.IncomingCFARegister = InitialRegister;
|
|
|
|
MBBInfo.OutgoingCFARegister = InitialRegister;
|
2020-02-13 18:23:27 +01:00
|
|
|
MBBInfo.IncomingCSRSaved.resize(NumRegs);
|
|
|
|
MBBInfo.OutgoingCSRSaved.resize(NumRegs);
|
2018-04-24 12:32:08 +02:00
|
|
|
MBBVector[MBB.getNumber()] = MBBInfo;
|
|
|
|
}
|
2020-02-13 18:23:27 +01:00
|
|
|
CSRLocMap.clear();
|
2018-04-24 12:32:08 +02:00
|
|
|
|
|
|
|
// Set in/out cfa info for all blocks in the function. This traversal is based
|
|
|
|
// on the assumption that the first block in the function is the entry block
|
|
|
|
// i.e. that it has initial cfa offset and register values as incoming CFA
|
|
|
|
// information.
|
2020-05-23 23:00:33 +02:00
|
|
|
updateSuccCFAInfo(MBBVector[MF.front().getNumber()]);
|
2018-04-24 12:32:08 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void CFIInstrInserter::calculateOutgoingCFAInfo(MBBCFAInfo &MBBInfo) {
|
|
|
|
// Outgoing cfa offset set by the block.
|
|
|
|
int SetOffset = MBBInfo.IncomingCFAOffset;
|
|
|
|
// Outgoing cfa register set by the block.
|
|
|
|
unsigned SetRegister = MBBInfo.IncomingCFARegister;
|
2020-02-13 18:23:27 +01:00
|
|
|
MachineFunction *MF = MBBInfo.MBB->getParent();
|
|
|
|
const std::vector<MCCFIInstruction> &Instrs = MF->getFrameInstructions();
|
|
|
|
const TargetRegisterInfo &TRI = *MF->getSubtarget().getRegisterInfo();
|
|
|
|
unsigned NumRegs = TRI.getNumRegs();
|
|
|
|
BitVector CSRSaved(NumRegs), CSRRestored(NumRegs);
|
2018-04-24 12:32:08 +02:00
|
|
|
|
|
|
|
// Determine cfa offset and register set by the block.
|
|
|
|
for (MachineInstr &MI : *MBBInfo.MBB) {
|
|
|
|
if (MI.isCFIInstruction()) {
|
2020-02-13 18:23:27 +01:00
|
|
|
Optional<unsigned> CSRReg;
|
|
|
|
Optional<int> CSROffset;
|
2018-04-24 12:32:08 +02:00
|
|
|
unsigned CFIIndex = MI.getOperand(0).getCFIIndex();
|
|
|
|
const MCCFIInstruction &CFI = Instrs[CFIIndex];
|
|
|
|
switch (CFI.getOperation()) {
|
|
|
|
case MCCFIInstruction::OpDefCfaRegister:
|
|
|
|
SetRegister = CFI.getRegister();
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpDefCfaOffset:
|
|
|
|
SetOffset = CFI.getOffset();
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpAdjustCfaOffset:
|
|
|
|
SetOffset += CFI.getOffset();
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpDefCfa:
|
|
|
|
SetRegister = CFI.getRegister();
|
|
|
|
SetOffset = CFI.getOffset();
|
|
|
|
break;
|
2020-02-13 18:23:27 +01:00
|
|
|
case MCCFIInstruction::OpOffset:
|
|
|
|
CSROffset = CFI.getOffset();
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpRegister:
|
|
|
|
CSRReg = CFI.getRegister2();
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpRelOffset:
|
|
|
|
CSROffset = CFI.getOffset() - SetOffset;
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpRestore:
|
|
|
|
CSRRestored.set(CFI.getRegister());
|
|
|
|
break;
|
2018-04-24 12:32:08 +02:00
|
|
|
case MCCFIInstruction::OpRememberState:
|
|
|
|
// TODO: Add support for handling cfi_remember_state.
|
|
|
|
#ifndef NDEBUG
|
|
|
|
report_fatal_error(
|
|
|
|
"Support for cfi_remember_state not implemented! Value of CFA "
|
|
|
|
"may be incorrect!\n");
|
|
|
|
#endif
|
|
|
|
break;
|
|
|
|
case MCCFIInstruction::OpRestoreState:
|
|
|
|
// TODO: Add support for handling cfi_restore_state.
|
|
|
|
#ifndef NDEBUG
|
|
|
|
report_fatal_error(
|
|
|
|
"Support for cfi_restore_state not implemented! Value of CFA may "
|
|
|
|
"be incorrect!\n");
|
|
|
|
#endif
|
|
|
|
break;
|
|
|
|
// Other CFI directives do not affect CFA value.
|
2020-02-13 18:23:27 +01:00
|
|
|
case MCCFIInstruction::OpUndefined:
|
2018-04-24 12:32:08 +02:00
|
|
|
case MCCFIInstruction::OpSameValue:
|
|
|
|
case MCCFIInstruction::OpEscape:
|
|
|
|
case MCCFIInstruction::OpWindowSave:
|
2018-12-18 11:37:42 +01:00
|
|
|
case MCCFIInstruction::OpNegateRAState:
|
2018-04-24 12:32:08 +02:00
|
|
|
case MCCFIInstruction::OpGnuArgsSize:
|
|
|
|
break;
|
|
|
|
}
|
2020-02-13 18:23:27 +01:00
|
|
|
if (CSRReg || CSROffset) {
|
|
|
|
auto It = CSRLocMap.find(CFI.getRegister());
|
|
|
|
if (It == CSRLocMap.end()) {
|
|
|
|
CSRLocMap.insert(
|
|
|
|
{CFI.getRegister(), CSRSavedLocation(CSRReg, CSROffset)});
|
|
|
|
} else if (It->second.Reg != CSRReg || It->second.Offset != CSROffset) {
|
|
|
|
llvm_unreachable("Different saved locations for the same CSR");
|
|
|
|
}
|
|
|
|
CSRSaved.set(CFI.getRegister());
|
|
|
|
}
|
2018-04-24 12:32:08 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
MBBInfo.Processed = true;
|
|
|
|
|
|
|
|
// Update outgoing CFA info.
|
|
|
|
MBBInfo.OutgoingCFAOffset = SetOffset;
|
|
|
|
MBBInfo.OutgoingCFARegister = SetRegister;
|
2020-02-13 18:23:27 +01:00
|
|
|
|
|
|
|
// Update outgoing CSR info.
|
|
|
|
MBBInfo.OutgoingCSRSaved = MBBInfo.IncomingCSRSaved;
|
|
|
|
MBBInfo.OutgoingCSRSaved |= CSRSaved;
|
|
|
|
MBBInfo.OutgoingCSRSaved.reset(CSRRestored);
|
2018-04-24 12:32:08 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void CFIInstrInserter::updateSuccCFAInfo(MBBCFAInfo &MBBInfo) {
|
2018-05-11 17:54:46 +02:00
|
|
|
SmallVector<MachineBasicBlock *, 4> Stack;
|
|
|
|
Stack.push_back(MBBInfo.MBB);
|
|
|
|
|
|
|
|
do {
|
|
|
|
MachineBasicBlock *Current = Stack.pop_back_val();
|
|
|
|
MBBCFAInfo &CurrentInfo = MBBVector[Current->getNumber()];
|
|
|
|
calculateOutgoingCFAInfo(CurrentInfo);
|
|
|
|
for (auto *Succ : CurrentInfo.MBB->successors()) {
|
|
|
|
MBBCFAInfo &SuccInfo = MBBVector[Succ->getNumber()];
|
|
|
|
if (!SuccInfo.Processed) {
|
|
|
|
SuccInfo.IncomingCFAOffset = CurrentInfo.OutgoingCFAOffset;
|
|
|
|
SuccInfo.IncomingCFARegister = CurrentInfo.OutgoingCFARegister;
|
2020-02-13 18:23:27 +01:00
|
|
|
SuccInfo.IncomingCSRSaved = CurrentInfo.OutgoingCSRSaved;
|
2018-05-11 17:54:46 +02:00
|
|
|
Stack.push_back(Succ);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} while (!Stack.empty());
|
2018-04-24 12:32:08 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
bool CFIInstrInserter::insertCFIInstrs(MachineFunction &MF) {
|
|
|
|
const MBBCFAInfo *PrevMBBInfo = &MBBVector[MF.front().getNumber()];
|
|
|
|
const TargetInstrInfo *TII = MF.getSubtarget().getInstrInfo();
|
|
|
|
bool InsertedCFIInstr = false;
|
|
|
|
|
|
|
|
for (MachineBasicBlock &MBB : MF) {
|
|
|
|
// Skip the first MBB in a function
|
|
|
|
if (MBB.getNumber() == MF.front().getNumber()) continue;
|
|
|
|
|
|
|
|
const MBBCFAInfo &MBBInfo = MBBVector[MBB.getNumber()];
|
|
|
|
auto MBBI = MBBInfo.MBB->begin();
|
|
|
|
DebugLoc DL = MBBInfo.MBB->findDebugLoc(MBBI);
|
|
|
|
|
Call Frame Information (CFI) Handling for Basic Block Sections
This patch handles CFI with basic block sections, which unlike DebugInfo does
not support ranges. The DWARF standard explicitly requires emitting separate
CFI Frame Descriptor Entries for each contiguous fragment of a function. Thus,
the CFI information for all callee-saved registers (possibly including the
frame pointer, if necessary) have to be emitted along with redefining the
Call Frame Address (CFA), viz. where the current frame starts.
CFI directives are emitted in FDE’s in the object file with a low_pc, high_pc
specification. So, a single FDE must point to a contiguous code region unlike
debug info which has the support for ranges. This is what complicates CFI for
basic block sections.
Now, what happens when we start placing individual basic blocks in unique
sections:
* Basic block sections allow the linker to randomly reorder basic blocks in the
address space such that a given basic block can become non-contiguous with the
original function.
* The different basic block sections can no longer share the cfi_startproc and
cfi_endproc directives. So, each basic block section should emit this
independently.
* Each (cfi_startproc, cfi_endproc) directive will result in a new FDE that
caters to that basic block section.
* Now, this basic block section needs to duplicate the information from the
entry block to compute the CFA as it is an independent entity. It cannot refer
to the FDE of the original function and hence must duplicate all the stuff that
is needed to compute the CFA on its own.
* We are working on a de-duplication patch that can share common information in
FDEs in a CIE (Common Information Entry) and we will present this as a follow up
patch. This can significantly reduce the duplication overhead and is
particularly useful when several basic block sections are created.
* The CFI directives are emitted similarly for registers that are pushed onto
the stack, like callee saved registers in the prologue. There are cfi
directives that emit how to retrieve the value of the register at that point
when the push happened. This has to be duplicated too in a basic block that is
floated as a separate section.
Differential Revision: https://reviews.llvm.org/D79978
2020-07-14 20:55:41 +02:00
|
|
|
// If the current MBB will be placed in a unique section, a full DefCfa
|
|
|
|
// must be emitted.
|
|
|
|
const bool ForceFullCFA = MBB.isBeginSection();
|
|
|
|
|
|
|
|
if ((PrevMBBInfo->OutgoingCFAOffset != MBBInfo.IncomingCFAOffset &&
|
|
|
|
PrevMBBInfo->OutgoingCFARegister != MBBInfo.IncomingCFARegister) ||
|
|
|
|
ForceFullCFA) {
|
2018-04-24 12:32:08 +02:00
|
|
|
// If both outgoing offset and register of a previous block don't match
|
Call Frame Information (CFI) Handling for Basic Block Sections
This patch handles CFI with basic block sections, which unlike DebugInfo does
not support ranges. The DWARF standard explicitly requires emitting separate
CFI Frame Descriptor Entries for each contiguous fragment of a function. Thus,
the CFI information for all callee-saved registers (possibly including the
frame pointer, if necessary) have to be emitted along with redefining the
Call Frame Address (CFA), viz. where the current frame starts.
CFI directives are emitted in FDE’s in the object file with a low_pc, high_pc
specification. So, a single FDE must point to a contiguous code region unlike
debug info which has the support for ranges. This is what complicates CFI for
basic block sections.
Now, what happens when we start placing individual basic blocks in unique
sections:
* Basic block sections allow the linker to randomly reorder basic blocks in the
address space such that a given basic block can become non-contiguous with the
original function.
* The different basic block sections can no longer share the cfi_startproc and
cfi_endproc directives. So, each basic block section should emit this
independently.
* Each (cfi_startproc, cfi_endproc) directive will result in a new FDE that
caters to that basic block section.
* Now, this basic block section needs to duplicate the information from the
entry block to compute the CFA as it is an independent entity. It cannot refer
to the FDE of the original function and hence must duplicate all the stuff that
is needed to compute the CFA on its own.
* We are working on a de-duplication patch that can share common information in
FDEs in a CIE (Common Information Entry) and we will present this as a follow up
patch. This can significantly reduce the duplication overhead and is
particularly useful when several basic block sections are created.
* The CFI directives are emitted similarly for registers that are pushed onto
the stack, like callee saved registers in the prologue. There are cfi
directives that emit how to retrieve the value of the register at that point
when the push happened. This has to be duplicated too in a basic block that is
floated as a separate section.
Differential Revision: https://reviews.llvm.org/D79978
2020-07-14 20:55:41 +02:00
|
|
|
// incoming offset and register of this block, or if this block begins a
|
|
|
|
// section, add a def_cfa instruction with the correct offset and
|
|
|
|
// register for this block.
|
|
|
|
unsigned CFIIndex = MF.addFrameInst(MCCFIInstruction::cfiDefCfa(
|
|
|
|
nullptr, MBBInfo.IncomingCFARegister, getCorrectCFAOffset(&MBB)));
|
|
|
|
BuildMI(*MBBInfo.MBB, MBBI, DL, TII->get(TargetOpcode::CFI_INSTRUCTION))
|
|
|
|
.addCFIIndex(CFIIndex);
|
|
|
|
InsertedCFIInstr = true;
|
|
|
|
} else if (PrevMBBInfo->OutgoingCFAOffset != MBBInfo.IncomingCFAOffset) {
|
|
|
|
// If outgoing offset of a previous block doesn't match incoming offset
|
|
|
|
// of this block, add a def_cfa_offset instruction with the correct
|
|
|
|
// offset for this block.
|
|
|
|
unsigned CFIIndex = MF.addFrameInst(MCCFIInstruction::cfiDefCfaOffset(
|
|
|
|
nullptr, getCorrectCFAOffset(&MBB)));
|
|
|
|
BuildMI(*MBBInfo.MBB, MBBI, DL, TII->get(TargetOpcode::CFI_INSTRUCTION))
|
|
|
|
.addCFIIndex(CFIIndex);
|
2018-04-24 12:32:08 +02:00
|
|
|
InsertedCFIInstr = true;
|
|
|
|
} else if (PrevMBBInfo->OutgoingCFARegister !=
|
|
|
|
MBBInfo.IncomingCFARegister) {
|
|
|
|
unsigned CFIIndex =
|
|
|
|
MF.addFrameInst(MCCFIInstruction::createDefCfaRegister(
|
|
|
|
nullptr, MBBInfo.IncomingCFARegister));
|
|
|
|
BuildMI(*MBBInfo.MBB, MBBI, DL, TII->get(TargetOpcode::CFI_INSTRUCTION))
|
|
|
|
.addCFIIndex(CFIIndex);
|
|
|
|
InsertedCFIInstr = true;
|
|
|
|
}
|
2020-02-13 18:23:27 +01:00
|
|
|
|
Call Frame Information (CFI) Handling for Basic Block Sections
This patch handles CFI with basic block sections, which unlike DebugInfo does
not support ranges. The DWARF standard explicitly requires emitting separate
CFI Frame Descriptor Entries for each contiguous fragment of a function. Thus,
the CFI information for all callee-saved registers (possibly including the
frame pointer, if necessary) have to be emitted along with redefining the
Call Frame Address (CFA), viz. where the current frame starts.
CFI directives are emitted in FDE’s in the object file with a low_pc, high_pc
specification. So, a single FDE must point to a contiguous code region unlike
debug info which has the support for ranges. This is what complicates CFI for
basic block sections.
Now, what happens when we start placing individual basic blocks in unique
sections:
* Basic block sections allow the linker to randomly reorder basic blocks in the
address space such that a given basic block can become non-contiguous with the
original function.
* The different basic block sections can no longer share the cfi_startproc and
cfi_endproc directives. So, each basic block section should emit this
independently.
* Each (cfi_startproc, cfi_endproc) directive will result in a new FDE that
caters to that basic block section.
* Now, this basic block section needs to duplicate the information from the
entry block to compute the CFA as it is an independent entity. It cannot refer
to the FDE of the original function and hence must duplicate all the stuff that
is needed to compute the CFA on its own.
* We are working on a de-duplication patch that can share common information in
FDEs in a CIE (Common Information Entry) and we will present this as a follow up
patch. This can significantly reduce the duplication overhead and is
particularly useful when several basic block sections are created.
* The CFI directives are emitted similarly for registers that are pushed onto
the stack, like callee saved registers in the prologue. There are cfi
directives that emit how to retrieve the value of the register at that point
when the push happened. This has to be duplicated too in a basic block that is
floated as a separate section.
Differential Revision: https://reviews.llvm.org/D79978
2020-07-14 20:55:41 +02:00
|
|
|
if (ForceFullCFA) {
|
|
|
|
MF.getSubtarget().getFrameLowering()->emitCalleeSavedFrameMoves(
|
|
|
|
*MBBInfo.MBB, MBBI);
|
|
|
|
InsertedCFIInstr = true;
|
|
|
|
PrevMBBInfo = &MBBInfo;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2020-02-13 18:23:27 +01:00
|
|
|
BitVector SetDifference = PrevMBBInfo->OutgoingCSRSaved;
|
|
|
|
SetDifference.reset(MBBInfo.IncomingCSRSaved);
|
|
|
|
for (int Reg : SetDifference.set_bits()) {
|
|
|
|
unsigned CFIIndex =
|
|
|
|
MF.addFrameInst(MCCFIInstruction::createRestore(nullptr, Reg));
|
|
|
|
BuildMI(*MBBInfo.MBB, MBBI, DL, TII->get(TargetOpcode::CFI_INSTRUCTION))
|
|
|
|
.addCFIIndex(CFIIndex);
|
|
|
|
InsertedCFIInstr = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
SetDifference = MBBInfo.IncomingCSRSaved;
|
|
|
|
SetDifference.reset(PrevMBBInfo->OutgoingCSRSaved);
|
|
|
|
for (int Reg : SetDifference.set_bits()) {
|
|
|
|
auto it = CSRLocMap.find(Reg);
|
|
|
|
assert(it != CSRLocMap.end() && "Reg should have an entry in CSRLocMap");
|
|
|
|
unsigned CFIIndex;
|
|
|
|
CSRSavedLocation RO = it->second;
|
|
|
|
if (!RO.Reg && RO.Offset) {
|
|
|
|
CFIIndex = MF.addFrameInst(
|
|
|
|
MCCFIInstruction::createOffset(nullptr, Reg, *RO.Offset));
|
|
|
|
} else if (RO.Reg && !RO.Offset) {
|
|
|
|
CFIIndex = MF.addFrameInst(
|
|
|
|
MCCFIInstruction::createRegister(nullptr, Reg, *RO.Reg));
|
|
|
|
} else {
|
|
|
|
llvm_unreachable("RO.Reg and RO.Offset cannot both be valid/invalid");
|
|
|
|
}
|
|
|
|
BuildMI(*MBBInfo.MBB, MBBI, DL, TII->get(TargetOpcode::CFI_INSTRUCTION))
|
|
|
|
.addCFIIndex(CFIIndex);
|
|
|
|
InsertedCFIInstr = true;
|
|
|
|
}
|
|
|
|
|
2018-04-24 12:32:08 +02:00
|
|
|
PrevMBBInfo = &MBBInfo;
|
|
|
|
}
|
|
|
|
return InsertedCFIInstr;
|
|
|
|
}
|
|
|
|
|
2020-02-13 18:23:27 +01:00
|
|
|
void CFIInstrInserter::reportCFAError(const MBBCFAInfo &Pred,
|
|
|
|
const MBBCFAInfo &Succ) {
|
2018-04-24 12:32:08 +02:00
|
|
|
errs() << "*** Inconsistent CFA register and/or offset between pred and succ "
|
|
|
|
"***\n";
|
2018-05-11 17:54:46 +02:00
|
|
|
errs() << "Pred: " << Pred.MBB->getName() << " #" << Pred.MBB->getNumber()
|
|
|
|
<< " in " << Pred.MBB->getParent()->getName()
|
2018-04-24 12:32:08 +02:00
|
|
|
<< " outgoing CFA Reg:" << Pred.OutgoingCFARegister << "\n";
|
2018-05-11 17:54:46 +02:00
|
|
|
errs() << "Pred: " << Pred.MBB->getName() << " #" << Pred.MBB->getNumber()
|
|
|
|
<< " in " << Pred.MBB->getParent()->getName()
|
2018-04-24 12:32:08 +02:00
|
|
|
<< " outgoing CFA Offset:" << Pred.OutgoingCFAOffset << "\n";
|
2018-05-11 17:54:46 +02:00
|
|
|
errs() << "Succ: " << Succ.MBB->getName() << " #" << Succ.MBB->getNumber()
|
2018-04-24 12:32:08 +02:00
|
|
|
<< " incoming CFA Reg:" << Succ.IncomingCFARegister << "\n";
|
2018-05-11 17:54:46 +02:00
|
|
|
errs() << "Succ: " << Succ.MBB->getName() << " #" << Succ.MBB->getNumber()
|
2018-04-24 12:32:08 +02:00
|
|
|
<< " incoming CFA Offset:" << Succ.IncomingCFAOffset << "\n";
|
|
|
|
}
|
|
|
|
|
2020-02-13 18:23:27 +01:00
|
|
|
void CFIInstrInserter::reportCSRError(const MBBCFAInfo &Pred,
|
|
|
|
const MBBCFAInfo &Succ) {
|
|
|
|
errs() << "*** Inconsistent CSR Saved between pred and succ in function "
|
|
|
|
<< Pred.MBB->getParent()->getName() << " ***\n";
|
|
|
|
errs() << "Pred: " << Pred.MBB->getName() << " #" << Pred.MBB->getNumber()
|
|
|
|
<< " outgoing CSR Saved: ";
|
|
|
|
for (int Reg : Pred.OutgoingCSRSaved.set_bits())
|
|
|
|
errs() << Reg << " ";
|
|
|
|
errs() << "\n";
|
|
|
|
errs() << "Succ: " << Succ.MBB->getName() << " #" << Succ.MBB->getNumber()
|
|
|
|
<< " incoming CSR Saved: ";
|
|
|
|
for (int Reg : Succ.IncomingCSRSaved.set_bits())
|
|
|
|
errs() << Reg << " ";
|
|
|
|
errs() << "\n";
|
|
|
|
}
|
|
|
|
|
2018-04-24 12:32:08 +02:00
|
|
|
unsigned CFIInstrInserter::verify(MachineFunction &MF) {
|
|
|
|
unsigned ErrorNum = 0;
|
2018-05-07 13:47:48 +02:00
|
|
|
for (auto *CurrMBB : depth_first(&MF)) {
|
|
|
|
const MBBCFAInfo &CurrMBBInfo = MBBVector[CurrMBB->getNumber()];
|
|
|
|
for (MachineBasicBlock *Succ : CurrMBB->successors()) {
|
2018-04-24 12:32:08 +02:00
|
|
|
const MBBCFAInfo &SuccMBBInfo = MBBVector[Succ->getNumber()];
|
|
|
|
// Check that incoming offset and register values of successors match the
|
|
|
|
// outgoing offset and register values of CurrMBB
|
|
|
|
if (SuccMBBInfo.IncomingCFAOffset != CurrMBBInfo.OutgoingCFAOffset ||
|
|
|
|
SuccMBBInfo.IncomingCFARegister != CurrMBBInfo.OutgoingCFARegister) {
|
2018-08-30 19:31:38 +02:00
|
|
|
// Inconsistent offsets/registers are ok for 'noreturn' blocks because
|
|
|
|
// we don't generate epilogues inside such blocks.
|
|
|
|
if (SuccMBBInfo.MBB->succ_empty() && !SuccMBBInfo.MBB->isReturnBlock())
|
|
|
|
continue;
|
2020-02-13 18:23:27 +01:00
|
|
|
reportCFAError(CurrMBBInfo, SuccMBBInfo);
|
|
|
|
ErrorNum++;
|
|
|
|
}
|
|
|
|
// Check that IncomingCSRSaved of every successor matches the
|
|
|
|
// OutgoingCSRSaved of CurrMBB
|
|
|
|
if (SuccMBBInfo.IncomingCSRSaved != CurrMBBInfo.OutgoingCSRSaved) {
|
|
|
|
reportCSRError(CurrMBBInfo, SuccMBBInfo);
|
2018-04-24 12:32:08 +02:00
|
|
|
ErrorNum++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ErrorNum;
|
|
|
|
}
|