RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 11:13:28 +01:00
Code Issues Projects Releases Wiki Activity
1f97534ae0
llvm-mirror/test/tools/llvm-objcopy/ELF/keep-global-symbols-mix-globalize.test

53 lines
1.5 KiB
Plaintext
Raw Normal View History

[test] Use yaml2obj -o %t instead of > %t To improve consistency and avoid unneeded shell feature (output redirection). While here, make other changes to improve consistency --docnum 1 => --docnum=1 -docnum=x => --docnum=x
2020-01-22 02:02:25 +01:00
# RUN: yaml2obj %s -o %t.o
[llvm-objcopy] Implement -G/--keep-global-symbol(s). Summary: Port GNU Objcopy -G/--keep-global-symbol(s). This is slightly different than the already-implemented --globalize-symbol, which marks a symbol as global when copying. When --keep-global-symbol (alias -G) is used, *only* those symbols marked will stay global, and all other globals are demoted to local. (Also note that it doesn't *promote* a symbol to global). Additionally, there is a pluralized version of the flag --keep-global-symbols, which effectively applies --keep-global-symbol for every non-comment in a file. Reviewers: jakehehrlich, jhenderson, alexshap Reviewed By: jhenderson Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D50589 llvm-svn: 340105
2018-08-18 00:34:48 +02:00
# Tests --keep-global-symbol when used in combination with --globalize-symbol on
# a different symbol.
# RUN: llvm-objcopy \
# RUN: --globalize-symbol Local1 \
# RUN: --keep-global-symbol Local2 \
# RUN: --globalize-symbol Weak1 \
# RUN: --keep-global-symbol Weak2 \
# RUN: --globalize-symbol Global1 \
# RUN: --keep-global-symbol Global2 \
# RUN: %t.o %t.2.o
[llvm-readobj] llvm-readobj --elf-output-style=GNU => llvm-readelf. NFC The latter is much more common. A dedicated --elf-output-style=GNU test demonstrating it is the same as llvm-readelf is sufficient. llvm-svn: 359652
2019-05-01 07:55:22 +02:00
# RUN: llvm-readelf --symbols %t.2.o | FileCheck %s
[llvm-objcopy] Implement -G/--keep-global-symbol(s). Summary: Port GNU Objcopy -G/--keep-global-symbol(s). This is slightly different than the already-implemented --globalize-symbol, which marks a symbol as global when copying. When --keep-global-symbol (alias -G) is used, *only* those symbols marked will stay global, and all other globals are demoted to local. (Also note that it doesn't *promote* a symbol to global). Additionally, there is a pluralized version of the flag --keep-global-symbols, which effectively applies --keep-global-symbol for every non-comment in a file. Reviewers: jakehehrlich, jhenderson, alexshap Reviewed By: jhenderson Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D50589 llvm-svn: 340105
2018-08-18 00:34:48 +02:00
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Symbols:
[yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping. Currently, YAML has the following syntax for describing the symbols: Symbols: Local: LocalSymbol1: ... LocalSymbol2: ... ... Global: GlobalSymbol1: ... Weak: ... GNUUnique: I.e. symbols are grouped by their bindings. That is not very convenient, because: It does not allow to set a custom binding, what can be useful for producing broken/special outputs for test cases. Adding a new binding would require to change a syntax (what we observed when added GNUUnique recently). It does not allow to change the order of the symbols in .symtab/.dynsym, i.e. currently all Local symbols are placed first, then Global, Weak and GNUUnique are following, but we are not able to change the order. It is not consistent. Binding is just one of the properties of the symbol, we do not group them by other properties. It makes the code more complex that it can be. This patch shows it can be simplified with the change performed. The patch changes the syntax to just: Symbols: Symbol1: ... Symbol2: ... ... With that, we are able to work with the binding field just like with any other symbol property. Differential revision: https://reviews.llvm.org/D60122 llvm-svn: 357595
2019-04-03 16:53:42 +02:00
- Name: Local1
Section: .text
- Name: Local2
Section: .text
- Name: Global1
Section: .text
Binding: STB_GLOBAL
- Name: Global2
Section: .text
Binding: STB_GLOBAL
- Name: Weak1
Section: .text
Binding: STB_WEAK
- Name: Weak2
Section: .text
Binding: STB_WEAK
[llvm-objcopy] Implement -G/--keep-global-symbol(s). Summary: Port GNU Objcopy -G/--keep-global-symbol(s). This is slightly different than the already-implemented --globalize-symbol, which marks a symbol as global when copying. When --keep-global-symbol (alias -G) is used, *only* those symbols marked will stay global, and all other globals are demoted to local. (Also note that it doesn't *promote* a symbol to global). Additionally, there is a pluralized version of the flag --keep-global-symbols, which effectively applies --keep-global-symbol for every non-comment in a file. Reviewers: jakehehrlich, jhenderson, alexshap Reviewed By: jhenderson Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D50589 llvm-svn: 340105
2018-08-18 00:34:48 +02:00
# CHECK: Symbol table '.symtab' contains 7 entries:
# CHECK-NEXT: Num: Value Size Type Bind Vis Ndx Name
# CHECK-NEXT: 0: {{.*}} LOCAL {{.*}}
# CHECK-NEXT: 1: {{.*}} LOCAL {{.*}} Local2
# CHECK-NEXT: 2: {{.*}} GLOBAL {{.*}} Local1
# CHECK-NEXT: 3: {{.*}} GLOBAL {{.*}} Global1
# CHECK-NEXT: 4: {{.*}} GLOBAL {{.*}} Global2
# CHECK-NEXT: 5: {{.*}} GLOBAL {{.*}} Weak1
# CHECK-NEXT: 6: {{.*}} WEAK {{.*}} Weak2
Reference in New Issue Copy Permalink