2019-07-09 21:21:01 +02:00
|
|
|
//===-- lib/MC/XCOFFObjectWriter.cpp - XCOFF file writer ------------------===//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file implements XCOFF object file writer information.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
#include "llvm/BinaryFormat/XCOFF.h"
|
|
|
|
#include "llvm/MC/MCAsmLayout.h"
|
2019-07-09 21:21:01 +02:00
|
|
|
#include "llvm/MC/MCAssembler.h"
|
|
|
|
#include "llvm/MC/MCObjectWriter.h"
|
2019-08-21 00:03:18 +02:00
|
|
|
#include "llvm/MC/MCSectionXCOFF.h"
|
|
|
|
#include "llvm/MC/MCSymbolXCOFF.h"
|
2019-07-09 21:21:01 +02:00
|
|
|
#include "llvm/MC/MCValue.h"
|
|
|
|
#include "llvm/MC/MCXCOFFObjectWriter.h"
|
2019-08-21 00:03:18 +02:00
|
|
|
#include "llvm/MC/StringTableBuilder.h"
|
|
|
|
#include "llvm/Support/Error.h"
|
|
|
|
#include "llvm/Support/MathExtras.h"
|
|
|
|
|
|
|
|
#include <deque>
|
2019-07-09 21:21:01 +02:00
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
// An XCOFF object file has a limited set of predefined sections. The most
|
|
|
|
// important ones for us (right now) are:
|
|
|
|
// .text --> contains program code and read-only data.
|
|
|
|
// .data --> contains initialized data, function descriptors, and the TOC.
|
|
|
|
// .bss --> contains uninitialized data.
|
|
|
|
// Each of these sections is composed of 'Control Sections'. A Control Section
|
|
|
|
// is more commonly referred to as a csect. A csect is an indivisible unit of
|
|
|
|
// code or data, and acts as a container for symbols. A csect is mapped
|
|
|
|
// into a section based on its storage-mapping class, with the exception of
|
|
|
|
// XMC_RW which gets mapped to either .data or .bss based on whether it's
|
|
|
|
// explicitly initialized or not.
|
|
|
|
//
|
|
|
|
// We don't represent the sections in the MC layer as there is nothing
|
|
|
|
// interesting about them at at that level: they carry information that is
|
|
|
|
// only relevant to the ObjectWriter, so we materialize them in this class.
|
2019-07-09 21:21:01 +02:00
|
|
|
namespace {
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
constexpr unsigned DefaultSectionAlign = 4;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
constexpr int16_t MaxSectionIndex = INT16_MAX;
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
// Packs the csect's alignment and type into a byte.
|
|
|
|
uint8_t getEncodedType(const MCSectionXCOFF *);
|
|
|
|
|
|
|
|
// Wrapper around an MCSymbolXCOFF.
|
|
|
|
struct Symbol {
|
|
|
|
const MCSymbolXCOFF *const MCSym;
|
|
|
|
uint32_t SymbolTableIndex;
|
|
|
|
|
|
|
|
XCOFF::StorageClass getStorageClass() const {
|
|
|
|
return MCSym->getStorageClass();
|
|
|
|
}
|
|
|
|
StringRef getName() const { return MCSym->getName(); }
|
|
|
|
Symbol(const MCSymbolXCOFF *MCSym) : MCSym(MCSym), SymbolTableIndex(-1) {}
|
|
|
|
};
|
|
|
|
|
|
|
|
// Wrapper for an MCSectionXCOFF.
|
|
|
|
struct ControlSection {
|
|
|
|
const MCSectionXCOFF *const MCCsect;
|
|
|
|
uint32_t SymbolTableIndex;
|
|
|
|
uint32_t Address;
|
|
|
|
uint32_t Size;
|
|
|
|
|
|
|
|
SmallVector<Symbol, 1> Syms;
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
StringRef getName() const { return MCCsect->getSectionName(); }
|
2019-08-21 00:03:18 +02:00
|
|
|
ControlSection(const MCSectionXCOFF *MCSec)
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
: MCCsect(MCSec), SymbolTableIndex(-1), Address(-1), Size(0) {}
|
2019-08-21 00:03:18 +02:00
|
|
|
};
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
// Type to be used for a container representing a set of csects with
|
|
|
|
// (approximately) the same storage mapping class. For example all the csects
|
|
|
|
// with a storage mapping class of `xmc_pr` will get placed into the same
|
|
|
|
// container.
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
using CsectGroup = std::deque<ControlSection>;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
|
|
|
|
using CsectGroups = std::deque<CsectGroup *>;
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
// Represents the data related to a section excluding the csects that make up
|
|
|
|
// the raw data of the section. The csects are stored separately as not all
|
|
|
|
// sections contain csects, and some sections contain csects which are better
|
|
|
|
// stored separately, e.g. the .data section containing read-write, descriptor,
|
|
|
|
// TOCBase and TOC-entry csects.
|
|
|
|
struct Section {
|
|
|
|
char Name[XCOFF::NameSize];
|
|
|
|
// The physical/virtual address of the section. For an object file
|
|
|
|
// these values are equivalent.
|
|
|
|
uint32_t Address;
|
|
|
|
uint32_t Size;
|
|
|
|
uint32_t FileOffsetToData;
|
|
|
|
uint32_t FileOffsetToRelocations;
|
|
|
|
uint32_t RelocationCount;
|
|
|
|
int32_t Flags;
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
int16_t Index;
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
// Virtual sections do not need storage allocated in the object file.
|
|
|
|
const bool IsVirtual;
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
// XCOFF has special section numbers for symbols:
|
|
|
|
// -2 Specifies N_DEBUG, a special symbolic debugging symbol.
|
|
|
|
// -1 Specifies N_ABS, an absolute symbol. The symbol has a value but is not
|
|
|
|
// relocatable.
|
|
|
|
// 0 Specifies N_UNDEF, an undefined external symbol.
|
|
|
|
// Therefore, we choose -3 (N_DEBUG - 1) to represent a section index that
|
|
|
|
// hasn't been initialized.
|
|
|
|
static constexpr int16_t UninitializedIndex =
|
|
|
|
XCOFF::ReservedSectionNum::N_DEBUG - 1;
|
|
|
|
|
|
|
|
CsectGroups Groups;
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
void reset() {
|
|
|
|
Address = 0;
|
|
|
|
Size = 0;
|
|
|
|
FileOffsetToData = 0;
|
|
|
|
FileOffsetToRelocations = 0;
|
|
|
|
RelocationCount = 0;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
Index = UninitializedIndex;
|
|
|
|
// Clear any csects we have stored.
|
|
|
|
for (auto *Group : Groups)
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
Group->clear();
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
Section(const char *N, XCOFF::SectionTypeFlags Flags, bool IsVirtual,
|
|
|
|
CsectGroups Groups)
|
2019-08-21 00:03:18 +02:00
|
|
|
: Address(0), Size(0), FileOffsetToData(0), FileOffsetToRelocations(0),
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
RelocationCount(0), Flags(Flags), Index(UninitializedIndex),
|
|
|
|
IsVirtual(IsVirtual), Groups(Groups) {
|
2019-08-21 00:03:18 +02:00
|
|
|
strncpy(Name, N, XCOFF::NameSize);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2019-07-09 21:21:01 +02:00
|
|
|
class XCOFFObjectWriter : public MCObjectWriter {
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
|
|
|
|
uint32_t SymbolTableEntryCount = 0;
|
|
|
|
uint32_t SymbolTableOffset = 0;
|
2019-10-28 22:46:22 +01:00
|
|
|
uint16_t SectionCount = 0;
|
2019-08-21 00:03:18 +02:00
|
|
|
|
2019-07-09 21:21:01 +02:00
|
|
|
support::endian::Writer W;
|
|
|
|
std::unique_ptr<MCXCOFFObjectTargetWriter> TargetObjectWriter;
|
2019-08-21 00:03:18 +02:00
|
|
|
StringTableBuilder Strings;
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
// CsectGroups. These store the csects which make up different parts of
|
|
|
|
// the sections. Should have one for each set of csects that get mapped into
|
|
|
|
// the same section and get handled in a 'similar' way.
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
CsectGroup ProgramCodeCsects;
|
|
|
|
CsectGroup DataCsects;
|
2019-11-19 16:09:07 +01:00
|
|
|
CsectGroup FuncDSCsects;
|
|
|
|
CsectGroup TOCCsects;
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
CsectGroup BSSCsects;
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
// The Predefined sections.
|
|
|
|
Section Text;
|
[PowerPC][AIX] Adds support for writing the data section in object files
Adds support for generating the XCOFF data section in object files for global variables with initialization.
Merged aix-xcoff-common.ll into aix-xcoff-data.ll.
Changed variable name charr to chrarray in the test case to test if readobj works with 8-character names.
Authored by: xingxue
Reviewers: hubert.reinterptrtcast, sfertile, jasonliu, daltenty, Xiangling_L.
Reviewed by: hubert.reinterpretcast, sfertile, daltenty.
Subscribers: DiggerLin, Wuzish, nemanjai, hiraditya, MaskRay, jsji, shchenz, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67125
2019-10-30 19:31:31 +01:00
|
|
|
Section Data;
|
2019-08-21 00:03:18 +02:00
|
|
|
Section BSS;
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
// All the XCOFF sections, in the order they will appear in the section header
|
|
|
|
// table.
|
[PowerPC][AIX] Adds support for writing the data section in object files
Adds support for generating the XCOFF data section in object files for global variables with initialization.
Merged aix-xcoff-common.ll into aix-xcoff-data.ll.
Changed variable name charr to chrarray in the test case to test if readobj works with 8-character names.
Authored by: xingxue
Reviewers: hubert.reinterptrtcast, sfertile, jasonliu, daltenty, Xiangling_L.
Reviewed by: hubert.reinterpretcast, sfertile, daltenty.
Subscribers: DiggerLin, Wuzish, nemanjai, hiraditya, MaskRay, jsji, shchenz, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67125
2019-10-30 19:31:31 +01:00
|
|
|
std::array<Section *const, 3> Sections{{&Text, &Data, &BSS}};
|
2019-08-21 00:03:18 +02:00
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
CsectGroup &getCsectGroup(const MCSectionXCOFF *MCSec);
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
virtual void reset() override;
|
2019-07-09 21:21:01 +02:00
|
|
|
|
|
|
|
void executePostLayoutBinding(MCAssembler &, const MCAsmLayout &) override;
|
|
|
|
|
|
|
|
void recordRelocation(MCAssembler &, const MCAsmLayout &, const MCFragment *,
|
|
|
|
const MCFixup &, MCValue, uint64_t &) override;
|
|
|
|
|
|
|
|
uint64_t writeObject(MCAssembler &, const MCAsmLayout &) override;
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
static bool nameShouldBeInStringTable(const StringRef &);
|
|
|
|
void writeSymbolName(const StringRef &);
|
|
|
|
void writeSymbolTableEntryForCsectMemberLabel(const Symbol &,
|
|
|
|
const ControlSection &, int16_t,
|
|
|
|
uint64_t);
|
|
|
|
void writeSymbolTableEntryForControlSection(const ControlSection &, int16_t,
|
|
|
|
XCOFF::StorageClass);
|
2019-08-21 00:03:18 +02:00
|
|
|
void writeFileHeader();
|
|
|
|
void writeSectionHeaderTable();
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
void writeSections(const MCAssembler &Asm, const MCAsmLayout &Layout);
|
|
|
|
void writeSymbolTable(const MCAsmLayout &Layout);
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
// Called after all the csects and symbols have been processed by
|
|
|
|
// `executePostLayoutBinding`, this function handles building up the majority
|
|
|
|
// of the structures in the object file representation. Namely:
|
|
|
|
// *) Calculates physical/virtual addresses, raw-pointer offsets, and section
|
|
|
|
// sizes.
|
|
|
|
// *) Assigns symbol table indices.
|
|
|
|
// *) Builds up the section header table by adding any non-empty sections to
|
|
|
|
// `Sections`.
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
void assignAddressesAndIndices(const MCAsmLayout &);
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
bool
|
|
|
|
needsAuxiliaryHeader() const { /* TODO aux header support not implemented. */
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Returns the size of the auxiliary header to be written to the object file.
|
|
|
|
size_t auxiliaryHeaderSize() const {
|
|
|
|
assert(!needsAuxiliaryHeader() &&
|
|
|
|
"Auxiliary header support not implemented.");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2019-07-09 21:21:01 +02:00
|
|
|
public:
|
|
|
|
XCOFFObjectWriter(std::unique_ptr<MCXCOFFObjectTargetWriter> MOTW,
|
|
|
|
raw_pwrite_stream &OS);
|
|
|
|
};
|
|
|
|
|
|
|
|
XCOFFObjectWriter::XCOFFObjectWriter(
|
|
|
|
std::unique_ptr<MCXCOFFObjectTargetWriter> MOTW, raw_pwrite_stream &OS)
|
2019-08-21 00:03:18 +02:00
|
|
|
: W(OS, support::big), TargetObjectWriter(std::move(MOTW)),
|
|
|
|
Strings(StringTableBuilder::XCOFF),
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
Text(".text", XCOFF::STYP_TEXT, /* IsVirtual */ false,
|
|
|
|
CsectGroups{&ProgramCodeCsects}),
|
[PowerPC][AIX] Adds support for writing the data section in object files
Adds support for generating the XCOFF data section in object files for global variables with initialization.
Merged aix-xcoff-common.ll into aix-xcoff-data.ll.
Changed variable name charr to chrarray in the test case to test if readobj works with 8-character names.
Authored by: xingxue
Reviewers: hubert.reinterptrtcast, sfertile, jasonliu, daltenty, Xiangling_L.
Reviewed by: hubert.reinterpretcast, sfertile, daltenty.
Subscribers: DiggerLin, Wuzish, nemanjai, hiraditya, MaskRay, jsji, shchenz, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67125
2019-10-30 19:31:31 +01:00
|
|
|
Data(".data", XCOFF::STYP_DATA, /* IsVirtual */ false,
|
2019-11-19 16:09:07 +01:00
|
|
|
CsectGroups{&DataCsects, &FuncDSCsects, &TOCCsects}),
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
BSS(".bss", XCOFF::STYP_BSS, /* IsVirtual */ true,
|
|
|
|
CsectGroups{&BSSCsects}) {}
|
2019-08-21 00:03:18 +02:00
|
|
|
|
|
|
|
void XCOFFObjectWriter::reset() {
|
|
|
|
// Reset any sections we have written to, and empty the section header table.
|
|
|
|
for (auto *Sec : Sections)
|
|
|
|
Sec->reset();
|
|
|
|
|
|
|
|
// Reset the symbol table and string table.
|
|
|
|
SymbolTableEntryCount = 0;
|
|
|
|
SymbolTableOffset = 0;
|
2019-10-28 22:46:22 +01:00
|
|
|
SectionCount = 0;
|
2019-08-21 00:03:18 +02:00
|
|
|
Strings.clear();
|
|
|
|
|
|
|
|
MCObjectWriter::reset();
|
|
|
|
}
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
CsectGroup &XCOFFObjectWriter::getCsectGroup(const MCSectionXCOFF *MCSec) {
|
|
|
|
switch (MCSec->getMappingClass()) {
|
|
|
|
case XCOFF::XMC_PR:
|
|
|
|
assert(XCOFF::XTY_SD == MCSec->getCSectType() &&
|
|
|
|
"Only an initialized csect can contain program code.");
|
|
|
|
return ProgramCodeCsects;
|
|
|
|
case XCOFF::XMC_RW:
|
|
|
|
if (XCOFF::XTY_CM == MCSec->getCSectType())
|
|
|
|
return BSSCsects;
|
|
|
|
|
[PowerPC][AIX] Adds support for writing the data section in object files
Adds support for generating the XCOFF data section in object files for global variables with initialization.
Merged aix-xcoff-common.ll into aix-xcoff-data.ll.
Changed variable name charr to chrarray in the test case to test if readobj works with 8-character names.
Authored by: xingxue
Reviewers: hubert.reinterptrtcast, sfertile, jasonliu, daltenty, Xiangling_L.
Reviewed by: hubert.reinterpretcast, sfertile, daltenty.
Subscribers: DiggerLin, Wuzish, nemanjai, hiraditya, MaskRay, jsji, shchenz, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67125
2019-10-30 19:31:31 +01:00
|
|
|
if (XCOFF::XTY_SD == MCSec->getCSectType())
|
|
|
|
return DataCsects;
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
report_fatal_error("Unhandled mapping of read-write csect to section.");
|
2019-11-19 16:09:07 +01:00
|
|
|
case XCOFF::XMC_DS:
|
|
|
|
return FuncDSCsects;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
case XCOFF::XMC_BS:
|
|
|
|
assert(XCOFF::XTY_CM == MCSec->getCSectType() &&
|
|
|
|
"Mapping invalid csect. CSECT with bss storage class must be "
|
|
|
|
"common type.");
|
|
|
|
return BSSCsects;
|
2019-11-19 16:09:07 +01:00
|
|
|
case XCOFF::XMC_TC0:
|
|
|
|
assert(XCOFF::XTY_SD == MCSec->getCSectType() &&
|
|
|
|
"Only an initialized csect can contain TOC-base.");
|
|
|
|
assert(TOCCsects.empty() &&
|
|
|
|
"We should have only one TOC-base, and it should be the first csect "
|
|
|
|
"in this CsectGroup.");
|
|
|
|
return TOCCsects;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
default:
|
|
|
|
report_fatal_error("Unhandled mapping of csect to section.");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
void XCOFFObjectWriter::executePostLayoutBinding(MCAssembler &Asm,
|
|
|
|
const MCAsmLayout &Layout) {
|
2019-08-21 00:03:18 +02:00
|
|
|
if (TargetObjectWriter->is64Bit())
|
|
|
|
report_fatal_error("64-bit XCOFF object files are not supported yet.");
|
|
|
|
|
|
|
|
// Maps the MC Section representation to its corresponding ControlSection
|
|
|
|
// wrapper. Needed for finding the ControlSection to insert an MCSymbol into
|
|
|
|
// from its containing MCSectionXCOFF.
|
|
|
|
DenseMap<const MCSectionXCOFF *, ControlSection *> WrapperMap;
|
2019-07-09 21:21:01 +02:00
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
for (const auto &S : Asm) {
|
2019-10-14 18:46:11 +02:00
|
|
|
const auto *MCSec = cast<const MCSectionXCOFF>(&S);
|
2019-08-21 00:03:18 +02:00
|
|
|
assert(WrapperMap.find(MCSec) == WrapperMap.end() &&
|
|
|
|
"Cannot add a csect twice.");
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
// If the name does not fit in the storage provided in the symbol table
|
|
|
|
// entry, add it to the string table.
|
|
|
|
if (nameShouldBeInStringTable(MCSec->getSectionName()))
|
|
|
|
Strings.add(MCSec->getSectionName());
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
CsectGroup &Group = getCsectGroup(MCSec);
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
Group.emplace_back(MCSec);
|
|
|
|
WrapperMap[MCSec] = &Group.back();
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
for (const MCSymbol &S : Asm.symbols()) {
|
|
|
|
// Nothing to do for temporary symbols.
|
|
|
|
if (S.isTemporary())
|
|
|
|
continue;
|
|
|
|
const MCSymbolXCOFF *XSym = cast<MCSymbolXCOFF>(&S);
|
|
|
|
|
|
|
|
// Map the symbol into its containing csect.
|
2019-08-22 17:11:23 +02:00
|
|
|
const MCSectionXCOFF *ContainingCsect = XSym->getContainingCsect();
|
2019-08-21 00:03:18 +02:00
|
|
|
assert(WrapperMap.find(ContainingCsect) != WrapperMap.end() &&
|
|
|
|
"Expected containing csect to exist in map");
|
|
|
|
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
// If the symbol is the Csect itself, we don't need to put the symbol
|
|
|
|
// into Csect's Syms.
|
|
|
|
if (XSym == ContainingCsect->getQualNameSymbol())
|
|
|
|
continue;
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
// Lookup the containing csect and add the symbol to it.
|
|
|
|
WrapperMap[ContainingCsect]->Syms.emplace_back(XSym);
|
|
|
|
|
|
|
|
// If the name does not fit in the storage provided in the symbol table
|
|
|
|
// entry, add it to the string table.
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
if (nameShouldBeInStringTable(XSym->getName()))
|
|
|
|
Strings.add(XSym->getName());
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
Strings.finalize();
|
|
|
|
assignAddressesAndIndices(Layout);
|
2019-07-09 21:21:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
void XCOFFObjectWriter::recordRelocation(MCAssembler &, const MCAsmLayout &,
|
|
|
|
const MCFragment *, const MCFixup &,
|
|
|
|
MCValue, uint64_t &) {
|
2019-11-19 16:09:07 +01:00
|
|
|
// TODO: recordRelocation is not yet implemented.
|
2019-07-09 21:21:01 +02:00
|
|
|
}
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
void XCOFFObjectWriter::writeSections(const MCAssembler &Asm,
|
|
|
|
const MCAsmLayout &Layout) {
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
uint32_t CurrentAddressLocation = 0;
|
|
|
|
for (const auto *Section : Sections) {
|
|
|
|
// Nothing to write for this Section.
|
|
|
|
if (Section->Index == Section::UninitializedIndex || Section->IsVirtual)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
assert(CurrentAddressLocation == Section->Address &&
|
|
|
|
"We should have no padding between sections.");
|
|
|
|
for (const auto *Group : Section->Groups) {
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
for (const auto &Csect : *Group) {
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
if (uint32_t PaddingSize = Csect.Address - CurrentAddressLocation)
|
|
|
|
W.OS.write_zeros(PaddingSize);
|
|
|
|
Asm.writeSectionData(W.OS, Csect.MCCsect, Layout);
|
|
|
|
CurrentAddressLocation = Csect.Address + Csect.Size;
|
|
|
|
}
|
|
|
|
}
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
|
|
|
|
// The size of the tail padding in a section is the end virtual address of
|
|
|
|
// the current section minus the the end virtual address of the last csect
|
|
|
|
// in that section.
|
|
|
|
if (uint32_t PaddingSize =
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
Section->Address + Section->Size - CurrentAddressLocation)
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
W.OS.write_zeros(PaddingSize);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t XCOFFObjectWriter::writeObject(MCAssembler &Asm,
|
|
|
|
const MCAsmLayout &Layout) {
|
2019-07-09 21:21:01 +02:00
|
|
|
// We always emit a timestamp of 0 for reproducibility, so ensure incremental
|
|
|
|
// linking is not enabled, in case, like with Windows COFF, such a timestamp
|
|
|
|
// is incompatible with incremental linking of XCOFF.
|
|
|
|
if (Asm.isIncrementalLinkerCompatible())
|
|
|
|
report_fatal_error("Incremental linking not supported for XCOFF.");
|
|
|
|
|
|
|
|
if (TargetObjectWriter->is64Bit())
|
|
|
|
report_fatal_error("64-bit XCOFF object files are not supported yet.");
|
|
|
|
|
|
|
|
uint64_t StartOffset = W.OS.tell();
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
writeFileHeader();
|
|
|
|
writeSectionHeaderTable();
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
writeSections(Asm, Layout);
|
2019-08-21 00:03:18 +02:00
|
|
|
// TODO writeRelocations();
|
2019-07-09 21:21:01 +02:00
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
writeSymbolTable(Layout);
|
2019-08-21 00:03:18 +02:00
|
|
|
// Write the string table.
|
|
|
|
Strings.write(W.OS);
|
2019-07-09 21:21:01 +02:00
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
return W.OS.tell() - StartOffset;
|
|
|
|
}
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
bool XCOFFObjectWriter::nameShouldBeInStringTable(const StringRef &SymbolName) {
|
|
|
|
return SymbolName.size() > XCOFF::NameSize;
|
|
|
|
}
|
|
|
|
|
|
|
|
void XCOFFObjectWriter::writeSymbolName(const StringRef &SymbolName) {
|
|
|
|
if (nameShouldBeInStringTable(SymbolName)) {
|
|
|
|
W.write<int32_t>(0);
|
|
|
|
W.write<uint32_t>(Strings.getOffset(SymbolName));
|
|
|
|
} else {
|
|
|
|
char Name[XCOFF::NameSize];
|
|
|
|
std::strncpy(Name, SymbolName.data(), XCOFF::NameSize);
|
|
|
|
ArrayRef<char> NameRef(Name, XCOFF::NameSize);
|
|
|
|
W.write(NameRef);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void XCOFFObjectWriter::writeSymbolTableEntryForCsectMemberLabel(
|
|
|
|
const Symbol &SymbolRef, const ControlSection &CSectionRef,
|
|
|
|
int16_t SectionIndex, uint64_t SymbolOffset) {
|
|
|
|
// Name or Zeros and string table offset
|
|
|
|
writeSymbolName(SymbolRef.getName());
|
|
|
|
assert(SymbolOffset <= UINT32_MAX - CSectionRef.Address &&
|
|
|
|
"Symbol address overflows.");
|
|
|
|
W.write<uint32_t>(CSectionRef.Address + SymbolOffset);
|
|
|
|
W.write<int16_t>(SectionIndex);
|
|
|
|
// Basic/Derived type. See the description of the n_type field for symbol
|
|
|
|
// table entries for a detailed description. Since we don't yet support
|
|
|
|
// visibility, and all other bits are either optionally set or reserved, this
|
|
|
|
// is always zero.
|
|
|
|
// TODO FIXME How to assert a symbol's visibilty is default?
|
|
|
|
// TODO Set the function indicator (bit 10, 0x0020) for functions
|
|
|
|
// when debugging is enabled.
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
W.write<uint8_t>(SymbolRef.getStorageClass());
|
|
|
|
// Always 1 aux entry for now.
|
|
|
|
W.write<uint8_t>(1);
|
|
|
|
|
|
|
|
// Now output the auxiliary entry.
|
|
|
|
W.write<uint32_t>(CSectionRef.SymbolTableIndex);
|
|
|
|
// Parameter typecheck hash. Not supported.
|
|
|
|
W.write<uint32_t>(0);
|
|
|
|
// Typecheck section number. Not supported.
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
// Symbol type: Label
|
|
|
|
W.write<uint8_t>(XCOFF::XTY_LD);
|
|
|
|
// Storage mapping class.
|
|
|
|
W.write<uint8_t>(CSectionRef.MCCsect->getMappingClass());
|
|
|
|
// Reserved (x_stab).
|
|
|
|
W.write<uint32_t>(0);
|
|
|
|
// Reserved (x_snstab).
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void XCOFFObjectWriter::writeSymbolTableEntryForControlSection(
|
|
|
|
const ControlSection &CSectionRef, int16_t SectionIndex,
|
|
|
|
XCOFF::StorageClass StorageClass) {
|
|
|
|
// n_name, n_zeros, n_offset
|
|
|
|
writeSymbolName(CSectionRef.getName());
|
|
|
|
// n_value
|
|
|
|
W.write<uint32_t>(CSectionRef.Address);
|
|
|
|
// n_scnum
|
|
|
|
W.write<int16_t>(SectionIndex);
|
|
|
|
// Basic/Derived type. See the description of the n_type field for symbol
|
|
|
|
// table entries for a detailed description. Since we don't yet support
|
|
|
|
// visibility, and all other bits are either optionally set or reserved, this
|
|
|
|
// is always zero.
|
|
|
|
// TODO FIXME How to assert a symbol's visibilty is default?
|
|
|
|
// TODO Set the function indicator (bit 10, 0x0020) for functions
|
|
|
|
// when debugging is enabled.
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
// n_sclass
|
|
|
|
W.write<uint8_t>(StorageClass);
|
|
|
|
// Always 1 aux entry for now.
|
|
|
|
W.write<uint8_t>(1);
|
|
|
|
|
|
|
|
// Now output the auxiliary entry.
|
|
|
|
W.write<uint32_t>(CSectionRef.Size);
|
|
|
|
// Parameter typecheck hash. Not supported.
|
|
|
|
W.write<uint32_t>(0);
|
|
|
|
// Typecheck section number. Not supported.
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
// Symbol type.
|
|
|
|
W.write<uint8_t>(getEncodedType(CSectionRef.MCCsect));
|
|
|
|
// Storage mapping class.
|
|
|
|
W.write<uint8_t>(CSectionRef.MCCsect->getMappingClass());
|
|
|
|
// Reserved (x_stab).
|
|
|
|
W.write<uint32_t>(0);
|
|
|
|
// Reserved (x_snstab).
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
}
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
void XCOFFObjectWriter::writeFileHeader() {
|
2019-07-09 21:21:01 +02:00
|
|
|
// Magic.
|
|
|
|
W.write<uint16_t>(0x01df);
|
|
|
|
// Number of sections.
|
2019-10-28 22:46:22 +01:00
|
|
|
W.write<uint16_t>(SectionCount);
|
2019-07-09 21:21:01 +02:00
|
|
|
// Timestamp field. For reproducible output we write a 0, which represents no
|
|
|
|
// timestamp.
|
|
|
|
W.write<int32_t>(0);
|
|
|
|
// Byte Offset to the start of the symbol table.
|
2019-08-21 00:03:18 +02:00
|
|
|
W.write<uint32_t>(SymbolTableOffset);
|
2019-07-09 21:21:01 +02:00
|
|
|
// Number of entries in the symbol table.
|
2019-08-21 00:03:18 +02:00
|
|
|
W.write<int32_t>(SymbolTableEntryCount);
|
2019-07-09 21:21:01 +02:00
|
|
|
// Size of the optional header.
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
// Flags.
|
|
|
|
W.write<uint16_t>(0);
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
2019-07-09 21:21:01 +02:00
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
void XCOFFObjectWriter::writeSectionHeaderTable() {
|
|
|
|
for (const auto *Sec : Sections) {
|
2019-10-28 22:46:22 +01:00
|
|
|
// Nothing to write for this Section.
|
|
|
|
if (Sec->Index == Section::UninitializedIndex)
|
|
|
|
continue;
|
|
|
|
|
2019-08-21 00:03:18 +02:00
|
|
|
// Write Name.
|
|
|
|
ArrayRef<char> NameRef(Sec->Name, XCOFF::NameSize);
|
|
|
|
W.write(NameRef);
|
|
|
|
|
|
|
|
// Write the Physical Address and Virtual Address. In an object file these
|
|
|
|
// are the same.
|
|
|
|
W.write<uint32_t>(Sec->Address);
|
|
|
|
W.write<uint32_t>(Sec->Address);
|
|
|
|
|
|
|
|
W.write<uint32_t>(Sec->Size);
|
|
|
|
W.write<uint32_t>(Sec->FileOffsetToData);
|
|
|
|
|
|
|
|
// Relocation pointer and Lineno pointer. Not supported yet.
|
|
|
|
W.write<uint32_t>(0);
|
|
|
|
W.write<uint32_t>(0);
|
|
|
|
|
|
|
|
// Relocation and line-number counts. Not supported yet.
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
W.write<uint16_t>(0);
|
|
|
|
|
|
|
|
W.write<int32_t>(Sec->Flags);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
void XCOFFObjectWriter::writeSymbolTable(const MCAsmLayout &Layout) {
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
for (const auto *Section : Sections) {
|
2019-10-28 22:46:22 +01:00
|
|
|
// Nothing to write for this Section.
|
|
|
|
if (Section->Index == Section::UninitializedIndex)
|
|
|
|
continue;
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
for (const auto *Group : Section->Groups) {
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
if (Group->empty())
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
continue;
|
|
|
|
|
|
|
|
const int16_t SectionIndex = Section->Index;
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
for (const auto &Csect : *Group) {
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
// Write out the control section first and then each symbol in it.
|
|
|
|
writeSymbolTableEntryForControlSection(
|
|
|
|
Csect, SectionIndex, Csect.MCCsect->getStorageClass());
|
|
|
|
|
|
|
|
for (const auto Sym : Csect.Syms)
|
|
|
|
writeSymbolTableEntryForCsectMemberLabel(
|
|
|
|
Sym, Csect, SectionIndex, Layout.getSymbolOffset(*(Sym.MCSym)));
|
|
|
|
}
|
|
|
|
}
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
void XCOFFObjectWriter::assignAddressesAndIndices(const MCAsmLayout &Layout) {
|
2019-08-21 00:03:18 +02:00
|
|
|
// The address corrresponds to the address of sections and symbols in the
|
|
|
|
// object file. We place the shared address 0 immediately after the
|
|
|
|
// section header table.
|
|
|
|
uint32_t Address = 0;
|
|
|
|
// Section indices are 1-based in XCOFF.
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
int32_t SectionIndex = 1;
|
2019-08-21 00:03:18 +02:00
|
|
|
// The first symbol table entry is for the file name. We are not emitting it
|
|
|
|
// yet, so start at index 0.
|
|
|
|
uint32_t SymbolTableIndex = 0;
|
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
for (auto *Section : Sections) {
|
|
|
|
const bool IsEmpty =
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
llvm::all_of(Section->Groups,
|
|
|
|
[](const CsectGroup *Group) { return Group->empty(); });
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
if (IsEmpty)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (SectionIndex > MaxSectionIndex)
|
|
|
|
report_fatal_error("Section index overflow!");
|
|
|
|
Section->Index = SectionIndex++;
|
2019-10-28 22:46:22 +01:00
|
|
|
SectionCount++;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
|
|
|
|
bool SectionAddressSet = false;
|
|
|
|
for (auto *Group : Section->Groups) {
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
if (Group->empty())
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
continue;
|
|
|
|
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
for (auto &Csect : *Group) {
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
const MCSectionXCOFF *MCSec = Csect.MCCsect;
|
|
|
|
Csect.Address = alignTo(Address, MCSec->getAlignment());
|
|
|
|
Csect.Size = Layout.getSectionAddressSize(MCSec);
|
|
|
|
Address = Csect.Address + Csect.Size;
|
|
|
|
Csect.SymbolTableIndex = SymbolTableIndex;
|
|
|
|
// 1 main and 1 auxiliary symbol table entry for the csect.
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
SymbolTableIndex += 2;
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
for (auto &Sym : Csect.Syms) {
|
|
|
|
Sym.SymbolTableIndex = SymbolTableIndex;
|
|
|
|
// 1 main and 1 auxiliary symbol table entry for each contained
|
|
|
|
// symbol.
|
|
|
|
SymbolTableIndex += 2;
|
|
|
|
}
|
|
|
|
}
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
if (!SectionAddressSet) {
|
[XCOFF][AIX] Differentiate usage of label symbol and csect symbol
Summary:
We are using symbols to represent label and csect interchangeably before, and that could be a problem.
There are cases we would need to add storage mapping class to the symbol if that symbol is actually the name of a csect, but it's hard for us to figure out whether that symbol is a label or csect.
This patch intend to do the following:
1. Construct a QualName (A name include the storage mapping class)
MCSymbolXCOFF for every MCSectionXCOFF.
2. Keep a pointer to that QualName inside of MCSectionXCOFF.
3. Use that QualName whenever we need a symbol refers to that
MCSectionXCOFF.
4. Adapt the snowball effect from the above changes in
XCOFFObjectWriter.cpp.
Reviewers: xingxue, DiggerLin, sfertile, daltenty, hubert.reinterpretcast
Reviewed By: DiggerLin, daltenty
Subscribers: wuzish, nemanjai, mgorny, hiraditya, kbarton, jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69633
2019-11-08 15:26:28 +01:00
|
|
|
Section->Address = Group->front().Address;
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
SectionAddressSet = true;
|
|
|
|
}
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
[XCOFF] Output object text section header and symbol entry for program code.
This is remaining part of rG41ca91f2995b: [AIX][XCOFF] Output XCOFF
object text section header and symbol entry for rogram code.
SUMMARY:
Original form of this patch is provided by Stefan Pintillie.
1. The patch try to output program code section header , symbol entry for
program code (PR) and Instruction into the raw text section.
2. The patch include how to alignment and layout the CSection in the text
section.
3. The patch also reorganize the code , put some codes into a function.
(XCOFFObjectWriter::writeSymbolTableEntryForControlSection)
Additional: We can not add raw data of text section test in the patch, If want
to output raw text section data,it need a function description patch first.
Reviewers: hubert.reinterpretcast, sfertile, jasonliu, xingxue.
Subscribers: wuzish, nemanjai, hiraditya, MaskRay, jsjji.
Differential Revision: https://reviews.llvm.org/D66969
llvm-svn: 374923
2019-10-15 19:40:41 +02:00
|
|
|
|
[NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup
Summary:
Right now we handle each CsectGroup(ProgramCodeCsects, BSSCsects)
individually when assigning indices, writing symbol table, and
writing section raw data. However, there is already a pattern there,
and we could common up those actions for every CsectGroup. This will
make adding new CsectGroup(Read Write data, Read only data, TC/TOC,
mergeable string) easier, and less error prone.
Reviewed by: sfertile, daltenty, DiggerLin
Approved by: daltenty
Differential Revision: https://reviews.llvm.org/D69112
2019-10-24 17:19:12 +02:00
|
|
|
// Make sure the address of the next section aligned to
|
|
|
|
// DefaultSectionAlign.
|
|
|
|
Address = alignTo(Address, DefaultSectionAlign);
|
|
|
|
Section->Size = Address - Section->Address;
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
SymbolTableEntryCount = SymbolTableIndex;
|
|
|
|
|
|
|
|
// Calculate the RawPointer value for each section.
|
|
|
|
uint64_t RawPointer = sizeof(XCOFF::FileHeader32) + auxiliaryHeaderSize() +
|
2019-10-28 22:46:22 +01:00
|
|
|
SectionCount * sizeof(XCOFF::SectionHeader32);
|
2019-08-21 00:03:18 +02:00
|
|
|
for (auto *Sec : Sections) {
|
2019-10-28 22:46:22 +01:00
|
|
|
if (Sec->Index == Section::UninitializedIndex || Sec->IsVirtual)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
Sec->FileOffsetToData = RawPointer;
|
|
|
|
RawPointer += Sec->Size;
|
2019-08-21 00:03:18 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// TODO Add in Relocation storage to the RawPointer Calculation.
|
|
|
|
// TODO What to align the SymbolTable to?
|
|
|
|
// TODO Error check that the number of symbol table entries fits in 32-bits
|
|
|
|
// signed ...
|
|
|
|
if (SymbolTableEntryCount)
|
|
|
|
SymbolTableOffset = RawPointer;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Takes the log base 2 of the alignment and shifts the result into the 5 most
|
|
|
|
// significant bits of a byte, then or's in the csect type into the least
|
|
|
|
// significant 3 bits.
|
|
|
|
uint8_t getEncodedType(const MCSectionXCOFF *Sec) {
|
|
|
|
unsigned Align = Sec->getAlignment();
|
|
|
|
assert(isPowerOf2_32(Align) && "Alignment must be a power of 2.");
|
|
|
|
unsigned Log2Align = Log2_32(Align);
|
|
|
|
// Result is a number in the range [0, 31] which fits in the 5 least
|
|
|
|
// significant bits. Shift this value into the 5 most significant bits, and
|
|
|
|
// bitwise-or in the csect type.
|
|
|
|
uint8_t EncodedAlign = Log2Align << 3;
|
|
|
|
return EncodedAlign | Sec->getCSectType();
|
2019-07-09 21:21:01 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
std::unique_ptr<MCObjectWriter>
|
|
|
|
llvm::createXCOFFObjectWriter(std::unique_ptr<MCXCOFFObjectTargetWriter> MOTW,
|
|
|
|
raw_pwrite_stream &OS) {
|
2019-08-15 17:54:37 +02:00
|
|
|
return std::make_unique<XCOFFObjectWriter>(std::move(MOTW), OS);
|
2019-07-09 21:21:01 +02:00
|
|
|
}
|