2017-05-15 23:57:41 +02:00
|
|
|
//===- AttributeImpl.h - Attribute Internals --------------------*- C++ -*-===//
|
2012-09-26 23:07:29 +02:00
|
|
|
//
|
2019-01-19 09:50:56 +01:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2012-09-26 23:07:29 +02:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
2012-12-20 22:28:43 +01:00
|
|
|
///
|
|
|
|
/// \file
|
2018-05-01 17:54:18 +02:00
|
|
|
/// This file defines various helper methods and classes used by
|
2012-12-20 22:28:43 +01:00
|
|
|
/// LLVMContextImpl for creating and managing attributes.
|
|
|
|
///
|
2012-09-26 23:07:29 +02:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-08-13 18:26:38 +02:00
|
|
|
#ifndef LLVM_LIB_IR_ATTRIBUTEIMPL_H
|
|
|
|
#define LLVM_LIB_IR_ATTRIBUTEIMPL_H
|
2012-09-26 23:07:29 +02:00
|
|
|
|
2016-12-07 23:06:02 +01:00
|
|
|
#include "llvm/ADT/ArrayRef.h"
|
2012-09-26 23:07:29 +02:00
|
|
|
#include "llvm/ADT/FoldingSet.h"
|
2016-12-07 23:06:02 +01:00
|
|
|
#include "llvm/ADT/StringRef.h"
|
2013-01-02 12:36:10 +01:00
|
|
|
#include "llvm/IR/Attributes.h"
|
2016-12-07 23:06:02 +01:00
|
|
|
#include "llvm/Support/TrailingObjects.h"
|
|
|
|
#include <cassert>
|
|
|
|
#include <cstddef>
|
|
|
|
#include <cstdint>
|
2016-01-29 23:35:29 +01:00
|
|
|
#include <string>
|
2016-12-07 23:06:02 +01:00
|
|
|
#include <utility>
|
2012-09-26 23:07:29 +02:00
|
|
|
|
|
|
|
namespace llvm {
|
|
|
|
|
2012-12-20 00:55:43 +01:00
|
|
|
class LLVMContext;
|
2019-05-30 20:48:23 +02:00
|
|
|
class Type;
|
2012-12-20 00:55:43 +01:00
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// \class
|
2018-05-01 17:54:18 +02:00
|
|
|
/// This class represents a single, uniqued attribute. That attribute
|
2013-07-11 14:13:16 +02:00
|
|
|
/// could be a single enum, a tuple, or a string.
|
2013-09-11 20:05:11 +02:00
|
|
|
class AttributeImpl : public FoldingSetNode {
|
2013-07-11 14:13:16 +02:00
|
|
|
unsigned char KindID; ///< Holds the AttrEntryKind of the attribute
|
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
protected:
|
|
|
|
enum AttrEntryKind {
|
|
|
|
EnumAttrEntry,
|
2014-07-18 08:51:55 +02:00
|
|
|
IntAttrEntry,
|
2019-05-30 20:48:23 +02:00
|
|
|
StringAttrEntry,
|
|
|
|
TypeAttrEntry,
|
2013-02-05 23:37:24 +01:00
|
|
|
};
|
|
|
|
|
2013-07-11 14:13:16 +02:00
|
|
|
AttributeImpl(AttrEntryKind KindID) : KindID(KindID) {}
|
2013-01-27 22:38:03 +01:00
|
|
|
|
2012-09-26 23:07:29 +02:00
|
|
|
public:
|
2016-12-07 23:06:02 +01:00
|
|
|
// AttributesImpl is uniqued, these should not be available.
|
|
|
|
AttributeImpl(const AttributeImpl &) = delete;
|
|
|
|
AttributeImpl &operator=(const AttributeImpl &) = delete;
|
|
|
|
|
2013-11-18 10:31:53 +01:00
|
|
|
virtual ~AttributeImpl();
|
|
|
|
|
2013-07-11 14:13:16 +02:00
|
|
|
bool isEnumAttribute() const { return KindID == EnumAttrEntry; }
|
2014-07-18 08:51:55 +02:00
|
|
|
bool isIntAttribute() const { return KindID == IntAttrEntry; }
|
2013-07-11 14:13:16 +02:00
|
|
|
bool isStringAttribute() const { return KindID == StringAttrEntry; }
|
2019-05-30 20:48:23 +02:00
|
|
|
bool isTypeAttribute() const { return KindID == TypeAttrEntry; }
|
2012-10-08 23:47:17 +02:00
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
bool hasAttribute(Attribute::AttrKind A) const;
|
|
|
|
bool hasAttribute(StringRef Kind) const;
|
2012-10-08 23:47:17 +02:00
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
Attribute::AttrKind getKindAsEnum() const;
|
|
|
|
uint64_t getValueAsInt() const;
|
2012-12-30 02:38:39 +01:00
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
StringRef getKindAsString() const;
|
|
|
|
StringRef getValueAsString() const;
|
2012-12-30 02:38:39 +01:00
|
|
|
|
2019-05-30 20:48:23 +02:00
|
|
|
Type *getValueAsType() const;
|
|
|
|
|
2018-05-01 17:54:18 +02:00
|
|
|
/// Used when sorting the attributes.
|
2013-01-24 01:06:56 +01:00
|
|
|
bool operator<(const AttributeImpl &AI) const;
|
|
|
|
|
2012-09-26 23:07:29 +02:00
|
|
|
void Profile(FoldingSetNodeID &ID) const {
|
2013-02-05 23:37:24 +01:00
|
|
|
if (isEnumAttribute())
|
2019-05-30 20:48:23 +02:00
|
|
|
Profile(ID, getKindAsEnum(), static_cast<uint64_t>(0));
|
2014-07-18 08:51:55 +02:00
|
|
|
else if (isIntAttribute())
|
2013-02-05 23:37:24 +01:00
|
|
|
Profile(ID, getKindAsEnum(), getValueAsInt());
|
2019-05-30 20:48:23 +02:00
|
|
|
else if (isStringAttribute())
|
2019-05-29 22:46:38 +02:00
|
|
|
Profile(ID, getKindAsString(), getValueAsString());
|
2019-05-30 20:48:23 +02:00
|
|
|
else
|
|
|
|
Profile(ID, getKindAsEnum(), getValueAsType());
|
2013-02-05 23:37:24 +01:00
|
|
|
}
|
2017-05-15 23:57:41 +02:00
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
static void Profile(FoldingSetNodeID &ID, Attribute::AttrKind Kind,
|
|
|
|
uint64_t Val) {
|
|
|
|
ID.AddInteger(Kind);
|
|
|
|
if (Val) ID.AddInteger(Val);
|
2012-09-26 23:07:29 +02:00
|
|
|
}
|
2017-05-15 23:57:41 +02:00
|
|
|
|
2013-02-05 23:37:24 +01:00
|
|
|
static void Profile(FoldingSetNodeID &ID, StringRef Kind, StringRef Values) {
|
|
|
|
ID.AddString(Kind);
|
2013-02-28 22:17:03 +01:00
|
|
|
if (!Values.empty()) ID.AddString(Values);
|
2013-01-29 01:34:06 +01:00
|
|
|
}
|
2019-05-30 20:48:23 +02:00
|
|
|
|
|
|
|
static void Profile(FoldingSetNodeID &ID, Attribute::AttrKind Kind,
|
|
|
|
Type *Ty) {
|
|
|
|
ID.AddInteger(Kind);
|
|
|
|
ID.AddPointer(Ty);
|
|
|
|
}
|
2012-09-26 23:07:29 +02:00
|
|
|
};
|
|
|
|
|
2013-07-11 14:13:16 +02:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// \class
|
2018-05-01 17:54:18 +02:00
|
|
|
/// A set of classes that contain the value of the
|
2013-07-11 14:13:16 +02:00
|
|
|
/// attribute object. There are three main categories: enum attribute entries,
|
|
|
|
/// represented by Attribute::AttrKind; alignment attribute entries; and string
|
|
|
|
/// attribute enties, which are for target-dependent attributes.
|
|
|
|
|
2013-09-11 20:05:11 +02:00
|
|
|
class EnumAttributeImpl : public AttributeImpl {
|
2013-11-19 01:57:56 +01:00
|
|
|
virtual void anchor();
|
2017-06-20 00:05:08 +02:00
|
|
|
|
2013-07-11 14:13:16 +02:00
|
|
|
Attribute::AttrKind Kind;
|
|
|
|
|
|
|
|
protected:
|
|
|
|
EnumAttributeImpl(AttrEntryKind ID, Attribute::AttrKind Kind)
|
|
|
|
: AttributeImpl(ID), Kind(Kind) {}
|
|
|
|
|
|
|
|
public:
|
|
|
|
EnumAttributeImpl(Attribute::AttrKind Kind)
|
|
|
|
: AttributeImpl(EnumAttrEntry), Kind(Kind) {}
|
|
|
|
|
|
|
|
Attribute::AttrKind getEnumKind() const { return Kind; }
|
|
|
|
};
|
|
|
|
|
2014-07-18 08:51:55 +02:00
|
|
|
class IntAttributeImpl : public EnumAttributeImpl {
|
|
|
|
uint64_t Val;
|
2013-07-11 14:13:16 +02:00
|
|
|
|
2017-05-15 23:57:41 +02:00
|
|
|
void anchor() override;
|
|
|
|
|
2013-07-11 14:13:16 +02:00
|
|
|
public:
|
2014-07-18 08:51:55 +02:00
|
|
|
IntAttributeImpl(Attribute::AttrKind Kind, uint64_t Val)
|
|
|
|
: EnumAttributeImpl(IntAttrEntry, Kind), Val(Val) {
|
2015-04-16 22:29:50 +02:00
|
|
|
assert((Kind == Attribute::Alignment || Kind == Attribute::StackAlignment ||
|
|
|
|
Kind == Attribute::Dereferenceable ||
|
2016-04-12 03:05:35 +02:00
|
|
|
Kind == Attribute::DereferenceableOrNull ||
|
|
|
|
Kind == Attribute::AllocSize) &&
|
2015-04-16 22:29:50 +02:00
|
|
|
"Wrong kind for int attribute!");
|
2013-07-11 14:13:16 +02:00
|
|
|
}
|
|
|
|
|
2014-07-18 08:51:55 +02:00
|
|
|
uint64_t getValue() const { return Val; }
|
2013-07-11 14:13:16 +02:00
|
|
|
};
|
|
|
|
|
2013-09-11 20:05:11 +02:00
|
|
|
class StringAttributeImpl : public AttributeImpl {
|
2013-11-19 01:57:56 +01:00
|
|
|
virtual void anchor();
|
2017-06-20 00:05:08 +02:00
|
|
|
|
2013-07-11 14:13:16 +02:00
|
|
|
std::string Kind;
|
|
|
|
std::string Val;
|
|
|
|
|
|
|
|
public:
|
|
|
|
StringAttributeImpl(StringRef Kind, StringRef Val = StringRef())
|
|
|
|
: AttributeImpl(StringAttrEntry), Kind(Kind), Val(Val) {}
|
|
|
|
|
|
|
|
StringRef getStringKind() const { return Kind; }
|
|
|
|
StringRef getStringValue() const { return Val; }
|
|
|
|
};
|
|
|
|
|
2019-05-30 20:48:23 +02:00
|
|
|
class TypeAttributeImpl : public EnumAttributeImpl {
|
|
|
|
virtual void anchor();
|
|
|
|
|
|
|
|
Type *Ty;
|
|
|
|
|
|
|
|
public:
|
|
|
|
TypeAttributeImpl(Attribute::AttrKind Kind, Type *Ty)
|
|
|
|
: EnumAttributeImpl(TypeAttrEntry, Kind), Ty(Ty) {}
|
|
|
|
|
|
|
|
Type *getTypeValue() const { return Ty; }
|
|
|
|
};
|
|
|
|
|
2017-04-12 02:38:00 +02:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// \class
|
2018-05-01 17:54:18 +02:00
|
|
|
/// This class represents a group of attributes that apply to one
|
2017-04-12 02:38:00 +02:00
|
|
|
/// element: function, return type, or parameter.
|
|
|
|
class AttributeSetNode final
|
|
|
|
: public FoldingSetNode,
|
|
|
|
private TrailingObjects<AttributeSetNode, Attribute> {
|
|
|
|
friend TrailingObjects;
|
|
|
|
|
|
|
|
unsigned NumAttrs; ///< Number of attributes in this node.
|
2019-07-13 02:29:03 +02:00
|
|
|
/// Bitset with a bit for each available attribute Attribute::AttrKind.
|
|
|
|
uint8_t AvailableAttrs[12] = {};
|
2017-04-12 02:38:00 +02:00
|
|
|
|
|
|
|
AttributeSetNode(ArrayRef<Attribute> Attrs);
|
|
|
|
|
|
|
|
public:
|
|
|
|
// AttributesSetNode is uniqued, these should not be available.
|
|
|
|
AttributeSetNode(const AttributeSetNode &) = delete;
|
|
|
|
AttributeSetNode &operator=(const AttributeSetNode &) = delete;
|
|
|
|
|
|
|
|
void operator delete(void *p) { ::operator delete(p); }
|
|
|
|
|
|
|
|
static AttributeSetNode *get(LLVMContext &C, const AttrBuilder &B);
|
|
|
|
|
|
|
|
static AttributeSetNode *get(LLVMContext &C, ArrayRef<Attribute> Attrs);
|
|
|
|
|
2018-05-01 17:54:18 +02:00
|
|
|
/// Return the number of attributes this AttributeList contains.
|
2017-04-12 02:38:00 +02:00
|
|
|
unsigned getNumAttributes() const { return NumAttrs; }
|
|
|
|
|
|
|
|
bool hasAttribute(Attribute::AttrKind Kind) const {
|
2019-07-13 02:29:03 +02:00
|
|
|
return AvailableAttrs[Kind / 8] & ((uint64_t)1) << (Kind % 8);
|
2017-04-12 02:38:00 +02:00
|
|
|
}
|
|
|
|
bool hasAttribute(StringRef Kind) const;
|
|
|
|
bool hasAttributes() const { return NumAttrs != 0; }
|
|
|
|
|
|
|
|
Attribute getAttribute(Attribute::AttrKind Kind) const;
|
|
|
|
Attribute getAttribute(StringRef Kind) const;
|
|
|
|
|
|
|
|
unsigned getAlignment() const;
|
|
|
|
unsigned getStackAlignment() const;
|
|
|
|
uint64_t getDereferenceableBytes() const;
|
|
|
|
uint64_t getDereferenceableOrNullBytes() const;
|
|
|
|
std::pair<unsigned, Optional<unsigned>> getAllocSizeArgs() const;
|
|
|
|
std::string getAsString(bool InAttrGrp) const;
|
2019-05-30 20:48:23 +02:00
|
|
|
Type *getByValType() const;
|
2017-04-12 02:38:00 +02:00
|
|
|
|
2017-05-15 23:57:41 +02:00
|
|
|
using iterator = const Attribute *;
|
|
|
|
|
2017-04-12 02:38:00 +02:00
|
|
|
iterator begin() const { return getTrailingObjects<Attribute>(); }
|
|
|
|
iterator end() const { return begin() + NumAttrs; }
|
|
|
|
|
|
|
|
void Profile(FoldingSetNodeID &ID) const {
|
|
|
|
Profile(ID, makeArrayRef(begin(), end()));
|
|
|
|
}
|
2017-05-15 23:57:41 +02:00
|
|
|
|
2017-04-12 02:38:00 +02:00
|
|
|
static void Profile(FoldingSetNodeID &ID, ArrayRef<Attribute> AttrList) {
|
|
|
|
for (const auto &Attr : AttrList)
|
|
|
|
Attr.Profile(ID);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2017-05-15 23:57:41 +02:00
|
|
|
using IndexAttrPair = std::pair<unsigned, AttributeSet>;
|
2015-08-06 11:49:17 +02:00
|
|
|
|
2013-01-24 01:06:56 +01:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// \class
|
2018-05-01 17:54:18 +02:00
|
|
|
/// This class represents a set of attributes that apply to the function,
|
2013-01-24 01:06:56 +01:00
|
|
|
/// return type, and parameters.
|
Rename AttributeSet to AttributeList
Summary:
This class is a list of AttributeSetNodes corresponding the function
prototype of a call or function declaration. This class used to be
called ParamAttrListPtr, then AttrListPtr, then AttributeSet. It is
typically accessed by parameter and return value index, so
"AttributeList" seems like a more intuitive name.
Rename AttributeSetImpl to AttributeListImpl to follow suit.
It's useful to rename this class so that we can rename AttributeSetNode
to AttributeSet later. AttributeSet is the set of attributes that apply
to a single function, argument, or return value.
Reviewers: sanjoy, javed.absar, chandlerc, pete
Reviewed By: pete
Subscribers: pete, jholewinski, arsenm, dschuff, mehdi_amini, jfb, nhaehnle, sbc100, void, llvm-commits
Differential Revision: https://reviews.llvm.org/D31102
llvm-svn: 298393
2017-03-21 17:57:19 +01:00
|
|
|
class AttributeListImpl final
|
2015-08-06 00:57:34 +02:00
|
|
|
: public FoldingSetNode,
|
[IR] Switch AttributeList to use an array for O(1) access
Summary:
Before this change, AttributeLists stored a pair of index and
AttributeSet. This is memory efficient if most arguments do not have
attributes. However, it requires doing a search over the pairs to test
an argument or function attribute. Profiling shows that this loop was
0.76% of the time in 'opt -O2' of sqlite3.c, because LLVM constantly
tests values for nullability.
This was worth about 2.5% of mid-level optimization cycles on the
sqlite3 amalgamation. Here are the full perf results:
https://reviews.llvm.org/P7995
Here are just the before and after cycle counts:
```
$ perf stat -r 5 ./opt_before -O2 sqlite3.bc -o /dev/null
13,274,181,184 cycles # 3.047 GHz ( +- 0.28% )
$ perf stat -r 5 ./opt_after -O2 sqlite3.bc -o /dev/null
12,906,927,263 cycles # 3.043 GHz ( +- 0.51% )
```
This patch *does not* change the indices used to query attributes, as
requested by reviewers. Tracking whether an index is usable for array
indexing is a huge pain that affects many of the internal APIs, so it
would be good to come back later and do a cleanup to remove this
internal adjustment.
Reviewers: pete, chandlerc
Subscribers: javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D32819
llvm-svn: 303654
2017-05-23 19:01:48 +02:00
|
|
|
private TrailingObjects<AttributeListImpl, AttributeSet> {
|
Rename AttributeSet to AttributeList
Summary:
This class is a list of AttributeSetNodes corresponding the function
prototype of a call or function declaration. This class used to be
called ParamAttrListPtr, then AttrListPtr, then AttributeSet. It is
typically accessed by parameter and return value index, so
"AttributeList" seems like a more intuitive name.
Rename AttributeSetImpl to AttributeListImpl to follow suit.
It's useful to rename this class so that we can rename AttributeSetNode
to AttributeSet later. AttributeSet is the set of attributes that apply
to a single function, argument, or return value.
Reviewers: sanjoy, javed.absar, chandlerc, pete
Reviewed By: pete
Subscribers: pete, jholewinski, arsenm, dschuff, mehdi_amini, jfb, nhaehnle, sbc100, void, llvm-commits
Differential Revision: https://reviews.llvm.org/D31102
llvm-svn: 298393
2017-03-21 17:57:19 +01:00
|
|
|
friend class AttributeList;
|
2015-08-06 00:57:34 +02:00
|
|
|
friend TrailingObjects;
|
2015-06-17 03:21:20 +02:00
|
|
|
|
|
|
|
private:
|
[IR] Switch AttributeList to use an array for O(1) access
Summary:
Before this change, AttributeLists stored a pair of index and
AttributeSet. This is memory efficient if most arguments do not have
attributes. However, it requires doing a search over the pairs to test
an argument or function attribute. Profiling shows that this loop was
0.76% of the time in 'opt -O2' of sqlite3.c, because LLVM constantly
tests values for nullability.
This was worth about 2.5% of mid-level optimization cycles on the
sqlite3 amalgamation. Here are the full perf results:
https://reviews.llvm.org/P7995
Here are just the before and after cycle counts:
```
$ perf stat -r 5 ./opt_before -O2 sqlite3.bc -o /dev/null
13,274,181,184 cycles # 3.047 GHz ( +- 0.28% )
$ perf stat -r 5 ./opt_after -O2 sqlite3.bc -o /dev/null
12,906,927,263 cycles # 3.043 GHz ( +- 0.51% )
```
This patch *does not* change the indices used to query attributes, as
requested by reviewers. Tracking whether an index is usable for array
indexing is a huge pain that affects many of the internal APIs, so it
would be good to come back later and do a cleanup to remove this
internal adjustment.
Reviewers: pete, chandlerc
Subscribers: javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D32819
llvm-svn: 303654
2017-05-23 19:01:48 +02:00
|
|
|
LLVMContext &Context;
|
|
|
|
unsigned NumAttrSets; ///< Number of entries in this set.
|
2019-07-13 02:29:03 +02:00
|
|
|
/// Bitset with a bit for each available attribute Attribute::AttrKind.
|
|
|
|
uint8_t AvailableFunctionAttrs[12] = {};
|
2013-07-11 14:13:16 +02:00
|
|
|
|
2015-08-06 00:57:34 +02:00
|
|
|
// Helper fn for TrailingObjects class.
|
[IR] Switch AttributeList to use an array for O(1) access
Summary:
Before this change, AttributeLists stored a pair of index and
AttributeSet. This is memory efficient if most arguments do not have
attributes. However, it requires doing a search over the pairs to test
an argument or function attribute. Profiling shows that this loop was
0.76% of the time in 'opt -O2' of sqlite3.c, because LLVM constantly
tests values for nullability.
This was worth about 2.5% of mid-level optimization cycles on the
sqlite3 amalgamation. Here are the full perf results:
https://reviews.llvm.org/P7995
Here are just the before and after cycle counts:
```
$ perf stat -r 5 ./opt_before -O2 sqlite3.bc -o /dev/null
13,274,181,184 cycles # 3.047 GHz ( +- 0.28% )
$ perf stat -r 5 ./opt_after -O2 sqlite3.bc -o /dev/null
12,906,927,263 cycles # 3.043 GHz ( +- 0.51% )
```
This patch *does not* change the indices used to query attributes, as
requested by reviewers. Tracking whether an index is usable for array
indexing is a huge pain that affects many of the internal APIs, so it
would be good to come back later and do a cleanup to remove this
internal adjustment.
Reviewers: pete, chandlerc
Subscribers: javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D32819
llvm-svn: 303654
2017-05-23 19:01:48 +02:00
|
|
|
size_t numTrailingObjects(OverloadToken<AttributeSet>) { return NumAttrSets; }
|
2013-01-24 02:01:34 +01:00
|
|
|
|
2012-11-20 06:09:20 +01:00
|
|
|
public:
|
[IR] Switch AttributeList to use an array for O(1) access
Summary:
Before this change, AttributeLists stored a pair of index and
AttributeSet. This is memory efficient if most arguments do not have
attributes. However, it requires doing a search over the pairs to test
an argument or function attribute. Profiling shows that this loop was
0.76% of the time in 'opt -O2' of sqlite3.c, because LLVM constantly
tests values for nullability.
This was worth about 2.5% of mid-level optimization cycles on the
sqlite3 amalgamation. Here are the full perf results:
https://reviews.llvm.org/P7995
Here are just the before and after cycle counts:
```
$ perf stat -r 5 ./opt_before -O2 sqlite3.bc -o /dev/null
13,274,181,184 cycles # 3.047 GHz ( +- 0.28% )
$ perf stat -r 5 ./opt_after -O2 sqlite3.bc -o /dev/null
12,906,927,263 cycles # 3.043 GHz ( +- 0.51% )
```
This patch *does not* change the indices used to query attributes, as
requested by reviewers. Tracking whether an index is usable for array
indexing is a huge pain that affects many of the internal APIs, so it
would be good to come back later and do a cleanup to remove this
internal adjustment.
Reviewers: pete, chandlerc
Subscribers: javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D32819
llvm-svn: 303654
2017-05-23 19:01:48 +02:00
|
|
|
AttributeListImpl(LLVMContext &C, ArrayRef<AttributeSet> Sets);
|
2013-01-04 21:54:35 +01:00
|
|
|
|
2016-12-07 23:06:02 +01:00
|
|
|
// AttributesSetImpt is uniqued, these should not be available.
|
Rename AttributeSet to AttributeList
Summary:
This class is a list of AttributeSetNodes corresponding the function
prototype of a call or function declaration. This class used to be
called ParamAttrListPtr, then AttrListPtr, then AttributeSet. It is
typically accessed by parameter and return value index, so
"AttributeList" seems like a more intuitive name.
Rename AttributeSetImpl to AttributeListImpl to follow suit.
It's useful to rename this class so that we can rename AttributeSetNode
to AttributeSet later. AttributeSet is the set of attributes that apply
to a single function, argument, or return value.
Reviewers: sanjoy, javed.absar, chandlerc, pete
Reviewed By: pete
Subscribers: pete, jholewinski, arsenm, dschuff, mehdi_amini, jfb, nhaehnle, sbc100, void, llvm-commits
Differential Revision: https://reviews.llvm.org/D31102
llvm-svn: 298393
2017-03-21 17:57:19 +01:00
|
|
|
AttributeListImpl(const AttributeListImpl &) = delete;
|
|
|
|
AttributeListImpl &operator=(const AttributeListImpl &) = delete;
|
2016-12-07 23:06:02 +01:00
|
|
|
|
2016-02-09 03:09:16 +01:00
|
|
|
void operator delete(void *p) { ::operator delete(p); }
|
2016-02-09 02:03:42 +01:00
|
|
|
|
2018-05-01 17:54:18 +02:00
|
|
|
/// Get the context that created this AttributeListImpl.
|
2013-01-04 21:54:35 +01:00
|
|
|
LLVMContext &getContext() { return Context; }
|
2013-01-27 22:32:11 +01:00
|
|
|
|
2018-05-01 17:54:18 +02:00
|
|
|
/// Return true if the AttributeSet or the FunctionIndex has an
|
2016-01-29 23:25:19 +01:00
|
|
|
/// enum attribute of the given kind.
|
|
|
|
bool hasFnAttribute(Attribute::AttrKind Kind) const {
|
2019-07-13 02:29:03 +02:00
|
|
|
return AvailableFunctionAttrs[Kind / 8] & ((uint64_t)1) << (Kind % 8);
|
2016-01-29 23:25:19 +01:00
|
|
|
}
|
|
|
|
|
2017-06-20 00:05:08 +02:00
|
|
|
using iterator = const AttributeSet *;
|
|
|
|
|
[IR] Switch AttributeList to use an array for O(1) access
Summary:
Before this change, AttributeLists stored a pair of index and
AttributeSet. This is memory efficient if most arguments do not have
attributes. However, it requires doing a search over the pairs to test
an argument or function attribute. Profiling shows that this loop was
0.76% of the time in 'opt -O2' of sqlite3.c, because LLVM constantly
tests values for nullability.
This was worth about 2.5% of mid-level optimization cycles on the
sqlite3 amalgamation. Here are the full perf results:
https://reviews.llvm.org/P7995
Here are just the before and after cycle counts:
```
$ perf stat -r 5 ./opt_before -O2 sqlite3.bc -o /dev/null
13,274,181,184 cycles # 3.047 GHz ( +- 0.28% )
$ perf stat -r 5 ./opt_after -O2 sqlite3.bc -o /dev/null
12,906,927,263 cycles # 3.043 GHz ( +- 0.51% )
```
This patch *does not* change the indices used to query attributes, as
requested by reviewers. Tracking whether an index is usable for array
indexing is a huge pain that affects many of the internal APIs, so it
would be good to come back later and do a cleanup to remove this
internal adjustment.
Reviewers: pete, chandlerc
Subscribers: javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D32819
llvm-svn: 303654
2017-05-23 19:01:48 +02:00
|
|
|
iterator begin() const { return getTrailingObjects<AttributeSet>(); }
|
|
|
|
iterator end() const { return begin() + NumAttrSets; }
|
2013-01-28 01:21:34 +01:00
|
|
|
|
2017-04-11 02:16:00 +02:00
|
|
|
void Profile(FoldingSetNodeID &ID) const;
|
[IR] Switch AttributeList to use an array for O(1) access
Summary:
Before this change, AttributeLists stored a pair of index and
AttributeSet. This is memory efficient if most arguments do not have
attributes. However, it requires doing a search over the pairs to test
an argument or function attribute. Profiling shows that this loop was
0.76% of the time in 'opt -O2' of sqlite3.c, because LLVM constantly
tests values for nullability.
This was worth about 2.5% of mid-level optimization cycles on the
sqlite3 amalgamation. Here are the full perf results:
https://reviews.llvm.org/P7995
Here are just the before and after cycle counts:
```
$ perf stat -r 5 ./opt_before -O2 sqlite3.bc -o /dev/null
13,274,181,184 cycles # 3.047 GHz ( +- 0.28% )
$ perf stat -r 5 ./opt_after -O2 sqlite3.bc -o /dev/null
12,906,927,263 cycles # 3.043 GHz ( +- 0.51% )
```
This patch *does not* change the indices used to query attributes, as
requested by reviewers. Tracking whether an index is usable for array
indexing is a huge pain that affects many of the internal APIs, so it
would be good to come back later and do a cleanup to remove this
internal adjustment.
Reviewers: pete, chandlerc
Subscribers: javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D32819
llvm-svn: 303654
2017-05-23 19:01:48 +02:00
|
|
|
static void Profile(FoldingSetNodeID &ID, ArrayRef<AttributeSet> Nodes);
|
2013-01-28 00:41:29 +01:00
|
|
|
|
2013-08-03 00:34:30 +02:00
|
|
|
void dump() const;
|
2012-11-20 06:09:20 +01:00
|
|
|
};
|
|
|
|
|
2016-12-07 23:06:02 +01:00
|
|
|
} // end namespace llvm
|
2012-09-26 23:07:29 +02:00
|
|
|
|
2016-12-07 23:06:02 +01:00
|
|
|
#endif // LLVM_LIB_IR_ATTRIBUTEIMPL_H
|