RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 10:42:39 +01:00
Code Issues Projects Releases Wiki Activity
3fc69c930e
llvm-mirror/unittests/Analysis/ProfileSummaryInfoTest.cpp

378 lines
15 KiB
C++
Raw Normal View History

ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
//===- ProfileSummaryInfoTest.cpp - ProfileSummaryInfo unit tests ---------===//
//
Update the file headers across all of the LLVM projects in the monorepo to reflect the new license. We understand that people may be surprised that we're moving the header entirely to discuss the new license. We checked this carefully with the Foundation's lawyer and we believe this is the correct approach. Essentially, all code in the project is now made available by the LLVM project under our new license, so you will see that the license headers include that license only. Some of our contributors have contributed code under our old license, and accordingly, we have retained a copy of our old license notice in the top-level files in each project and repository. llvm-svn: 351636
2019-01-19 09:50:56 +01:00
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
//
//===----------------------------------------------------------------------===//
Re-sort #include lines for unittests. This uses a slightly modified clang-format (https://reviews.llvm.org/D33932) to keep primary headers at the top and handle new utility headers like 'gmock' consistently with other utility headers. No other change was made. I did no manual edits, all of this is clang-format. This should allow other changes to have more clear and focused diffs, and is especially motivated by moving some headers into more focused libraries. llvm-svn: 304786
2017-06-06 13:06:56 +02:00
#include "llvm/Analysis/ProfileSummaryInfo.h"
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
#include "llvm/Analysis/BlockFrequencyInfo.h"
#include "llvm/Analysis/BranchProbabilityInfo.h"
#include "llvm/Analysis/LoopInfo.h"
#include "llvm/AsmParser/Parser.h"
#include "llvm/IR/BasicBlock.h"
#include "llvm/IR/Dominators.h"
#include "llvm/IR/Function.h"
#include "llvm/IR/LLVMContext.h"
#include "llvm/IR/MDBuilder.h"
#include "llvm/IR/Module.h"
#include "llvm/Support/DataTypes.h"
#include "llvm/Support/FormatVariadic.h"
#include "llvm/Support/SourceMgr.h"
#include "llvm/Support/raw_ostream.h"
#include "gtest/gtest.h"
namespace llvm {
namespace {
class ProfileSummaryInfoTest : public testing::Test {
protected:
LLVMContext C;
std::unique_ptr<BranchProbabilityInfo> BPI;
std::unique_ptr<DominatorTree> DT;
std::unique_ptr<LoopInfo> LI;
ProfileSummaryInfo buildPSI(Module *M) {
return ProfileSummaryInfo(*M);
}
BlockFrequencyInfo buildBFI(Function &F) {
DT.reset(new DominatorTree(F));
LI.reset(new LoopInfo(*DT));
BPI.reset(new BranchProbabilityInfo(F, *LI));
return BlockFrequencyInfo(F, *BPI, *LI);
}
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
std::unique_ptr<Module> makeLLVMModule(const char *ProfKind = nullptr) {
const char *ModuleString =
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
"define i32 @g(i32 %x) !prof !21 {{\n"
" ret i32 0\n"
"}\n"
"define i32 @h(i32 %x) !prof !22 {{\n"
" ret i32 0\n"
"}\n"
"define i32 @f(i32 %x) !prof !20 {{\n"
"bb0:\n"
" %y1 = icmp eq i32 %x, 0 \n"
" br i1 %y1, label %bb1, label %bb2, !prof !23 \n"
"bb1:\n"
" %z1 = call i32 @g(i32 %x)\n"
" br label %bb3\n"
"bb2:\n"
" %z2 = call i32 @h(i32 %x)\n"
" br label %bb3\n"
"bb3:\n"
" %y2 = phi i32 [0, %bb1], [1, %bb2] \n"
" ret i32 %y2\n"
"}\n"
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
"define i32 @l(i32 %x) {{\n"
"bb0:\n"
" %y1 = icmp eq i32 %x, 0 \n"
" br i1 %y1, label %bb1, label %bb2, !prof !23 \n"
"bb1:\n"
" %z1 = call i32 @g(i32 %x)\n"
" br label %bb3\n"
"bb2:\n"
" %z2 = call i32 @h(i32 %x)\n"
" br label %bb3\n"
"bb3:\n"
" %y2 = phi i32 [0, %bb1], [1, %bb2] \n"
" ret i32 %y2\n"
"}\n"
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
"!20 = !{{!\"function_entry_count\", i64 400}\n"
"!21 = !{{!\"function_entry_count\", i64 1}\n"
"!22 = !{{!\"function_entry_count\", i64 100}\n"
"!23 = !{{!\"branch_weights\", i32 64, i32 4}\n"
"{0}";
const char *SummaryString = "!llvm.module.flags = !{{!1}"
"!1 = !{{i32 1, !\"ProfileSummary\", !2}"
"!2 = !{{!3, !4, !5, !6, !7, !8, !9, !10}"
"!3 = !{{!\"ProfileFormat\", !\"{0}\"}"
"!4 = !{{!\"TotalCount\", i64 10000}"
"!5 = !{{!\"MaxCount\", i64 10}"
"!6 = !{{!\"MaxInternalCount\", i64 1}"
"!7 = !{{!\"MaxFunctionCount\", i64 1000}"
"!8 = !{{!\"NumCounts\", i64 3}"
"!9 = !{{!\"NumFunctions\", i64 3}"
"!10 = !{{!\"DetailedSummary\", !11}"
"!11 = !{{!12, !13, !14}"
"!12 = !{{i32 10000, i64 1000, i32 1}"
"!13 = !{{i32 999000, i64 300, i32 3}"
"!14 = !{{i32 999999, i64 5, i32 10}";
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
SMDiagnostic Err;
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
if (ProfKind)
return parseAssemblyString(
formatv(ModuleString, formatv(SummaryString, ProfKind).str()).str(),
Err, C);
else
return parseAssemblyString(formatv(ModuleString, "").str(), Err, C);
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
}
};
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
TEST_F(ProfileSummaryInfoTest, TestNoProfile) {
auto M = makeLLVMModule(/*ProfKind=*/nullptr);
Function *F = M->getFunction("f");
ProfileSummaryInfo PSI = buildPSI(M.get());
Add hasProfileSummary and has{Sample|Instrumentation}Profile methods ProfileSummaryInfo already checks whether the module has sample profile in determining profile counts. This will also be useful in inliner to clean up threshold updates. llvm-svn: 303204
2017-05-16 22:14:39 +02:00
EXPECT_FALSE(PSI.hasProfileSummary());
EXPECT_FALSE(PSI.hasSampleProfile());
EXPECT_FALSE(PSI.hasInstrumentationProfile());
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
// In the absence of profiles, is{Hot|Cold}X methods should always return
// false.
EXPECT_FALSE(PSI.isHotCount(1000));
EXPECT_FALSE(PSI.isHotCount(0));
EXPECT_FALSE(PSI.isColdCount(1000));
EXPECT_FALSE(PSI.isColdCount(0));
EXPECT_FALSE(PSI.isFunctionEntryHot(F));
EXPECT_FALSE(PSI.isFunctionEntryCold(F));
BasicBlock &BB0 = F->getEntryBlock();
BasicBlock *BB1 = BB0.getTerminator()->getSuccessor(0);
BlockFrequencyInfo BFI = buildBFI(*F);
[ProfileSummary] Standardize methods and fix comment Every Analysis pass has a get method that returns a reference of the Result of the Analysis, for example, BlockFrequencyInfo &BlockFrequencyInfoWrapperPass::getBFI(). I believe that ProfileSummaryInfo::getPSI() is the only exception to that, as it was returning a pointer. Another change is renaming isHotBB and isColdBB to isHotBlock and isColdBlock, respectively. Most methods use BB as the argument of variable names while methods usually refer to Basic Blocks as Blocks, instead of BB. For example, Function::getEntryBlock, Loop:getExitBlock, etc. I also fixed one of the comments. Patch by Rodrigo Caetano Rocha! Differential Revision: https://reviews.llvm.org/D54669 llvm-svn: 347182
2018-11-19 06:23:16 +01:00
EXPECT_FALSE(PSI.isHotBlock(&BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlock(&BB0, &BFI));
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
[llvm][NFC] Dereferencing before cast-ing in ProfileSummaryInfoTest Incorporated feedback from https://reviews.llvm.org/D78414
2020-04-19 02:47:37 +02:00
CallBase &CS1 = cast<CallBase>(*BB1->getFirstNonPHI());
Compute summary before calling extractProfTotalWeight extractProfTotalWeight checks if the profile type is sample profile, but before that we have to ensure that summary is available. Also expanded the unittest to test the case where there is no summar Differential Revision: https://reviews.llvm.org/D28708 llvm-svn: 291982
2017-01-14 01:32:37 +01:00
EXPECT_FALSE(PSI.isHotCallSite(CS1, &BFI));
EXPECT_FALSE(PSI.isColdCallSite(CS1, &BFI));
}
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
TEST_F(ProfileSummaryInfoTest, TestCommon) {
auto M = makeLLVMModule("InstrProf");
Function *F = M->getFunction("f");
Function *G = M->getFunction("g");
Function *H = M->getFunction("h");
ProfileSummaryInfo PSI = buildPSI(M.get());
Add hasProfileSummary and has{Sample|Instrumentation}Profile methods ProfileSummaryInfo already checks whether the module has sample profile in determining profile counts. This will also be useful in inliner to clean up threshold updates. llvm-svn: 303204
2017-05-16 22:14:39 +02:00
EXPECT_TRUE(PSI.hasProfileSummary());
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
EXPECT_TRUE(PSI.isHotCount(400));
EXPECT_TRUE(PSI.isColdCount(2));
EXPECT_FALSE(PSI.isColdCount(100));
EXPECT_FALSE(PSI.isHotCount(100));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_TRUE(PSI.isHotCountNthPercentile(990000, 400));
EXPECT_FALSE(PSI.isHotCountNthPercentile(990000, 100));
EXPECT_FALSE(PSI.isHotCountNthPercentile(990000, 2));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_FALSE(PSI.isColdCountNthPercentile(990000, 400));
EXPECT_TRUE(PSI.isColdCountNthPercentile(990000, 100));
EXPECT_TRUE(PSI.isColdCountNthPercentile(990000, 2));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_TRUE(PSI.isHotCountNthPercentile(999999, 400));
EXPECT_TRUE(PSI.isHotCountNthPercentile(999999, 100));
EXPECT_FALSE(PSI.isHotCountNthPercentile(999999, 2));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_FALSE(PSI.isColdCountNthPercentile(999999, 400));
EXPECT_FALSE(PSI.isColdCountNthPercentile(999999, 100));
EXPECT_TRUE(PSI.isColdCountNthPercentile(999999, 2));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_FALSE(PSI.isHotCountNthPercentile(10000, 400));
EXPECT_FALSE(PSI.isHotCountNthPercentile(10000, 100));
EXPECT_FALSE(PSI.isHotCountNthPercentile(10000, 2));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_TRUE(PSI.isColdCountNthPercentile(10000, 400));
EXPECT_TRUE(PSI.isColdCountNthPercentile(10000, 100));
EXPECT_TRUE(PSI.isColdCountNthPercentile(10000, 2));
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
EXPECT_TRUE(PSI.isFunctionEntryHot(F));
EXPECT_FALSE(PSI.isFunctionEntryHot(G));
EXPECT_FALSE(PSI.isFunctionEntryHot(H));
}
TEST_F(ProfileSummaryInfoTest, InstrProf) {
auto M = makeLLVMModule("InstrProf");
Function *F = M->getFunction("f");
ProfileSummaryInfo PSI = buildPSI(M.get());
Add hasProfileSummary and has{Sample|Instrumentation}Profile methods ProfileSummaryInfo already checks whether the module has sample profile in determining profile counts. This will also be useful in inliner to clean up threshold updates. llvm-svn: 303204
2017-05-16 22:14:39 +02:00
EXPECT_TRUE(PSI.hasProfileSummary());
EXPECT_TRUE(PSI.hasInstrumentationProfile());
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
BasicBlock &BB0 = F->getEntryBlock();
BasicBlock *BB1 = BB0.getTerminator()->getSuccessor(0);
BasicBlock *BB2 = BB0.getTerminator()->getSuccessor(1);
BasicBlock *BB3 = BB1->getSingleSuccessor();
BlockFrequencyInfo BFI = buildBFI(*F);
[ProfileSummary] Standardize methods and fix comment Every Analysis pass has a get method that returns a reference of the Result of the Analysis, for example, BlockFrequencyInfo &BlockFrequencyInfoWrapperPass::getBFI(). I believe that ProfileSummaryInfo::getPSI() is the only exception to that, as it was returning a pointer. Another change is renaming isHotBB and isColdBB to isHotBlock and isColdBlock, respectively. Most methods use BB as the argument of variable names while methods usually refer to Basic Blocks as Blocks, instead of BB. For example, Function::getEntryBlock, Loop:getExitBlock, etc. I also fixed one of the comments. Patch by Rodrigo Caetano Rocha! Differential Revision: https://reviews.llvm.org/D54669 llvm-svn: 347182
2018-11-19 06:23:16 +01:00
EXPECT_TRUE(PSI.isHotBlock(&BB0, &BFI));
EXPECT_TRUE(PSI.isHotBlock(BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlock(BB2, &BFI));
EXPECT_TRUE(PSI.isHotBlock(BB3, &BFI));
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_TRUE(PSI.isHotBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(990000, BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB2, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(990000, BB3, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB1, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(990000, BB2, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB3, &BFI));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, &BB0, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, BB1, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, BB2, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, BB3, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, &BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, BB1, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, BB2, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, BB3, &BFI));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, &BB0, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, BB2, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, BB3, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, &BB0, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, BB1, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, BB2, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, BB3, &BFI));
[llvm][NFC] Dereferencing before cast-ing in ProfileSummaryInfoTest Incorporated feedback from https://reviews.llvm.org/D78414
2020-04-19 02:47:37 +02:00
CallBase &CS1 = cast<CallBase>(*BB1->getFirstNonPHI());
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
auto *CI2 = BB2->getFirstNonPHI();
[llvm][NFC] Dereferencing before cast-ing in ProfileSummaryInfoTest Incorporated feedback from https://reviews.llvm.org/D78414
2020-04-19 02:47:37 +02:00
CallBase &CS2 = cast<CallBase>(*CI2);
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
EXPECT_TRUE(PSI.isHotCallSite(CS1, &BFI));
EXPECT_FALSE(PSI.isHotCallSite(CS2, &BFI));
Restrict call metadata based hotness detection to Sample PGO mode Summary: Don't use the metadata on call instructions for determining hotness unless we are in sample PGO mode, where it is needed because profile counts are not accurate. In instrumentation mode this is not necessary and does more harm than good when calls have VP metadata that hasn't been properly scaled after transformations or dropped after constant prop based devirtualization (both should be fixed, but we don't need to do this in the first place for instrumentation PGO). This required adjusting a number of tests to distinguish between sample and instrumentation PGO handling, and to add in profile summary metadata so that getProfileCount can get the summary. Reviewers: davidxl, danielcdh Subscribers: aemerson, rengolin, mehdi_amini, Prazek, llvm-commits Differential Revision: https://reviews.llvm.org/D32877 llvm-svn: 302844
2017-05-12 01:18:05 +02:00
// Test that adding an MD_prof metadata with a hot count on CS2 does not
// change its hotness as it has no effect in instrumented profiling.
MDBuilder MDB(M->getContext());
CI2->setMetadata(llvm::LLVMContext::MD_prof, MDB.createBranchWeights({400}));
EXPECT_FALSE(PSI.isHotCallSite(CS2, &BFI));
[PSI] Add tests for is(Hot|Cold)FunctionInCallGraphNthPercentile. Summary: Follow up on D75283. Also remove the test code that was moved to another test and was to be removed. Reviewers: davidxl Subscribers: eraman, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75630
2020-03-04 19:33:23 +01:00
EXPECT_TRUE(PSI.isFunctionHotInCallGraphNthPercentile(990000, F, BFI));
EXPECT_FALSE(PSI.isFunctionColdInCallGraphNthPercentile(990000, F, BFI));
EXPECT_FALSE(PSI.isFunctionHotInCallGraphNthPercentile(10000, F, BFI));
EXPECT_TRUE(PSI.isFunctionColdInCallGraphNthPercentile(10000, F, BFI));
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
}
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
TEST_F(ProfileSummaryInfoTest, InstrProfNoFuncEntryCount) {
auto M = makeLLVMModule("InstrProf");
Function *F = M->getFunction("l");
ProfileSummaryInfo PSI = buildPSI(M.get());
EXPECT_TRUE(PSI.hasProfileSummary());
EXPECT_TRUE(PSI.hasInstrumentationProfile());
BasicBlock &BB0 = F->getEntryBlock();
BasicBlock *BB1 = BB0.getTerminator()->getSuccessor(0);
BasicBlock *BB2 = BB0.getTerminator()->getSuccessor(1);
BasicBlock *BB3 = BB1->getSingleSuccessor();
BlockFrequencyInfo BFI = buildBFI(*F);
// Without the entry count, all should return false.
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB2, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB3, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB1, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB2, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB3, &BFI));
[PSI] Add tests for is(Hot|Cold)FunctionInCallGraphNthPercentile. Summary: Follow up on D75283. Also remove the test code that was moved to another test and was to be removed. Reviewers: davidxl Subscribers: eraman, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75630
2020-03-04 19:33:23 +01:00
EXPECT_FALSE(PSI.isFunctionHotInCallGraphNthPercentile(990000, F, BFI));
EXPECT_FALSE(PSI.isFunctionColdInCallGraphNthPercentile(990000, F, BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
}
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
TEST_F(ProfileSummaryInfoTest, SampleProf) {
auto M = makeLLVMModule("SampleProfile");
Function *F = M->getFunction("f");
ProfileSummaryInfo PSI = buildPSI(M.get());
Add hasProfileSummary and has{Sample|Instrumentation}Profile methods ProfileSummaryInfo already checks whether the module has sample profile in determining profile counts. This will also be useful in inliner to clean up threshold updates. llvm-svn: 303204
2017-05-16 22:14:39 +02:00
EXPECT_TRUE(PSI.hasProfileSummary());
EXPECT_TRUE(PSI.hasSampleProfile());
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
BasicBlock &BB0 = F->getEntryBlock();
BasicBlock *BB1 = BB0.getTerminator()->getSuccessor(0);
BasicBlock *BB2 = BB0.getTerminator()->getSuccessor(1);
BasicBlock *BB3 = BB1->getSingleSuccessor();
BlockFrequencyInfo BFI = buildBFI(*F);
[ProfileSummary] Standardize methods and fix comment Every Analysis pass has a get method that returns a reference of the Result of the Analysis, for example, BlockFrequencyInfo &BlockFrequencyInfoWrapperPass::getBFI(). I believe that ProfileSummaryInfo::getPSI() is the only exception to that, as it was returning a pointer. Another change is renaming isHotBB and isColdBB to isHotBlock and isColdBlock, respectively. Most methods use BB as the argument of variable names while methods usually refer to Basic Blocks as Blocks, instead of BB. For example, Function::getEntryBlock, Loop:getExitBlock, etc. I also fixed one of the comments. Patch by Rodrigo Caetano Rocha! Differential Revision: https://reviews.llvm.org/D54669 llvm-svn: 347182
2018-11-19 06:23:16 +01:00
EXPECT_TRUE(PSI.isHotBlock(&BB0, &BFI));
EXPECT_TRUE(PSI.isHotBlock(BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlock(BB2, &BFI));
EXPECT_TRUE(PSI.isHotBlock(BB3, &BFI));
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_TRUE(PSI.isHotBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(990000, BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB2, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(990000, BB3, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB1, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(990000, BB2, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB3, &BFI));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, &BB0, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, BB1, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, BB2, &BFI));
EXPECT_TRUE(PSI.isHotBlockNthPercentile(999900, BB3, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, &BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, BB1, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, BB2, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(999900, BB3, &BFI));
[PGO][PGSO] ProfileSummary changes. (Split of off D67120) ProfileSummary changes for profile guided size optimization. Differential Revision: https://reviews.llvm.org/D67377 llvm-svn: 372783
2019-09-25 00:17:51 +02:00
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, &BB0, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, BB2, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(10000, BB3, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, &BB0, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, BB1, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, BB2, &BFI));
EXPECT_TRUE(PSI.isColdBlockNthPercentile(10000, BB3, &BFI));
[llvm][NFC] Dereferencing before cast-ing in ProfileSummaryInfoTest Incorporated feedback from https://reviews.llvm.org/D78414
2020-04-19 02:47:37 +02:00
CallBase &CS1 = cast<CallBase>(*BB1->getFirstNonPHI());
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
auto *CI2 = BB2->getFirstNonPHI();
Do not want to use BFI to get profile count for sample pgo Summary: For SamplePGO, we already record the callsite count in the call instruction itself. So we do not want to use BFI to get profile count as it is less accurate. Reviewers: tejohnson, davidxl, eraman Reviewed By: eraman Subscribers: sanjoy, llvm-commits, mehdi_amini Differential Revision: https://reviews.llvm.org/D36025 llvm-svn: 309964
2017-08-03 19:11:41 +02:00
// Manually attach branch weights metadata to the call instruction.
SmallVector<uint32_t, 1> Weights;
Weights.push_back(1000);
MDBuilder MDB(M->getContext());
CI2->setMetadata(LLVMContext::MD_prof, MDB.createBranchWeights(Weights));
[llvm][NFC] Dereferencing before cast-ing in ProfileSummaryInfoTest Incorporated feedback from https://reviews.llvm.org/D78414
2020-04-19 02:47:37 +02:00
CallBase &CS2 = cast<CallBase>(*CI2);
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
Do not want to use BFI to get profile count for sample pgo Summary: For SamplePGO, we already record the callsite count in the call instruction itself. So we do not want to use BFI to get profile count as it is less accurate. Reviewers: tejohnson, davidxl, eraman Reviewed By: eraman Subscribers: sanjoy, llvm-commits, mehdi_amini Differential Revision: https://reviews.llvm.org/D36025 llvm-svn: 309964
2017-08-03 19:11:41 +02:00
EXPECT_FALSE(PSI.isHotCallSite(CS1, &BFI));
EXPECT_TRUE(PSI.isHotCallSite(CS2, &BFI));
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
// Test that CS2 is considered hot when it gets an MD_prof metadata with
// weights that exceed the hot count threshold.
CI2->setMetadata(llvm::LLVMContext::MD_prof, MDB.createBranchWeights({400}));
EXPECT_TRUE(PSI.isHotCallSite(CS2, &BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
[PSI] Add tests for is(Hot|Cold)FunctionInCallGraphNthPercentile. Summary: Follow up on D75283. Also remove the test code that was moved to another test and was to be removed. Reviewers: davidxl Subscribers: eraman, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75630
2020-03-04 19:33:23 +01:00
EXPECT_TRUE(PSI.isFunctionHotInCallGraphNthPercentile(990000, F, BFI));
EXPECT_FALSE(PSI.isFunctionColdInCallGraphNthPercentile(990000, F, BFI));
EXPECT_FALSE(PSI.isFunctionHotInCallGraphNthPercentile(10000, F, BFI));
EXPECT_TRUE(PSI.isFunctionColdInCallGraphNthPercentile(10000, F, BFI));
[PSI] Add the isCold query support with a given percentile value. Summary: This follows up D67377 that added the isHot side. Reviewers: davidxl Subscribers: eraman, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75283
2020-02-27 19:49:04 +01:00
}
TEST_F(ProfileSummaryInfoTest, SampleProfNoFuncEntryCount) {
auto M = makeLLVMModule("SampleProfile");
Function *F = M->getFunction("l");
ProfileSummaryInfo PSI = buildPSI(M.get());
EXPECT_TRUE(PSI.hasProfileSummary());
EXPECT_TRUE(PSI.hasSampleProfile());
BasicBlock &BB0 = F->getEntryBlock();
BasicBlock *BB1 = BB0.getTerminator()->getSuccessor(0);
BasicBlock *BB2 = BB0.getTerminator()->getSuccessor(1);
BasicBlock *BB3 = BB1->getSingleSuccessor();
BlockFrequencyInfo BFI = buildBFI(*F);
// Without the entry count, all should return false.
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB1, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB2, &BFI));
EXPECT_FALSE(PSI.isHotBlockNthPercentile(990000, BB3, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, &BB0, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB1, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB2, &BFI));
EXPECT_FALSE(PSI.isColdBlockNthPercentile(990000, BB3, &BFI));
[PSI] Add tests for is(Hot|Cold)FunctionInCallGraphNthPercentile. Summary: Follow up on D75283. Also remove the test code that was moved to another test and was to be removed. Reviewers: davidxl Subscribers: eraman, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75630
2020-03-04 19:33:23 +01:00
EXPECT_FALSE(PSI.isFunctionHotInCallGraphNthPercentile(990000, F, BFI));
EXPECT_FALSE(PSI.isFunctionColdInCallGraphNthPercentile(990000, F, BFI));
ProfileSummaryInfo improvements. * Add is{Hot|Cold}CallSite methods * Fix a bug in isHotBB where it was looking for MD_prof on a return instruction * Use MD_prof data only if sample profiling was used to collect profiles. * Add an unit test to ProfileSummaryInfo Differential Revision: https://reviews.llvm.org/D28584 llvm-svn: 291878
2017-01-13 02:34:00 +01:00
}
} // end anonymous namespace
} // end namespace llvm
Reference in New Issue Copy Permalink