2017-03-31 03:46:30 +02:00
|
|
|
//===-- RecordStreamer.cpp - Record asm defined and used symbols ----------===//
|
2014-07-03 20:59:23 +02:00
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2014-07-05 00:44:18 +02:00
|
|
|
#include "RecordStreamer.h"
|
2018-03-20 01:38:33 +01:00
|
|
|
#include "llvm/IR/Mangler.h"
|
|
|
|
#include "llvm/IR/Module.h"
|
2018-03-09 19:42:25 +01:00
|
|
|
#include "llvm/MC/MCContext.h"
|
2014-07-03 20:59:23 +02:00
|
|
|
#include "llvm/MC/MCSymbol.h"
|
2017-04-25 01:21:38 +02:00
|
|
|
|
2014-07-03 20:59:23 +02:00
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
void RecordStreamer::markDefined(const MCSymbol &Symbol) {
|
|
|
|
State &S = Symbols[Symbol.getName()];
|
|
|
|
switch (S) {
|
|
|
|
case DefinedGlobal:
|
|
|
|
case Global:
|
|
|
|
S = DefinedGlobal;
|
|
|
|
break;
|
|
|
|
case NeverSeen:
|
|
|
|
case Defined:
|
|
|
|
case Used:
|
|
|
|
S = Defined;
|
|
|
|
break;
|
2016-09-15 19:54:22 +02:00
|
|
|
case DefinedWeak:
|
2016-06-22 22:48:15 +02:00
|
|
|
break;
|
2016-09-15 19:54:22 +02:00
|
|
|
case UndefinedWeak:
|
|
|
|
S = DefinedWeak;
|
2014-07-03 20:59:23 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-06-22 22:48:15 +02:00
|
|
|
void RecordStreamer::markGlobal(const MCSymbol &Symbol,
|
|
|
|
MCSymbolAttr Attribute) {
|
2014-07-03 20:59:23 +02:00
|
|
|
State &S = Symbols[Symbol.getName()];
|
|
|
|
switch (S) {
|
|
|
|
case DefinedGlobal:
|
|
|
|
case Defined:
|
2016-09-15 19:54:22 +02:00
|
|
|
S = (Attribute == MCSA_Weak) ? DefinedWeak : DefinedGlobal;
|
2014-07-03 20:59:23 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
case NeverSeen:
|
|
|
|
case Global:
|
|
|
|
case Used:
|
2016-09-15 19:54:22 +02:00
|
|
|
S = (Attribute == MCSA_Weak) ? UndefinedWeak : Global;
|
2016-06-22 22:48:15 +02:00
|
|
|
break;
|
2016-09-15 19:54:22 +02:00
|
|
|
case UndefinedWeak:
|
|
|
|
case DefinedWeak:
|
2014-07-03 20:59:23 +02:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void RecordStreamer::markUsed(const MCSymbol &Symbol) {
|
|
|
|
State &S = Symbols[Symbol.getName()];
|
|
|
|
switch (S) {
|
|
|
|
case DefinedGlobal:
|
|
|
|
case Defined:
|
|
|
|
case Global:
|
2016-09-15 19:54:22 +02:00
|
|
|
case DefinedWeak:
|
|
|
|
case UndefinedWeak:
|
2014-07-03 20:59:23 +02:00
|
|
|
break;
|
|
|
|
|
|
|
|
case NeverSeen:
|
|
|
|
case Used:
|
|
|
|
S = Used;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void RecordStreamer::visitUsedSymbol(const MCSymbol &Sym) { markUsed(Sym); }
|
|
|
|
|
2018-03-20 01:38:33 +01:00
|
|
|
RecordStreamer::RecordStreamer(MCContext &Context, const Module &M)
|
|
|
|
: MCStreamer(Context), M(M) {}
|
2017-04-25 01:21:38 +02:00
|
|
|
|
2014-07-03 20:59:23 +02:00
|
|
|
RecordStreamer::const_iterator RecordStreamer::begin() {
|
|
|
|
return Symbols.begin();
|
|
|
|
}
|
|
|
|
|
|
|
|
RecordStreamer::const_iterator RecordStreamer::end() { return Symbols.end(); }
|
|
|
|
|
|
|
|
void RecordStreamer::EmitInstruction(const MCInst &Inst,
|
2017-04-14 09:44:23 +02:00
|
|
|
const MCSubtargetInfo &STI, bool) {
|
2014-07-03 20:59:23 +02:00
|
|
|
MCStreamer::EmitInstruction(Inst, STI);
|
|
|
|
}
|
|
|
|
|
2017-02-10 16:13:12 +01:00
|
|
|
void RecordStreamer::EmitLabel(MCSymbol *Symbol, SMLoc Loc) {
|
2014-07-03 20:59:23 +02:00
|
|
|
MCStreamer::EmitLabel(Symbol);
|
|
|
|
markDefined(*Symbol);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RecordStreamer::EmitAssignment(MCSymbol *Symbol, const MCExpr *Value) {
|
|
|
|
markDefined(*Symbol);
|
|
|
|
MCStreamer::EmitAssignment(Symbol, Value);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool RecordStreamer::EmitSymbolAttribute(MCSymbol *Symbol,
|
|
|
|
MCSymbolAttr Attribute) {
|
2016-06-17 20:20:14 +02:00
|
|
|
if (Attribute == MCSA_Global || Attribute == MCSA_Weak)
|
2016-06-22 22:48:15 +02:00
|
|
|
markGlobal(*Symbol, Attribute);
|
2016-08-03 05:51:42 +02:00
|
|
|
if (Attribute == MCSA_LazyReference)
|
|
|
|
markUsed(*Symbol);
|
2014-07-03 20:59:23 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-05-21 21:20:38 +02:00
|
|
|
void RecordStreamer::EmitZerofill(MCSection *Section, MCSymbol *Symbol,
|
2018-07-02 19:29:43 +02:00
|
|
|
uint64_t Size, unsigned ByteAlignment,
|
|
|
|
SMLoc Loc) {
|
2014-07-03 20:59:23 +02:00
|
|
|
markDefined(*Symbol);
|
|
|
|
}
|
|
|
|
|
|
|
|
void RecordStreamer::EmitCommonSymbol(MCSymbol *Symbol, uint64_t Size,
|
|
|
|
unsigned ByteAlignment) {
|
|
|
|
markDefined(*Symbol);
|
|
|
|
}
|
Perform symbol binding for .symver versioned symbols
Summary:
In a .symver assembler directive like:
.symver name, name2@@nodename
"name2@@nodename" should get the same symbol binding as "name".
While the ELF object writer is updating the symbol binding for .symver
aliases before emitting the object file, not doing so when the module
inline assembly is handled by the RecordStreamer is causing the wrong
behavior in *LTO mode.
E.g. when "name" is global, "name2@@nodename" must also be marked as
global. Otherwise, the symbol is skipped when iterating over the LTO
InputFile symbols (InputFile::Symbol::shouldSkip). So, for example,
when performing any *LTO via the gold-plugin, the versioned symbol
definition is not recorded by the plugin and passed back to the
linker. If the object was in an archive, and there were no other symbols
needed from that object, the object would not be included in the final
link and references to the versioned symbol are undefined.
The llvm-lto2 tests added will give an error about an unused symbol
resolution without the fix.
Reviewers: rafael, pcc
Reviewed By: pcc
Subscribers: mehdi_amini, llvm-commits
Differential Revision: https://reviews.llvm.org/D30485
llvm-svn: 297332
2017-03-09 01:19:49 +01:00
|
|
|
|
2018-03-20 01:38:33 +01:00
|
|
|
RecordStreamer::State RecordStreamer::getSymbolState(const MCSymbol *Sym) {
|
|
|
|
auto SI = Symbols.find(Sym->getName());
|
|
|
|
if (SI == Symbols.end())
|
|
|
|
return NeverSeen;
|
|
|
|
return SI->second;
|
|
|
|
}
|
|
|
|
|
2018-03-09 19:42:25 +01:00
|
|
|
void RecordStreamer::emitELFSymverDirective(StringRef AliasName,
|
Perform symbol binding for .symver versioned symbols
Summary:
In a .symver assembler directive like:
.symver name, name2@@nodename
"name2@@nodename" should get the same symbol binding as "name".
While the ELF object writer is updating the symbol binding for .symver
aliases before emitting the object file, not doing so when the module
inline assembly is handled by the RecordStreamer is causing the wrong
behavior in *LTO mode.
E.g. when "name" is global, "name2@@nodename" must also be marked as
global. Otherwise, the symbol is skipped when iterating over the LTO
InputFile symbols (InputFile::Symbol::shouldSkip). So, for example,
when performing any *LTO via the gold-plugin, the versioned symbol
definition is not recorded by the plugin and passed back to the
linker. If the object was in an archive, and there were no other symbols
needed from that object, the object would not be included in the final
link and references to the versioned symbol are undefined.
The llvm-lto2 tests added will give an error about an unused symbol
resolution without the fix.
Reviewers: rafael, pcc
Reviewed By: pcc
Subscribers: mehdi_amini, llvm-commits
Differential Revision: https://reviews.llvm.org/D30485
llvm-svn: 297332
2017-03-09 01:19:49 +01:00
|
|
|
const MCSymbol *Aliasee) {
|
2018-03-20 01:38:33 +01:00
|
|
|
SymverAliasMap[Aliasee].push_back(AliasName);
|
|
|
|
}
|
|
|
|
|
2018-04-20 03:36:48 +02:00
|
|
|
iterator_range<RecordStreamer::const_symver_iterator>
|
|
|
|
RecordStreamer::symverAliases() {
|
|
|
|
return {SymverAliasMap.begin(), SymverAliasMap.end()};
|
|
|
|
}
|
|
|
|
|
2018-03-20 01:38:33 +01:00
|
|
|
void RecordStreamer::flushSymverDirectives() {
|
|
|
|
// Mapping from mangled name to GV.
|
|
|
|
StringMap<const GlobalValue *> MangledNameMap;
|
|
|
|
// The name in the assembler will be mangled, but the name in the IR
|
|
|
|
// might not, so we first compute a mapping from mangled name to GV.
|
|
|
|
Mangler Mang;
|
|
|
|
SmallString<64> MangledName;
|
|
|
|
for (const GlobalValue &GV : M.global_values()) {
|
|
|
|
if (!GV.hasName())
|
|
|
|
continue;
|
|
|
|
MangledName.clear();
|
|
|
|
MangledName.reserve(GV.getName().size() + 1);
|
|
|
|
Mang.getNameWithPrefix(MangledName, &GV, /*CannotUsePrivateLabel=*/false);
|
|
|
|
MangledNameMap[MangledName] = &GV;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Walk all the recorded .symver aliases, and set up the binding
|
|
|
|
// for each alias.
|
|
|
|
for (auto &Symver : SymverAliasMap) {
|
|
|
|
const MCSymbol *Aliasee = Symver.first;
|
|
|
|
MCSymbolAttr Attr = MCSA_Invalid;
|
2018-03-20 01:45:03 +01:00
|
|
|
bool IsDefined = false;
|
2018-03-20 01:38:33 +01:00
|
|
|
|
|
|
|
// First check if the aliasee binding was recorded in the asm.
|
|
|
|
RecordStreamer::State state = getSymbolState(Aliasee);
|
|
|
|
switch (state) {
|
|
|
|
case RecordStreamer::Global:
|
|
|
|
case RecordStreamer::DefinedGlobal:
|
|
|
|
Attr = MCSA_Global;
|
|
|
|
break;
|
|
|
|
case RecordStreamer::UndefinedWeak:
|
|
|
|
case RecordStreamer::DefinedWeak:
|
|
|
|
Attr = MCSA_Weak;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2018-03-20 01:45:03 +01:00
|
|
|
switch (state) {
|
|
|
|
case RecordStreamer::Defined:
|
|
|
|
case RecordStreamer::DefinedGlobal:
|
|
|
|
case RecordStreamer::DefinedWeak:
|
|
|
|
IsDefined = true;
|
|
|
|
break;
|
|
|
|
case RecordStreamer::NeverSeen:
|
|
|
|
case RecordStreamer::Global:
|
|
|
|
case RecordStreamer::Used:
|
|
|
|
case RecordStreamer::UndefinedWeak:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (Attr == MCSA_Invalid || !IsDefined) {
|
|
|
|
const GlobalValue *GV = M.getNamedValue(Aliasee->getName());
|
2018-03-20 01:38:33 +01:00
|
|
|
if (!GV) {
|
|
|
|
auto MI = MangledNameMap.find(Aliasee->getName());
|
|
|
|
if (MI != MangledNameMap.end())
|
|
|
|
GV = MI->second;
|
|
|
|
}
|
|
|
|
if (GV) {
|
2018-03-20 01:45:03 +01:00
|
|
|
// If we don't have a symbol attribute from assembly, then check if
|
|
|
|
// the aliasee was defined in the IR.
|
|
|
|
if (Attr == MCSA_Invalid) {
|
|
|
|
if (GV->hasExternalLinkage())
|
|
|
|
Attr = MCSA_Global;
|
|
|
|
else if (GV->hasLocalLinkage())
|
|
|
|
Attr = MCSA_Local;
|
|
|
|
else if (GV->isWeakForLinker())
|
|
|
|
Attr = MCSA_Weak;
|
|
|
|
}
|
|
|
|
IsDefined = IsDefined || !GV->isDeclarationForLinker();
|
2018-03-20 01:38:33 +01:00
|
|
|
}
|
|
|
|
}
|
2018-03-20 01:45:03 +01:00
|
|
|
|
2018-03-20 01:38:33 +01:00
|
|
|
// Set the detected binding on each alias with this aliasee.
|
|
|
|
for (auto AliasName : Symver.second) {
|
2018-03-20 01:45:03 +01:00
|
|
|
std::pair<StringRef, StringRef> Split = AliasName.split("@@@");
|
|
|
|
SmallString<128> NewName;
|
|
|
|
if (!Split.second.empty() && !Split.second.startswith("@")) {
|
|
|
|
// Special processing for "@@@" according
|
|
|
|
// https://sourceware.org/binutils/docs/as/Symver.html
|
|
|
|
const char *Separator = IsDefined ? "@@" : "@";
|
|
|
|
AliasName =
|
|
|
|
(Split.first + Separator + Split.second).toStringRef(NewName);
|
|
|
|
}
|
2018-03-20 01:38:33 +01:00
|
|
|
MCSymbol *Alias = getContext().getOrCreateSymbol(AliasName);
|
|
|
|
// TODO: Handle "@@@". Depending on SymbolAttribute value it needs to be
|
|
|
|
// converted into @ or @@.
|
|
|
|
const MCExpr *Value = MCSymbolRefExpr::create(Aliasee, getContext());
|
2018-04-10 02:53:16 +02:00
|
|
|
if (IsDefined)
|
|
|
|
markDefined(*Alias);
|
|
|
|
// Don't use EmitAssignment override as it always marks alias as defined.
|
|
|
|
MCStreamer::EmitAssignment(Alias, Value);
|
2018-03-20 01:38:33 +01:00
|
|
|
if (Attr != MCSA_Invalid)
|
|
|
|
EmitSymbolAttribute(Alias, Attr);
|
|
|
|
}
|
|
|
|
}
|
Perform symbol binding for .symver versioned symbols
Summary:
In a .symver assembler directive like:
.symver name, name2@@nodename
"name2@@nodename" should get the same symbol binding as "name".
While the ELF object writer is updating the symbol binding for .symver
aliases before emitting the object file, not doing so when the module
inline assembly is handled by the RecordStreamer is causing the wrong
behavior in *LTO mode.
E.g. when "name" is global, "name2@@nodename" must also be marked as
global. Otherwise, the symbol is skipped when iterating over the LTO
InputFile symbols (InputFile::Symbol::shouldSkip). So, for example,
when performing any *LTO via the gold-plugin, the versioned symbol
definition is not recorded by the plugin and passed back to the
linker. If the object was in an archive, and there were no other symbols
needed from that object, the object would not be included in the final
link and references to the versioned symbol are undefined.
The llvm-lto2 tests added will give an error about an unused symbol
resolution without the fix.
Reviewers: rafael, pcc
Reviewed By: pcc
Subscribers: mehdi_amini, llvm-commits
Differential Revision: https://reviews.llvm.org/D30485
llvm-svn: 297332
2017-03-09 01:19:49 +01:00
|
|
|
}
|