2013-02-20 01:26:04 +01:00
|
|
|
//===- llvm/unittest/ADT/OptionalTest.cpp - Optional unit tests -----------===//
|
|
|
|
//
|
2019-01-19 09:50:56 +01:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2013-02-20 01:26:04 +01:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/ADT/Optional.h"
|
2019-01-18 13:52:03 +01:00
|
|
|
#include "llvm/ADT/SmallString.h"
|
Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable
Current code breaks this version of MSVC due to a mismatch between `std::is_trivially_copyable` and `llvm::is_trivially_copyable` for `std::pair` instantiations. Hence I was attempting to use `std::is_trivially_copyable` to set `llvm::is_trivially_copyable<T>::value`.
I spent some time root causing an `llvm::Optional` build error on MSVC 16.8.3 related to the change described above:
```
62>C:\src\ocg_llvm\llvm-project\llvm\include\llvm/ADT/BreadthFirstIterator.h(96,12): error C2280: 'llvm::Optional<std::pair<std::pair<unsigned int,llvm::Graph<4>::NodeSubset> *,llvm::Optional<llvm::Graph<4>::ChildIterator>>> &llvm::Optional<std::pair<std::pair<unsigned int,llvm::Graph<4>::NodeSubset> *,llvm::Optional<llvm::Graph<4>::ChildIterator>>>::operator =(const llvm::Optional<std::pair<std::pair<unsigned int,llvm::Graph<4>::NodeSubset> *,llvm::Optional<llvm::Graph<4>::ChildIterator>>> &)': attempting to reference a deleted function (compiling source file C:\src\ocg_llvm\llvm-project\llvm\unittests\ADT\BreadthFirstIteratorTest.cpp)
...
```
The "trivial" specialization of `optional_detail::OptionalStorage` assumes that the value type is trivially copy constructible and trivially copy assignable. The specialization is invoked based on a check of `is_trivially_copyable` alone, which does not imply both `is_trivially_copy_assignable` and `is_trivially_copy_constructible` are true.
[[ https://en.cppreference.com/w/cpp/named_req/TriviallyCopyable | According to the spec ]], a deleted assignment operator does not make `is_trivially_copyable` false. So I think all these properties need to be checked explicitly in order to specialize `OptionalStorage` to the "trivial" version:
```
/// Storage for any type.
template <typename T, bool = std::is_trivially_copy_constructible<T>::value
&& std::is_trivially_copy_assignable<T>::value>
class OptionalStorage {
```
Above fixed my build break in MSVC, but I think we need to explicitly check `is_trivially_copy_constructible` too since it might be possible the copy constructor is deleted. Also would be ideal to move over to `std::is_trivially_copyable` instead of the `llvm` namespace verson.
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D93510
2021-01-16 15:34:20 +01:00
|
|
|
#include "llvm/ADT/StringMap.h"
|
2019-01-18 13:52:03 +01:00
|
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
#include "gtest/gtest-spi.h"
|
2017-06-06 13:06:56 +02:00
|
|
|
#include "gtest/gtest.h"
|
2016-08-11 22:10:15 +02:00
|
|
|
|
2019-02-13 11:19:06 +01:00
|
|
|
#include <array>
|
|
|
|
|
2019-02-18 13:07:12 +01:00
|
|
|
|
2013-02-20 01:26:04 +01:00
|
|
|
using namespace llvm;
|
|
|
|
|
2020-12-03 07:02:48 +01:00
|
|
|
static_assert(std::is_trivially_copyable<Optional<int>>::value,
|
|
|
|
"trivially copyable");
|
2019-02-18 13:07:12 +01:00
|
|
|
|
2020-12-03 07:02:48 +01:00
|
|
|
static_assert(std::is_trivially_copyable<Optional<std::array<int, 3>>>::value,
|
2019-02-18 13:07:12 +01:00
|
|
|
"trivially copyable");
|
|
|
|
|
2020-08-21 10:45:44 +02:00
|
|
|
void OptionalWorksInConstexpr() {
|
|
|
|
constexpr auto x1 = Optional<int>();
|
|
|
|
constexpr Optional<int> x2{};
|
|
|
|
static_assert(!x1.hasValue() && !x2.hasValue(),
|
|
|
|
"Default construction and hasValue() are contexpr");
|
|
|
|
constexpr auto y1 = Optional<int>(3);
|
|
|
|
constexpr Optional<int> y2{3};
|
|
|
|
static_assert(y1.getValue() == y2.getValue() && y1.getValue() == 3,
|
|
|
|
"Construction with value and getValue() are constexpr");
|
|
|
|
static_assert(Optional<int>{3} >= 2 && Optional<int>{1} < Optional<int>{2},
|
|
|
|
"Comparisons work in constexpr");
|
|
|
|
}
|
|
|
|
|
2013-02-20 01:26:04 +01:00
|
|
|
namespace {
|
|
|
|
|
|
|
|
struct NonDefaultConstructible {
|
|
|
|
static unsigned CopyConstructions;
|
|
|
|
static unsigned Destructions;
|
|
|
|
static unsigned CopyAssignments;
|
|
|
|
explicit NonDefaultConstructible(int) {
|
|
|
|
}
|
|
|
|
NonDefaultConstructible(const NonDefaultConstructible&) {
|
|
|
|
++CopyConstructions;
|
|
|
|
}
|
|
|
|
NonDefaultConstructible &operator=(const NonDefaultConstructible&) {
|
|
|
|
++CopyAssignments;
|
|
|
|
return *this;
|
|
|
|
}
|
|
|
|
~NonDefaultConstructible() {
|
|
|
|
++Destructions;
|
|
|
|
}
|
|
|
|
static void ResetCounts() {
|
|
|
|
CopyConstructions = 0;
|
|
|
|
Destructions = 0;
|
|
|
|
CopyAssignments = 0;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
unsigned NonDefaultConstructible::CopyConstructions = 0;
|
|
|
|
unsigned NonDefaultConstructible::Destructions = 0;
|
|
|
|
unsigned NonDefaultConstructible::CopyAssignments = 0;
|
|
|
|
|
2019-02-18 13:07:12 +01:00
|
|
|
static_assert(
|
2020-12-03 07:02:48 +01:00
|
|
|
!std::is_trivially_copyable<Optional<NonDefaultConstructible>>::value,
|
|
|
|
"not trivially copyable");
|
2019-02-18 13:07:12 +01:00
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, NonDefaultConstructibleTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
Optional<NonDefaultConstructible> O;
|
|
|
|
EXPECT_FALSE(O);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, ResetTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
Optional<NonDefaultConstructible> O(NonDefaultConstructible(3));
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
2013-02-20 07:25:36 +01:00
|
|
|
O.reset();
|
2013-02-20 01:26:04 +01:00
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, InitializationLeakTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
Optional<NonDefaultConstructible>(NonDefaultConstructible(3));
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(2u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, CopyConstructionTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<NonDefaultConstructible> A(NonDefaultConstructible(3));
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
Optional<NonDefaultConstructible> B(A);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
}
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(2u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, ConstructingCopyAssignmentTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<NonDefaultConstructible> A(NonDefaultConstructible(3));
|
|
|
|
Optional<NonDefaultConstructible> B;
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
B = A;
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
}
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(2u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, CopyingCopyAssignmentTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<NonDefaultConstructible> A(NonDefaultConstructible(3));
|
|
|
|
Optional<NonDefaultConstructible> B(NonDefaultConstructible(4));
|
|
|
|
EXPECT_EQ(2u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(2u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
B = A;
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
}
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(2u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, DeletingCopyAssignmentTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<NonDefaultConstructible> A;
|
|
|
|
Optional<NonDefaultConstructible> B(NonDefaultConstructible(3));
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
B = A;
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
}
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, NullCopyConstructionTest) {
|
2013-02-20 01:26:04 +01:00
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<NonDefaultConstructible> A;
|
|
|
|
Optional<NonDefaultConstructible> B;
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
B = A;
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
}
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2021-04-06 00:59:09 +02:00
|
|
|
TEST(OptionalTest, InPlaceConstructionNonDefaultConstructibleTest) {
|
|
|
|
NonDefaultConstructible::ResetCounts();
|
|
|
|
{ Optional<NonDefaultConstructible> A{in_place, 1}; }
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyConstructions);
|
|
|
|
EXPECT_EQ(0u, NonDefaultConstructible::CopyAssignments);
|
|
|
|
EXPECT_EQ(1u, NonDefaultConstructible::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, GetValueOr) {
|
2014-09-29 20:56:08 +02:00
|
|
|
Optional<int> A;
|
|
|
|
EXPECT_EQ(42, A.getValueOr(42));
|
|
|
|
|
|
|
|
A = 5;
|
|
|
|
EXPECT_EQ(5, A.getValueOr(42));
|
|
|
|
}
|
|
|
|
|
2014-10-01 04:12:35 +02:00
|
|
|
struct MultiArgConstructor {
|
|
|
|
int x, y;
|
|
|
|
MultiArgConstructor(int x, int y) : x(x), y(y) {}
|
|
|
|
explicit MultiArgConstructor(int x, bool positive)
|
|
|
|
: x(x), y(positive ? x : -x) {}
|
|
|
|
|
2015-02-15 23:54:22 +01:00
|
|
|
MultiArgConstructor(const MultiArgConstructor &) = delete;
|
|
|
|
MultiArgConstructor(MultiArgConstructor &&) = delete;
|
|
|
|
MultiArgConstructor &operator=(const MultiArgConstructor &) = delete;
|
|
|
|
MultiArgConstructor &operator=(MultiArgConstructor &&) = delete;
|
2014-10-01 04:12:35 +02:00
|
|
|
|
2021-04-06 00:59:09 +02:00
|
|
|
friend bool operator==(const MultiArgConstructor &LHS,
|
|
|
|
const MultiArgConstructor &RHS) {
|
|
|
|
return LHS.x == RHS.x && LHS.y == RHS.y;
|
|
|
|
}
|
|
|
|
|
2014-10-01 04:12:35 +02:00
|
|
|
static unsigned Destructions;
|
|
|
|
~MultiArgConstructor() {
|
|
|
|
++Destructions;
|
|
|
|
}
|
|
|
|
static void ResetCounts() {
|
|
|
|
Destructions = 0;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
unsigned MultiArgConstructor::Destructions = 0;
|
|
|
|
|
2020-12-03 07:02:48 +01:00
|
|
|
static_assert(!std::is_trivially_copyable<Optional<MultiArgConstructor>>::value,
|
|
|
|
"not trivially copyable");
|
2019-02-18 13:07:12 +01:00
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, Emplace) {
|
2014-10-01 04:12:35 +02:00
|
|
|
MultiArgConstructor::ResetCounts();
|
|
|
|
Optional<MultiArgConstructor> A;
|
|
|
|
|
|
|
|
A.emplace(1, 2);
|
|
|
|
EXPECT_TRUE(A.hasValue());
|
|
|
|
EXPECT_EQ(1, A->x);
|
|
|
|
EXPECT_EQ(2, A->y);
|
|
|
|
EXPECT_EQ(0u, MultiArgConstructor::Destructions);
|
|
|
|
|
|
|
|
A.emplace(5, false);
|
|
|
|
EXPECT_TRUE(A.hasValue());
|
|
|
|
EXPECT_EQ(5, A->x);
|
|
|
|
EXPECT_EQ(-5, A->y);
|
|
|
|
EXPECT_EQ(1u, MultiArgConstructor::Destructions);
|
|
|
|
}
|
|
|
|
|
2021-04-06 00:59:09 +02:00
|
|
|
TEST(OptionalTest, InPlaceConstructionMultiArgConstructorTest) {
|
|
|
|
MultiArgConstructor::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<MultiArgConstructor> A{in_place, 1, 2};
|
|
|
|
EXPECT_TRUE(A.hasValue());
|
|
|
|
EXPECT_EQ(1, A->x);
|
|
|
|
EXPECT_EQ(2, A->y);
|
|
|
|
Optional<MultiArgConstructor> B{in_place, 5, false};
|
|
|
|
EXPECT_TRUE(B.hasValue());
|
|
|
|
EXPECT_EQ(5, B->x);
|
|
|
|
EXPECT_EQ(-5, B->y);
|
|
|
|
EXPECT_EQ(0u, MultiArgConstructor::Destructions);
|
|
|
|
}
|
|
|
|
EXPECT_EQ(2u, MultiArgConstructor::Destructions);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(OptionalTest, InPlaceConstructionAndEmplaceEquivalentTest) {
|
|
|
|
MultiArgConstructor::ResetCounts();
|
|
|
|
{
|
|
|
|
Optional<MultiArgConstructor> A{in_place, 1, 2};
|
|
|
|
Optional<MultiArgConstructor> B;
|
|
|
|
B.emplace(1, 2);
|
|
|
|
EXPECT_EQ(0u, MultiArgConstructor::Destructions);
|
|
|
|
ASSERT_EQ(A, B);
|
|
|
|
}
|
|
|
|
EXPECT_EQ(2u, MultiArgConstructor::Destructions);
|
|
|
|
}
|
|
|
|
|
2013-02-21 08:58:45 +01:00
|
|
|
struct MoveOnly {
|
|
|
|
static unsigned MoveConstructions;
|
|
|
|
static unsigned Destructions;
|
|
|
|
static unsigned MoveAssignments;
|
|
|
|
int val;
|
|
|
|
explicit MoveOnly(int val) : val(val) {
|
|
|
|
}
|
|
|
|
MoveOnly(MoveOnly&& other) {
|
|
|
|
val = other.val;
|
|
|
|
++MoveConstructions;
|
|
|
|
}
|
|
|
|
MoveOnly &operator=(MoveOnly&& other) {
|
|
|
|
val = other.val;
|
|
|
|
++MoveAssignments;
|
|
|
|
return *this;
|
|
|
|
}
|
|
|
|
~MoveOnly() {
|
|
|
|
++Destructions;
|
|
|
|
}
|
|
|
|
static void ResetCounts() {
|
|
|
|
MoveConstructions = 0;
|
|
|
|
Destructions = 0;
|
|
|
|
MoveAssignments = 0;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
unsigned MoveOnly::MoveConstructions = 0;
|
|
|
|
unsigned MoveOnly::Destructions = 0;
|
|
|
|
unsigned MoveOnly::MoveAssignments = 0;
|
|
|
|
|
2020-12-03 07:02:48 +01:00
|
|
|
static_assert(!std::is_trivially_copyable<Optional<MoveOnly>>::value,
|
2019-02-18 13:07:12 +01:00
|
|
|
"not trivially copyable");
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyNull) {
|
2013-02-21 08:55:39 +01:00
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
Optional<MoveOnly> O;
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyConstruction) {
|
2013-02-21 08:55:39 +01:00
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
Optional<MoveOnly> O(MoveOnly(3));
|
|
|
|
EXPECT_TRUE((bool)O);
|
|
|
|
EXPECT_EQ(3, O->val);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyMoveConstruction) {
|
2013-02-21 08:55:39 +01:00
|
|
|
Optional<MoveOnly> A(MoveOnly(3));
|
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
Optional<MoveOnly> B(std::move(A));
|
2018-01-25 18:24:22 +01:00
|
|
|
EXPECT_TRUE((bool)A);
|
2013-02-21 08:55:39 +01:00
|
|
|
EXPECT_TRUE((bool)B);
|
|
|
|
EXPECT_EQ(3, B->val);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
2018-01-25 18:24:22 +01:00
|
|
|
EXPECT_EQ(0u, MoveOnly::Destructions);
|
2013-02-21 08:55:39 +01:00
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyAssignment) {
|
2013-02-21 08:55:39 +01:00
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
Optional<MoveOnly> O;
|
|
|
|
O = MoveOnly(3);
|
|
|
|
EXPECT_TRUE((bool)O);
|
|
|
|
EXPECT_EQ(3, O->val);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyInitializingAssignment) {
|
2013-02-21 08:55:39 +01:00
|
|
|
Optional<MoveOnly> A(MoveOnly(3));
|
|
|
|
Optional<MoveOnly> B;
|
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
B = std::move(A);
|
2018-01-25 18:24:22 +01:00
|
|
|
EXPECT_TRUE((bool)A);
|
2013-02-21 08:55:39 +01:00
|
|
|
EXPECT_TRUE((bool)B);
|
|
|
|
EXPECT_EQ(3, B->val);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
2018-01-25 18:24:22 +01:00
|
|
|
EXPECT_EQ(0u, MoveOnly::Destructions);
|
2013-02-21 08:55:39 +01:00
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyNullingAssignment) {
|
2013-02-21 08:55:39 +01:00
|
|
|
Optional<MoveOnly> A;
|
|
|
|
Optional<MoveOnly> B(MoveOnly(3));
|
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
B = std::move(A);
|
|
|
|
EXPECT_FALSE((bool)A);
|
|
|
|
EXPECT_FALSE((bool)B);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveOnlyAssigningAssignment) {
|
2013-02-21 08:55:39 +01:00
|
|
|
Optional<MoveOnly> A(MoveOnly(3));
|
|
|
|
Optional<MoveOnly> B(MoveOnly(4));
|
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
B = std::move(A);
|
2018-01-25 18:24:22 +01:00
|
|
|
EXPECT_TRUE((bool)A);
|
2013-02-21 08:55:39 +01:00
|
|
|
EXPECT_TRUE((bool)B);
|
|
|
|
EXPECT_EQ(3, B->val);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveAssignments);
|
2018-01-25 18:24:22 +01:00
|
|
|
EXPECT_EQ(0u, MoveOnly::Destructions);
|
2013-02-21 08:55:39 +01:00
|
|
|
}
|
|
|
|
|
2014-10-01 20:29:44 +02:00
|
|
|
struct Immovable {
|
|
|
|
static unsigned Constructions;
|
|
|
|
static unsigned Destructions;
|
|
|
|
int val;
|
|
|
|
explicit Immovable(int val) : val(val) {
|
|
|
|
++Constructions;
|
|
|
|
}
|
|
|
|
~Immovable() {
|
|
|
|
++Destructions;
|
|
|
|
}
|
|
|
|
static void ResetCounts() {
|
|
|
|
Constructions = 0;
|
|
|
|
Destructions = 0;
|
|
|
|
}
|
|
|
|
private:
|
|
|
|
// This should disable all move/copy operations.
|
2015-02-15 23:54:22 +01:00
|
|
|
Immovable(Immovable&& other) = delete;
|
2014-10-01 20:29:44 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
unsigned Immovable::Constructions = 0;
|
|
|
|
unsigned Immovable::Destructions = 0;
|
|
|
|
|
2020-12-03 07:02:48 +01:00
|
|
|
static_assert(!std::is_trivially_copyable<Optional<Immovable>>::value,
|
2019-02-18 13:07:12 +01:00
|
|
|
"not trivially copyable");
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, ImmovableEmplace) {
|
2014-10-01 20:29:44 +02:00
|
|
|
Optional<Immovable> A;
|
|
|
|
Immovable::ResetCounts();
|
2014-10-01 04:12:35 +02:00
|
|
|
A.emplace(4);
|
|
|
|
EXPECT_TRUE((bool)A);
|
|
|
|
EXPECT_EQ(4, A->val);
|
2014-10-01 20:29:44 +02:00
|
|
|
EXPECT_EQ(1u, Immovable::Constructions);
|
|
|
|
EXPECT_EQ(0u, Immovable::Destructions);
|
2021-04-06 00:59:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
TEST(OptionalTest, ImmovableInPlaceConstruction) {
|
|
|
|
Immovable::ResetCounts();
|
|
|
|
Optional<Immovable> A{in_place, 4};
|
|
|
|
EXPECT_TRUE((bool)A);
|
|
|
|
EXPECT_EQ(4, A->val);
|
|
|
|
EXPECT_EQ(1u, Immovable::Constructions);
|
|
|
|
EXPECT_EQ(0u, Immovable::Destructions);
|
2014-10-01 04:12:35 +02:00
|
|
|
}
|
|
|
|
|
Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable
Current code breaks this version of MSVC due to a mismatch between `std::is_trivially_copyable` and `llvm::is_trivially_copyable` for `std::pair` instantiations. Hence I was attempting to use `std::is_trivially_copyable` to set `llvm::is_trivially_copyable<T>::value`.
I spent some time root causing an `llvm::Optional` build error on MSVC 16.8.3 related to the change described above:
```
62>C:\src\ocg_llvm\llvm-project\llvm\include\llvm/ADT/BreadthFirstIterator.h(96,12): error C2280: 'llvm::Optional<std::pair<std::pair<unsigned int,llvm::Graph<4>::NodeSubset> *,llvm::Optional<llvm::Graph<4>::ChildIterator>>> &llvm::Optional<std::pair<std::pair<unsigned int,llvm::Graph<4>::NodeSubset> *,llvm::Optional<llvm::Graph<4>::ChildIterator>>>::operator =(const llvm::Optional<std::pair<std::pair<unsigned int,llvm::Graph<4>::NodeSubset> *,llvm::Optional<llvm::Graph<4>::ChildIterator>>> &)': attempting to reference a deleted function (compiling source file C:\src\ocg_llvm\llvm-project\llvm\unittests\ADT\BreadthFirstIteratorTest.cpp)
...
```
The "trivial" specialization of `optional_detail::OptionalStorage` assumes that the value type is trivially copy constructible and trivially copy assignable. The specialization is invoked based on a check of `is_trivially_copyable` alone, which does not imply both `is_trivially_copy_assignable` and `is_trivially_copy_constructible` are true.
[[ https://en.cppreference.com/w/cpp/named_req/TriviallyCopyable | According to the spec ]], a deleted assignment operator does not make `is_trivially_copyable` false. So I think all these properties need to be checked explicitly in order to specialize `OptionalStorage` to the "trivial" version:
```
/// Storage for any type.
template <typename T, bool = std::is_trivially_copy_constructible<T>::value
&& std::is_trivially_copy_assignable<T>::value>
class OptionalStorage {
```
Above fixed my build break in MSVC, but I think we need to explicitly check `is_trivially_copy_constructible` too since it might be possible the copy constructor is deleted. Also would be ideal to move over to `std::is_trivially_copyable` instead of the `llvm` namespace verson.
Reviewed By: dblaikie
Differential Revision: https://reviews.llvm.org/D93510
2021-01-16 15:34:20 +01:00
|
|
|
// Craft a class which is_trivially_copyable, but not
|
|
|
|
// is_trivially_copy_constructible.
|
|
|
|
struct NonTCopy {
|
|
|
|
NonTCopy() = default;
|
|
|
|
|
|
|
|
// Delete the volatile copy constructor to engage the "rule of 3" and delete
|
|
|
|
// any unspecified copy assignment or constructor.
|
|
|
|
NonTCopy(volatile NonTCopy const &) = delete;
|
|
|
|
|
|
|
|
// Leave the non-volatile default copy constructor unspecified (deleted by
|
|
|
|
// rule of 3)
|
|
|
|
|
|
|
|
// This template can serve as the copy constructor, but isn't chosen
|
|
|
|
// by =default in a class with a 'NonTCopy' member.
|
|
|
|
template <typename Self = NonTCopy>
|
|
|
|
NonTCopy(Self const &Other) : Val(Other.Val) {}
|
|
|
|
|
|
|
|
NonTCopy &operator=(NonTCopy const &) = default;
|
|
|
|
|
|
|
|
int Val{0};
|
|
|
|
};
|
|
|
|
|
|
|
|
#if defined(_MSC_VER) && _MSC_VER >= 1927 && !defined(__clang__)
|
|
|
|
// Currently only true on recent MSVC releases.
|
|
|
|
static_assert(std::is_trivially_copyable<NonTCopy>::value,
|
|
|
|
"Expect NonTCopy to be trivially copyable");
|
|
|
|
|
|
|
|
static_assert(!std::is_trivially_copy_constructible<NonTCopy>::value,
|
|
|
|
"Expect NonTCopy not to be trivially copy constructible.");
|
|
|
|
#endif // defined(_MSC_VER) && _MSC_VER >= 1927
|
|
|
|
|
|
|
|
TEST(OptionalTest, DeletedCopyConstructor) {
|
|
|
|
|
|
|
|
// Expect compile to fail if 'trivial' version of
|
|
|
|
// optional_detail::OptionalStorage is chosen.
|
|
|
|
using NonTCopyOptT = Optional<NonTCopy>;
|
|
|
|
NonTCopyOptT NonTCopy1;
|
|
|
|
|
|
|
|
// Check that the Optional can be copy constructed.
|
|
|
|
NonTCopyOptT NonTCopy2{NonTCopy1};
|
|
|
|
|
|
|
|
// Check that the Optional can be copy assigned.
|
|
|
|
NonTCopy1 = NonTCopy2;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Craft a class which is_trivially_copyable, but not
|
|
|
|
// is_trivially_copy_assignable.
|
|
|
|
class NonTAssign {
|
|
|
|
public:
|
|
|
|
NonTAssign() = default;
|
|
|
|
NonTAssign(NonTAssign const &) = default;
|
|
|
|
|
|
|
|
// Delete the volatile copy assignment to engage the "rule of 3" and delete
|
|
|
|
// any unspecified copy assignment or constructor.
|
|
|
|
NonTAssign &operator=(volatile NonTAssign const &) = delete;
|
|
|
|
|
|
|
|
// Leave the non-volatile default copy assignment unspecified (deleted by rule
|
|
|
|
// of 3).
|
|
|
|
|
|
|
|
// This template can serve as the copy assignment, but isn't chosen
|
|
|
|
// by =default in a class with a 'NonTAssign' member.
|
|
|
|
template <typename Self = NonTAssign>
|
|
|
|
NonTAssign &operator=(Self const &Other) {
|
|
|
|
A = Other.A;
|
|
|
|
return *this;
|
|
|
|
}
|
|
|
|
|
|
|
|
int A{0};
|
|
|
|
};
|
|
|
|
|
|
|
|
#if defined(_MSC_VER) && _MSC_VER >= 1927 && !defined(__clang__)
|
|
|
|
// Currently only true on recent MSVC releases.
|
|
|
|
static_assert(std::is_trivially_copyable<NonTAssign>::value,
|
|
|
|
"Expect NonTAssign to be trivially copyable");
|
|
|
|
|
|
|
|
static_assert(!std::is_trivially_copy_assignable<NonTAssign>::value,
|
|
|
|
"Expect NonTAssign not to be trivially assignable.");
|
|
|
|
#endif // defined(_MSC_VER) && _MSC_VER >= 1927
|
|
|
|
|
|
|
|
TEST(OptionalTest, DeletedCopyAssignment) {
|
|
|
|
|
|
|
|
// Expect compile to fail if 'trivial' version of
|
|
|
|
// optional_detail::OptionalStorage is chosen.
|
|
|
|
using NonTAssignOptT = Optional<NonTAssign>;
|
|
|
|
NonTAssignOptT NonTAssign1;
|
|
|
|
|
|
|
|
// Check that the Optional can be copy constructed.
|
|
|
|
NonTAssignOptT NonTAssign2{NonTAssign1};
|
|
|
|
|
|
|
|
// Check that the Optional can be copy assigned.
|
|
|
|
NonTAssign1 = NonTAssign2;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct NoTMove {
|
|
|
|
NoTMove() = default;
|
|
|
|
NoTMove(NoTMove const &) = default;
|
|
|
|
NoTMove &operator=(NoTMove const &) = default;
|
|
|
|
|
|
|
|
// Delete move constructor / assignment. Compiler should fall-back to the
|
|
|
|
// trivial copy constructor / assignment in the trivial OptionalStorage
|
|
|
|
// specialization.
|
|
|
|
NoTMove(NoTMove &&) = delete;
|
|
|
|
NoTMove &operator=(NoTMove &&) = delete;
|
|
|
|
|
|
|
|
int Val{0};
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST(OptionalTest, DeletedMoveConstructor) {
|
|
|
|
using NoTMoveOptT = Optional<NoTMove>;
|
|
|
|
|
|
|
|
NoTMoveOptT NonTMove1;
|
|
|
|
NoTMoveOptT NonTMove2{std::move(NonTMove1)};
|
|
|
|
|
|
|
|
NonTMove1 = std::move(NonTMove2);
|
|
|
|
|
|
|
|
static_assert(
|
|
|
|
std::is_trivially_copyable<NoTMoveOptT>::value,
|
|
|
|
"Expect Optional<NoTMove> to still use the trivial specialization "
|
|
|
|
"of OptionalStorage despite the deleted move constructor / assignment.");
|
|
|
|
}
|
|
|
|
|
|
|
|
class NoCopyStringMap {
|
|
|
|
public:
|
|
|
|
NoCopyStringMap() = default;
|
|
|
|
|
|
|
|
private:
|
|
|
|
llvm::StringMap<std::unique_ptr<int>> Map;
|
|
|
|
};
|
|
|
|
|
|
|
|
TEST(OptionalTest, DeletedCopyStringMap) {
|
|
|
|
// Old versions of gcc (7.3 and prior) instantiate the copy constructor when
|
|
|
|
// std::is_trivially_copyable is instantiated. This test will fail
|
|
|
|
// compilation if std::is_trivially_copyable is used in the OptionalStorage
|
|
|
|
// specialization condition by gcc <= 7.3.
|
|
|
|
Optional<NoCopyStringMap> TestInstantiation;
|
|
|
|
}
|
|
|
|
|
2020-01-22 18:36:48 +01:00
|
|
|
#if LLVM_HAS_RVALUE_REFERENCE_THIS
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, MoveGetValueOr) {
|
2014-09-29 20:56:08 +02:00
|
|
|
Optional<MoveOnly> A;
|
|
|
|
|
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
EXPECT_EQ(42, std::move(A).getValueOr(MoveOnly(42)).val);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
|
|
|
EXPECT_EQ(2u, MoveOnly::Destructions);
|
|
|
|
|
|
|
|
A = MoveOnly(5);
|
|
|
|
MoveOnly::ResetCounts();
|
|
|
|
EXPECT_EQ(5, std::move(A).getValueOr(MoveOnly(42)).val);
|
|
|
|
EXPECT_EQ(1u, MoveOnly::MoveConstructions);
|
|
|
|
EXPECT_EQ(0u, MoveOnly::MoveAssignments);
|
|
|
|
EXPECT_EQ(2u, MoveOnly::Destructions);
|
|
|
|
}
|
|
|
|
|
2020-01-22 18:36:48 +01:00
|
|
|
#endif // LLVM_HAS_RVALUE_REFERENCE_THIS
|
|
|
|
|
2016-08-11 22:10:15 +02:00
|
|
|
struct EqualTo {
|
|
|
|
template <typename T, typename U> static bool apply(const T &X, const U &Y) {
|
|
|
|
return X == Y;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
struct NotEqualTo {
|
|
|
|
template <typename T, typename U> static bool apply(const T &X, const U &Y) {
|
|
|
|
return X != Y;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
struct Less {
|
|
|
|
template <typename T, typename U> static bool apply(const T &X, const U &Y) {
|
|
|
|
return X < Y;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
struct Greater {
|
|
|
|
template <typename T, typename U> static bool apply(const T &X, const U &Y) {
|
|
|
|
return X > Y;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
struct LessEqual {
|
|
|
|
template <typename T, typename U> static bool apply(const T &X, const U &Y) {
|
|
|
|
return X <= Y;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
struct GreaterEqual {
|
|
|
|
template <typename T, typename U> static bool apply(const T &X, const U &Y) {
|
|
|
|
return X >= Y;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
template <typename OperatorT, typename T>
|
|
|
|
void CheckRelation(const Optional<T> &Lhs, const Optional<T> &Rhs,
|
|
|
|
bool Expected) {
|
|
|
|
EXPECT_EQ(Expected, OperatorT::apply(Lhs, Rhs));
|
|
|
|
|
|
|
|
if (Lhs)
|
|
|
|
EXPECT_EQ(Expected, OperatorT::apply(*Lhs, Rhs));
|
|
|
|
else
|
|
|
|
EXPECT_EQ(Expected, OperatorT::apply(None, Rhs));
|
|
|
|
|
|
|
|
if (Rhs)
|
|
|
|
EXPECT_EQ(Expected, OperatorT::apply(Lhs, *Rhs));
|
|
|
|
else
|
|
|
|
EXPECT_EQ(Expected, OperatorT::apply(Lhs, None));
|
|
|
|
}
|
|
|
|
|
|
|
|
struct EqualityMock {};
|
|
|
|
const Optional<EqualityMock> NoneEq, EqualityLhs((EqualityMock())),
|
|
|
|
EqualityRhs((EqualityMock()));
|
|
|
|
bool IsEqual;
|
|
|
|
|
|
|
|
bool operator==(const EqualityMock &Lhs, const EqualityMock &Rhs) {
|
|
|
|
EXPECT_EQ(&*EqualityLhs, &Lhs);
|
|
|
|
EXPECT_EQ(&*EqualityRhs, &Rhs);
|
|
|
|
return IsEqual;
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, OperatorEqual) {
|
2016-08-11 22:10:15 +02:00
|
|
|
CheckRelation<EqualTo>(NoneEq, NoneEq, true);
|
|
|
|
CheckRelation<EqualTo>(NoneEq, EqualityRhs, false);
|
|
|
|
CheckRelation<EqualTo>(EqualityLhs, NoneEq, false);
|
|
|
|
|
|
|
|
IsEqual = false;
|
|
|
|
CheckRelation<EqualTo>(EqualityLhs, EqualityRhs, IsEqual);
|
|
|
|
IsEqual = true;
|
|
|
|
CheckRelation<EqualTo>(EqualityLhs, EqualityRhs, IsEqual);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, OperatorNotEqual) {
|
2016-08-11 22:10:15 +02:00
|
|
|
CheckRelation<NotEqualTo>(NoneEq, NoneEq, false);
|
|
|
|
CheckRelation<NotEqualTo>(NoneEq, EqualityRhs, true);
|
|
|
|
CheckRelation<NotEqualTo>(EqualityLhs, NoneEq, true);
|
|
|
|
|
|
|
|
IsEqual = false;
|
|
|
|
CheckRelation<NotEqualTo>(EqualityLhs, EqualityRhs, !IsEqual);
|
|
|
|
IsEqual = true;
|
|
|
|
CheckRelation<NotEqualTo>(EqualityLhs, EqualityRhs, !IsEqual);
|
|
|
|
}
|
|
|
|
|
|
|
|
struct InequalityMock {};
|
|
|
|
const Optional<InequalityMock> NoneIneq, InequalityLhs((InequalityMock())),
|
|
|
|
InequalityRhs((InequalityMock()));
|
|
|
|
bool IsLess;
|
|
|
|
|
|
|
|
bool operator<(const InequalityMock &Lhs, const InequalityMock &Rhs) {
|
|
|
|
EXPECT_EQ(&*InequalityLhs, &Lhs);
|
|
|
|
EXPECT_EQ(&*InequalityRhs, &Rhs);
|
|
|
|
return IsLess;
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, OperatorLess) {
|
2016-08-11 22:10:15 +02:00
|
|
|
CheckRelation<Less>(NoneIneq, NoneIneq, false);
|
|
|
|
CheckRelation<Less>(NoneIneq, InequalityRhs, true);
|
|
|
|
CheckRelation<Less>(InequalityLhs, NoneIneq, false);
|
|
|
|
|
|
|
|
IsLess = false;
|
|
|
|
CheckRelation<Less>(InequalityLhs, InequalityRhs, IsLess);
|
|
|
|
IsLess = true;
|
|
|
|
CheckRelation<Less>(InequalityLhs, InequalityRhs, IsLess);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, OperatorGreater) {
|
2016-08-11 22:10:15 +02:00
|
|
|
CheckRelation<Greater>(NoneIneq, NoneIneq, false);
|
|
|
|
CheckRelation<Greater>(NoneIneq, InequalityRhs, false);
|
|
|
|
CheckRelation<Greater>(InequalityLhs, NoneIneq, true);
|
|
|
|
|
|
|
|
IsLess = false;
|
|
|
|
CheckRelation<Greater>(InequalityRhs, InequalityLhs, IsLess);
|
|
|
|
IsLess = true;
|
|
|
|
CheckRelation<Greater>(InequalityRhs, InequalityLhs, IsLess);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, OperatorLessEqual) {
|
2016-08-11 22:10:15 +02:00
|
|
|
CheckRelation<LessEqual>(NoneIneq, NoneIneq, true);
|
|
|
|
CheckRelation<LessEqual>(NoneIneq, InequalityRhs, true);
|
|
|
|
CheckRelation<LessEqual>(InequalityLhs, NoneIneq, false);
|
|
|
|
|
|
|
|
IsLess = false;
|
|
|
|
CheckRelation<LessEqual>(InequalityRhs, InequalityLhs, !IsLess);
|
|
|
|
IsLess = true;
|
|
|
|
CheckRelation<LessEqual>(InequalityRhs, InequalityLhs, !IsLess);
|
|
|
|
}
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, OperatorGreaterEqual) {
|
2016-08-11 22:10:15 +02:00
|
|
|
CheckRelation<GreaterEqual>(NoneIneq, NoneIneq, true);
|
|
|
|
CheckRelation<GreaterEqual>(NoneIneq, InequalityRhs, false);
|
|
|
|
CheckRelation<GreaterEqual>(InequalityLhs, NoneIneq, true);
|
|
|
|
|
|
|
|
IsLess = false;
|
|
|
|
CheckRelation<GreaterEqual>(InequalityLhs, InequalityRhs, !IsLess);
|
|
|
|
IsLess = true;
|
|
|
|
CheckRelation<GreaterEqual>(InequalityLhs, InequalityRhs, !IsLess);
|
2015-08-20 01:07:27 +02:00
|
|
|
}
|
|
|
|
|
2019-01-18 13:52:03 +01:00
|
|
|
struct ComparableAndStreamable {
|
|
|
|
friend bool operator==(ComparableAndStreamable,
|
|
|
|
ComparableAndStreamable) LLVM_ATTRIBUTE_USED {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
friend raw_ostream &operator<<(raw_ostream &OS, ComparableAndStreamable) {
|
|
|
|
return OS << "ComparableAndStreamable";
|
|
|
|
}
|
2013-02-20 01:26:04 +01:00
|
|
|
|
2019-01-18 13:52:03 +01:00
|
|
|
static Optional<ComparableAndStreamable> get() {
|
|
|
|
return ComparableAndStreamable();
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, StreamOperator) {
|
2019-01-18 13:52:03 +01:00
|
|
|
auto to_string = [](Optional<ComparableAndStreamable> O) {
|
|
|
|
SmallString<16> S;
|
|
|
|
raw_svector_ostream OS(S);
|
|
|
|
OS << O;
|
|
|
|
return S;
|
|
|
|
};
|
|
|
|
EXPECT_EQ("ComparableAndStreamable",
|
|
|
|
to_string(ComparableAndStreamable::get()));
|
|
|
|
EXPECT_EQ("None", to_string(None));
|
|
|
|
}
|
|
|
|
|
|
|
|
struct Comparable {
|
|
|
|
friend bool operator==(Comparable, Comparable) LLVM_ATTRIBUTE_USED {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
static Optional<Comparable> get() { return Comparable(); }
|
|
|
|
};
|
|
|
|
|
2020-12-04 20:27:02 +01:00
|
|
|
TEST(OptionalTest, UseInUnitTests) {
|
2019-01-18 13:52:03 +01:00
|
|
|
// Test that we invoke the streaming operators when pretty-printing values in
|
|
|
|
// EXPECT macros.
|
|
|
|
EXPECT_NONFATAL_FAILURE(EXPECT_EQ(llvm::None, ComparableAndStreamable::get()),
|
2021-05-14 17:10:50 +02:00
|
|
|
"Expected equality of these values:\n"
|
|
|
|
" llvm::None\n"
|
|
|
|
" Which is: None\n"
|
|
|
|
" ComparableAndStreamable::get()\n"
|
|
|
|
" Which is: ComparableAndStreamable");
|
2019-01-18 13:52:03 +01:00
|
|
|
|
|
|
|
// Test that it is still possible to compare objects which do not have a
|
|
|
|
// custom streaming operator.
|
|
|
|
EXPECT_NONFATAL_FAILURE(EXPECT_EQ(llvm::None, Comparable::get()), "object");
|
|
|
|
}
|
|
|
|
|
2020-12-04 04:26:56 +01:00
|
|
|
TEST(OptionalTest, HashValue) {
|
|
|
|
// Check that None, false, and true all hash differently.
|
|
|
|
Optional<bool> B, B0 = false, B1 = true;
|
|
|
|
EXPECT_NE(hash_value(B0), hash_value(B));
|
|
|
|
EXPECT_NE(hash_value(B1), hash_value(B));
|
|
|
|
EXPECT_NE(hash_value(B1), hash_value(B0));
|
|
|
|
|
|
|
|
// Check that None, 0, and 1 all hash differently.
|
|
|
|
Optional<int> I, I0 = 0, I1 = 1;
|
|
|
|
EXPECT_NE(hash_value(I0), hash_value(I));
|
|
|
|
EXPECT_NE(hash_value(I1), hash_value(I));
|
|
|
|
EXPECT_NE(hash_value(I1), hash_value(I0));
|
|
|
|
|
|
|
|
// Check None hash the same way regardless of type.
|
|
|
|
EXPECT_EQ(hash_value(B), hash_value(I));
|
|
|
|
}
|
|
|
|
|
2019-01-18 13:52:03 +01:00
|
|
|
} // end anonymous namespace
|