[XRay] FDRTraceWriter and FDR Trace Loading
Summary:
This is the first step in the larger refactoring and reduction of
D50441.
This step in the process does the following:
- Introduces more granular types of `Record`s representing the many
kinds of records written/read by the Flight Data Recorder (FDR) mode
`Trace` loading function(s).
- Introduces an abstract `RecordVisitor` type meant to handle the
processing of the various `Record` derived types. This `RecordVisitor`
has two implementations in this patch: `RecordInitializer` and
`FDRTraceWriter`.
- We also introduce a convenience interface for building a collection of
`Record` instances called a `LogBuilder`. This allows us to generate
sequences of `Record` instances manually (used in unit tests but
useful otherwise).
- The`FDRTraceWriter` class implements the `RecordVisitor` interface and
handles the writing of metadata records to a `raw_ostream`. We
demonstrate that in the unit test, we can generate in-memory FDR mode
traces using the specific `Record` derived types, which we load
through the `loadTrace(...)` function yielding valid `Trace` objects.
This patch introduces the required types and concepts for us to start
replacing the logic implemented in the `loadFDRLog` function to use the
more granular types. In subsequent patches, we will introduce more
visitor implementations which isolate the verification, printing,
indexing, production/consumption, and finally the conversion of the FDR
mode logs.
The overarching goal of these changes is to make handling FDR mode logs
better tested, more understandable, more extensible, and more
systematic. This will also allow us to better represent the execution
trace, as we improve the fidelity of the events we represent in an XRay
`Trace` object, which we intend to do after FDR mode log processing is
in better shape.
Reviewers: eizan
Reviewed By: eizan
Subscribers: mgorny, hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D51210
llvm-svn: 341029
2018-08-30 09:22:21 +02:00
|
|
|
//===- FDRRecordProducer.cpp - XRay FDR Mode Record Producer --------------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/XRay/FDRRecords.h"
|
|
|
|
|
|
|
|
namespace llvm {
|
|
|
|
namespace xray {
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(BufferExtents &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr, sizeof(uint64_t)))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a buffer extent (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.Size = E.getU64(&OffsetPtr);
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read buffer extent at offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - PreReadOffset);
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(WallclockRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a wallclock record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
auto BeginOffset = OffsetPtr;
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.Seconds = E.getU64(&OffsetPtr);
|
|
|
|
if (OffsetPtr == PreReadOffset)
|
|
|
|
return createStringError(
|
|
|
|
std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read wall clock 'seconds' field at offset %d.", OffsetPtr);
|
|
|
|
|
|
|
|
PreReadOffset = OffsetPtr;
|
|
|
|
R.Nanos = E.getU32(&OffsetPtr);
|
|
|
|
if (OffsetPtr == PreReadOffset)
|
|
|
|
return createStringError(
|
|
|
|
std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read wall clock 'nanos' field at offset %d.", OffsetPtr);
|
|
|
|
|
|
|
|
// Align to metadata record size boundary.
|
|
|
|
assert(OffsetPtr - BeginOffset <= MetadataRecord::kMetadataBodySize);
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - BeginOffset);
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(NewCPUIDRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a new cpu id record (%d).",
|
|
|
|
OffsetPtr);
|
2018-09-11 08:36:51 +02:00
|
|
|
auto BeginOffset = OffsetPtr;
|
[XRay] FDRTraceWriter and FDR Trace Loading
Summary:
This is the first step in the larger refactoring and reduction of
D50441.
This step in the process does the following:
- Introduces more granular types of `Record`s representing the many
kinds of records written/read by the Flight Data Recorder (FDR) mode
`Trace` loading function(s).
- Introduces an abstract `RecordVisitor` type meant to handle the
processing of the various `Record` derived types. This `RecordVisitor`
has two implementations in this patch: `RecordInitializer` and
`FDRTraceWriter`.
- We also introduce a convenience interface for building a collection of
`Record` instances called a `LogBuilder`. This allows us to generate
sequences of `Record` instances manually (used in unit tests but
useful otherwise).
- The`FDRTraceWriter` class implements the `RecordVisitor` interface and
handles the writing of metadata records to a `raw_ostream`. We
demonstrate that in the unit test, we can generate in-memory FDR mode
traces using the specific `Record` derived types, which we load
through the `loadTrace(...)` function yielding valid `Trace` objects.
This patch introduces the required types and concepts for us to start
replacing the logic implemented in the `loadFDRLog` function to use the
more granular types. In subsequent patches, we will introduce more
visitor implementations which isolate the verification, printing,
indexing, production/consumption, and finally the conversion of the FDR
mode logs.
The overarching goal of these changes is to make handling FDR mode logs
better tested, more understandable, more extensible, and more
systematic. This will also allow us to better represent the execution
trace, as we improve the fidelity of the events we represent in an XRay
`Trace` object, which we intend to do after FDR mode log processing is
in better shape.
Reviewers: eizan
Reviewed By: eizan
Subscribers: mgorny, hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D51210
llvm-svn: 341029
2018-08-30 09:22:21 +02:00
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.CPUId = E.getU16(&OffsetPtr);
|
|
|
|
if (OffsetPtr == PreReadOffset)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read CPU id at offset %d.", OffsetPtr);
|
|
|
|
|
2018-09-11 08:36:51 +02:00
|
|
|
PreReadOffset = OffsetPtr;
|
|
|
|
R.TSC = E.getU64(&OffsetPtr);
|
|
|
|
if (OffsetPtr == PreReadOffset)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read CPU TSC at offset %d.", OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - BeginOffset);
|
[XRay] FDRTraceWriter and FDR Trace Loading
Summary:
This is the first step in the larger refactoring and reduction of
D50441.
This step in the process does the following:
- Introduces more granular types of `Record`s representing the many
kinds of records written/read by the Flight Data Recorder (FDR) mode
`Trace` loading function(s).
- Introduces an abstract `RecordVisitor` type meant to handle the
processing of the various `Record` derived types. This `RecordVisitor`
has two implementations in this patch: `RecordInitializer` and
`FDRTraceWriter`.
- We also introduce a convenience interface for building a collection of
`Record` instances called a `LogBuilder`. This allows us to generate
sequences of `Record` instances manually (used in unit tests but
useful otherwise).
- The`FDRTraceWriter` class implements the `RecordVisitor` interface and
handles the writing of metadata records to a `raw_ostream`. We
demonstrate that in the unit test, we can generate in-memory FDR mode
traces using the specific `Record` derived types, which we load
through the `loadTrace(...)` function yielding valid `Trace` objects.
This patch introduces the required types and concepts for us to start
replacing the logic implemented in the `loadFDRLog` function to use the
more granular types. In subsequent patches, we will introduce more
visitor implementations which isolate the verification, printing,
indexing, production/consumption, and finally the conversion of the FDR
mode logs.
The overarching goal of these changes is to make handling FDR mode logs
better tested, more understandable, more extensible, and more
systematic. This will also allow us to better represent the execution
trace, as we improve the fidelity of the events we represent in an XRay
`Trace` object, which we intend to do after FDR mode log processing is
in better shape.
Reviewers: eizan
Reviewed By: eizan
Subscribers: mgorny, hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D51210
llvm-svn: 341029
2018-08-30 09:22:21 +02:00
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(TSCWrapRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a new TSC wrap record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.BaseTSC = E.getU64(&OffsetPtr);
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read TSC wrap record at offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - PreReadOffset);
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(CustomEventRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a custom event record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto BeginOffset = OffsetPtr;
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.Size = E.getSigned(&OffsetPtr, sizeof(int32_t));
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(
|
|
|
|
std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read a custom event record size field offset %d.", OffsetPtr);
|
|
|
|
|
|
|
|
PreReadOffset = OffsetPtr;
|
|
|
|
R.TSC = E.getU64(&OffsetPtr);
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(
|
|
|
|
std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read a custom event TSC field at offset %d.", OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - BeginOffset);
|
|
|
|
|
|
|
|
// Next we read in a fixed chunk of data from the given offset.
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr, R.Size))
|
|
|
|
return createStringError(
|
|
|
|
std::make_error_code(std::errc::bad_address),
|
|
|
|
"Cannot read %d bytes of custom event data from offset %d.", R.Size,
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
std::vector<uint8_t> Buffer;
|
|
|
|
Buffer.resize(R.Size);
|
|
|
|
if (E.getU8(&OffsetPtr, Buffer.data(), R.Size) != Buffer.data())
|
|
|
|
return createStringError(
|
|
|
|
std::make_error_code(std::errc::bad_message),
|
|
|
|
"Failed reading data into buffer of size %d at offset %d.", R.Size,
|
|
|
|
OffsetPtr);
|
|
|
|
R.Data.assign(Buffer.begin(), Buffer.end());
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(CallArgRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a call argument record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.Arg = E.getU64(&OffsetPtr);
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read a call arg record at offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - PreReadOffset);
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(PIDRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a process ID record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
2018-08-31 22:02:55 +02:00
|
|
|
R.PID = E.getSigned(&OffsetPtr, 4);
|
[XRay] FDRTraceWriter and FDR Trace Loading
Summary:
This is the first step in the larger refactoring and reduction of
D50441.
This step in the process does the following:
- Introduces more granular types of `Record`s representing the many
kinds of records written/read by the Flight Data Recorder (FDR) mode
`Trace` loading function(s).
- Introduces an abstract `RecordVisitor` type meant to handle the
processing of the various `Record` derived types. This `RecordVisitor`
has two implementations in this patch: `RecordInitializer` and
`FDRTraceWriter`.
- We also introduce a convenience interface for building a collection of
`Record` instances called a `LogBuilder`. This allows us to generate
sequences of `Record` instances manually (used in unit tests but
useful otherwise).
- The`FDRTraceWriter` class implements the `RecordVisitor` interface and
handles the writing of metadata records to a `raw_ostream`. We
demonstrate that in the unit test, we can generate in-memory FDR mode
traces using the specific `Record` derived types, which we load
through the `loadTrace(...)` function yielding valid `Trace` objects.
This patch introduces the required types and concepts for us to start
replacing the logic implemented in the `loadFDRLog` function to use the
more granular types. In subsequent patches, we will introduce more
visitor implementations which isolate the verification, printing,
indexing, production/consumption, and finally the conversion of the FDR
mode logs.
The overarching goal of these changes is to make handling FDR mode logs
better tested, more understandable, more extensible, and more
systematic. This will also allow us to better represent the execution
trace, as we improve the fidelity of the events we represent in an XRay
`Trace` object, which we intend to do after FDR mode log processing is
in better shape.
Reviewers: eizan
Reviewed By: eizan
Subscribers: mgorny, hiraditya, llvm-commits
Differential Revision: https://reviews.llvm.org/D51210
llvm-svn: 341029
2018-08-30 09:22:21 +02:00
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read a process ID record at offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - PreReadOffset);
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(NewBufferRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a new buffer record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto PreReadOffset = OffsetPtr;
|
|
|
|
R.TID = E.getSigned(&OffsetPtr, sizeof(int32_t));
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Cannot read a new buffer record at offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize - (OffsetPtr - PreReadOffset);
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(EndBufferRecord &R) {
|
|
|
|
if (!E.isValidOffsetForDataOfSize(OffsetPtr,
|
|
|
|
MetadataRecord::kMetadataBodySize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for an end-of-buffer record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
OffsetPtr += MetadataRecord::kMetadataBodySize;
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
Error RecordInitializer::visit(FunctionRecord &R) {
|
|
|
|
// For function records, we need to retreat one byte back to read a full
|
|
|
|
// unsigned 32-bit value. The first four bytes will have the following
|
|
|
|
// layout:
|
|
|
|
//
|
|
|
|
// bit 0 : function record indicator (must be 0)
|
|
|
|
// bits 1..3 : function record type
|
|
|
|
// bits 4..32 : function id
|
|
|
|
//
|
|
|
|
if (OffsetPtr == 0 || !E.isValidOffsetForDataOfSize(
|
|
|
|
--OffsetPtr, FunctionRecord::kFunctionRecordSize))
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Invalid offset for a function record (%d).",
|
|
|
|
OffsetPtr);
|
|
|
|
|
|
|
|
auto BeginOffset = OffsetPtr;
|
|
|
|
auto PreReadOffset = BeginOffset;
|
|
|
|
uint32_t Buffer = E.getU32(&OffsetPtr);
|
|
|
|
if (PreReadOffset == OffsetPtr)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_address),
|
|
|
|
"Cannot read function id field from offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
unsigned FunctionType = (Buffer >> 1) & 0x07;
|
|
|
|
switch (FunctionType) {
|
|
|
|
case static_cast<unsigned>(RecordTypes::ENTER):
|
|
|
|
case static_cast<unsigned>(RecordTypes::ENTER_ARG):
|
|
|
|
case static_cast<unsigned>(RecordTypes::EXIT):
|
|
|
|
case static_cast<unsigned>(RecordTypes::TAIL_EXIT):
|
|
|
|
R.Kind = static_cast<RecordTypes>(FunctionType);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Unknown function record type '%d' at offset %d.",
|
|
|
|
FunctionType, BeginOffset);
|
|
|
|
}
|
|
|
|
|
|
|
|
R.FuncId = Buffer >> 4;
|
|
|
|
PreReadOffset = OffsetPtr;
|
|
|
|
R.Delta = E.getU32(&OffsetPtr);
|
|
|
|
if (OffsetPtr == PreReadOffset)
|
|
|
|
return createStringError(std::make_error_code(std::errc::bad_message),
|
|
|
|
"Failed reading TSC delta from offset %d.",
|
|
|
|
OffsetPtr);
|
|
|
|
assert(FunctionRecord::kFunctionRecordSize == (OffsetPtr - BeginOffset));
|
|
|
|
return Error::success();
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace xray
|
|
|
|
} // namespace llvm
|