Re-work bit/bits value resolving in tblgen
- This patch is inspired by the failure of the following code snippet
which is used to convert enumerable values into encoding bits to
improve the readability of td files.
class S<int s> {
bits<2> V = !if(!eq(s, 8), {0, 0},
!if(!eq(s, 16), {0, 1},
!if(!eq(s, 32), {1, 0},
!if(!eq(s, 64), {1, 1}, {?, ?}))));
}
Later, PR8330 is found to report not exactly the same bug relevant
issue to bit/bits values.
- Instead of resolving bit/bits values separately through
resolveBitReference(), this patch adds getBit() for all Inits and
resolves bit value by resolving plus getting the specified bit. This
unifies the resolving of bit with other values and removes redundant
logic for resolving bit only. In addition,
BitsInit::resolveReferences() is optimized to take advantage of this
origanization by resolving VarBitInit's variable reference first and
then getting bits from it.
- The type interference in '!if' operator is revised to support possible
combinations of int and bits/bit in MHS and RHS.
- As there may be illegal assignments from integer value to bit, says
assign 2 to a bit, but we only check this during instantiation in some
cases, e.g.
bit V = !if(!eq(x, 17), 0, 2);
Verbose diagnostic message is generated when invalid value is
resolveed to help locating the error.
- PR8330 is fixed as well.
llvm-svn: 163360
2012-09-07 01:32:48 +02:00
|
|
|
// RUN: llvm-tblgen %s | FileCheck %s
|
2013-11-10 15:26:08 +01:00
|
|
|
// XFAIL: vg_leak
|
Re-work bit/bits value resolving in tblgen
- This patch is inspired by the failure of the following code snippet
which is used to convert enumerable values into encoding bits to
improve the readability of td files.
class S<int s> {
bits<2> V = !if(!eq(s, 8), {0, 0},
!if(!eq(s, 16), {0, 1},
!if(!eq(s, 32), {1, 0},
!if(!eq(s, 64), {1, 1}, {?, ?}))));
}
Later, PR8330 is found to report not exactly the same bug relevant
issue to bit/bits values.
- Instead of resolving bit/bits values separately through
resolveBitReference(), this patch adds getBit() for all Inits and
resolves bit value by resolving plus getting the specified bit. This
unifies the resolving of bit with other values and removes redundant
logic for resolving bit only. In addition,
BitsInit::resolveReferences() is optimized to take advantage of this
origanization by resolving VarBitInit's variable reference first and
then getting bits from it.
- The type interference in '!if' operator is revised to support possible
combinations of int and bits/bit in MHS and RHS.
- As there may be illegal assignments from integer value to bit, says
assign 2 to a bit, but we only check this during instantiation in some
cases, e.g.
bit V = !if(!eq(x, 17), 0, 2);
Verbose diagnostic message is generated when invalid value is
resolveed to help locating the error.
- PR8330 is fixed as well.
llvm-svn: 163360
2012-09-07 01:32:48 +02:00
|
|
|
|
|
|
|
|
class Or4<bits<8> Val> {
|
|
|
|
|
bits<8> V = {Val{7}, Val{6}, Val{5}, Val{4}, Val{3}, 1, Val{1}, Val{0} };
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
class Whatev<bits<8> x>;
|
|
|
|
|
|
|
|
|
|
class Whatever<bits<8> x> {
|
|
|
|
|
bits<8> W = {x{0}, x{1}, x{2}, x{3}, x{4}, x{5}, x{6}, x{7} };
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
multiclass X<bits<8> BaseOpc> {
|
|
|
|
|
def bar : Whatev<Or4<BaseOpc>.V >;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
multiclass Y<bits<8> BaseOpc> {
|
|
|
|
|
def foo : Whatever<Or4<BaseOpc>.V >;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
defm a : X<4>;
|
|
|
|
|
|
|
|
|
|
// CHECK: def abar
|
|
|
|
|
|
|
|
|
|
defm b : Y<8>;
|
|
|
|
|
|
|
|
|
|
// CHECK: def bfoo
|
|
|
|
|
// CHECK-NEXT: bits<8> W = { 0, 0, 1, 1, 0, 0, 0, 0 };
|
