2012-07-02 20:37:59 +02:00
|
|
|
; RUN: opt -basicaa -lint -disable-output < %s 2>&1 | FileCheck %s
|
2010-04-08 20:47:09 +02:00
|
|
|
target datalayout = "e-p:64:64:64"
|
|
|
|
|
|
|
|
|
|
declare fastcc void @bar()
|
2010-05-27 00:21:25 +02:00
|
|
|
declare void @llvm.stackrestore(i8*)
|
2010-05-28 19:44:00 +02:00
|
|
|
declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture, i64, i32, i1) nounwind
|
2010-05-28 23:43:57 +02:00
|
|
|
declare void @has_sret(i8* sret %p)
|
|
|
|
|
declare void @has_noaliases(i32* noalias %p, i32* %q)
|
|
|
|
|
declare void @one_arg(i32)
|
2010-04-08 20:47:09 +02:00
|
|
|
|
2010-04-30 21:05:00 +02:00
|
|
|
@CG = constant i32 7
|
2012-09-30 09:30:10 +02:00
|
|
|
@E = external global i8
|
2010-04-30 21:05:00 +02:00
|
|
|
|
2010-04-08 20:47:09 +02:00
|
|
|
define i32 @foo() noreturn {
|
2012-09-25 12:00:49 +02:00
|
|
|
%buf = alloca i8
|
|
|
|
|
%buf2 = alloca {i8, i8}, align 2
|
2010-04-08 20:47:09 +02:00
|
|
|
; CHECK: Caller and callee calling convention differ
|
|
|
|
|
call void @bar()
|
|
|
|
|
; CHECK: Null pointer dereference
|
|
|
|
|
store i32 0, i32* null
|
|
|
|
|
; CHECK: Null pointer dereference
|
2015-02-27 22:17:42 +01:00
|
|
|
%t = load i32, i32* null
|
2010-04-09 01:05:57 +02:00
|
|
|
; CHECK: Undef pointer dereference
|
|
|
|
|
store i32 0, i32* undef
|
|
|
|
|
; CHECK: Undef pointer dereference
|
2015-02-27 22:17:42 +01:00
|
|
|
%u = load i32, i32* undef
|
2010-05-28 23:43:57 +02:00
|
|
|
; CHECK: All-ones pointer dereference
|
|
|
|
|
store i32 0, i32* inttoptr (i64 -1 to i32*)
|
|
|
|
|
; CHECK: Address one pointer dereference
|
|
|
|
|
store i32 0, i32* inttoptr (i64 1 to i32*)
|
2010-04-08 20:47:09 +02:00
|
|
|
; CHECK: Memory reference address is misaligned
|
2012-09-25 12:00:49 +02:00
|
|
|
store i8 0, i8* %buf, align 2
|
|
|
|
|
; CHECK: Memory reference address is misaligned
|
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-27 20:29:02 +01:00
|
|
|
%gep = getelementptr {i8, i8}, {i8, i8}* %buf2, i32 0, i32 1
|
2012-09-25 12:00:49 +02:00
|
|
|
store i8 0, i8* %gep, align 2
|
2010-04-08 20:47:09 +02:00
|
|
|
; CHECK: Division by zero
|
|
|
|
|
%sd = sdiv i32 2, 0
|
|
|
|
|
; CHECK: Division by zero
|
|
|
|
|
%ud = udiv i32 2, 0
|
|
|
|
|
; CHECK: Division by zero
|
|
|
|
|
%sr = srem i32 2, 0
|
|
|
|
|
; CHECK: Division by zero
|
|
|
|
|
%ur = urem i32 2, 0
|
2010-04-09 01:05:57 +02:00
|
|
|
; CHECK: extractelement index out of range
|
|
|
|
|
%ee = extractelement <4 x i32> zeroinitializer, i32 4
|
|
|
|
|
; CHECK: insertelement index out of range
|
|
|
|
|
%ie = insertelement <4 x i32> zeroinitializer, i32 0, i32 4
|
|
|
|
|
; CHECK: Shift count out of range
|
|
|
|
|
%r = lshr i32 0, 32
|
|
|
|
|
; CHECK: Shift count out of range
|
|
|
|
|
%q = ashr i32 0, 32
|
|
|
|
|
; CHECK: Shift count out of range
|
|
|
|
|
%l = shl i32 0, 32
|
2010-04-09 03:39:53 +02:00
|
|
|
; CHECK: xor(undef, undef)
|
|
|
|
|
%xx = xor i32 undef, undef
|
|
|
|
|
; CHECK: sub(undef, undef)
|
|
|
|
|
%xs = sub i32 undef, undef
|
2010-04-30 21:05:00 +02:00
|
|
|
|
|
|
|
|
; CHECK: Write to read-only memory
|
|
|
|
|
store i32 8, i32* @CG
|
|
|
|
|
; CHECK: Write to text section
|
|
|
|
|
store i32 8, i32* bitcast (i32()* @foo to i32*)
|
|
|
|
|
; CHECK: Load from block address
|
2015-02-27 22:17:42 +01:00
|
|
|
%lb = load i32, i32* bitcast (i8* blockaddress(@foo, %next) to i32*)
|
2010-04-30 21:05:00 +02:00
|
|
|
; CHECK: Call to block address
|
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 01:24:18 +02:00
|
|
|
call void() bitcast (i8* blockaddress(@foo, %next) to void()*)()
|
2010-05-27 00:21:25 +02:00
|
|
|
; CHECK: Undefined behavior: Null pointer dereference
|
|
|
|
|
call void @llvm.stackrestore(i8* null)
|
2010-05-28 23:43:57 +02:00
|
|
|
; CHECK: Undefined behavior: Null pointer dereference
|
|
|
|
|
call void @has_sret(i8* null)
|
|
|
|
|
; CHECK: Unusual: noalias argument aliases another argument
|
|
|
|
|
call void @has_noaliases(i32* @CG, i32* @CG)
|
|
|
|
|
; CHECK: Call argument count mismatches callee argument count
|
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 01:24:18 +02:00
|
|
|
call void (i32, i32) bitcast (void (i32)* @one_arg to void (i32, i32)*)(i32 0, i32 0)
|
2010-05-28 23:43:57 +02:00
|
|
|
; CHECK: Call argument count mismatches callee argument count
|
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 01:24:18 +02:00
|
|
|
call void () bitcast (void (i32)* @one_arg to void ()*)()
|
2010-05-28 23:43:57 +02:00
|
|
|
; CHECK: Call argument type mismatches callee parameter type
|
[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction
See r230786 and r230794 for similar changes to gep and load
respectively.
Call is a bit different because it often doesn't have a single explicit
type - usually the type is deduced from the arguments, and just the
return type is explicit. In those cases there's no need to change the
IR.
When that's not the case, the IR usually contains the pointer type of
the first operand - but since typed pointers are going away, that
representation is insufficient so I'm just stripping the "pointerness"
of the explicit type away.
This does make the IR a bit weird - it /sort of/ reads like the type of
the first operand: "call void () %x(" but %x is actually of type "void
()*" and will eventually be just of type "ptr". But this seems not too
bad and I don't think it would benefit from repeating the type
("void (), void () * %x(" and then eventually "void (), ptr %x(") as has
been done with gep and load.
This also has a side benefit: since the explicit type is no longer a
pointer, there's no ambiguity between an explicit type and a function
that returns a function pointer. Previously this case needed an explicit
type (eg: a function returning a void() function was written as
"call void () () * @x(" rather than "call void () * @x(" because of the
ambiguity between a function returning a pointer to a void() function
and a function returning void).
No ambiguity means even function pointer return types can just be
written alone, without writing the whole function's type.
This leaves /only/ the varargs case where the explicit type is required.
Given the special type syntax in call instructions, the regex-fu used
for migration was a bit more involved in its own unique way (as every
one of these is) so here it is. Use it in conjunction with the apply.sh
script and associated find/xargs commands I've provided in rr230786 to
migrate your out of tree tests. Do let me know if any of this doesn't
cover your cases & we can iterate on a more general script/regexes to
help others with out of tree tests.
About 9 test cases couldn't be automatically migrated - half of those
were functions returning function pointers, where I just had to manually
delete the function argument types now that we didn't need an explicit
function type there. The other half were typedefs of function types used
in calls - just had to manually drop the * from those.
import fileinput
import sys
import re
pat = re.compile(r'((?:=|:|^|\s)call\s(?:[^@]*?))(\s*$|\s*(?:(?:\[\[[a-zA-Z0-9_]+\]\]|[@%](?:(")?[\\\?@a-zA-Z0-9_.]*?(?(3)"|)|{{.*}}))(?:\(|$)|undef|inttoptr|bitcast|null|asm).*$)')
addrspace_end = re.compile(r"addrspace\(\d+\)\s*\*$")
func_end = re.compile("(?:void.*|\)\s*)\*$")
def conv(match, line):
if not match or re.search(addrspace_end, match.group(1)) or not re.search(func_end, match.group(1)):
return line
return line[:match.start()] + match.group(1)[:match.group(1).rfind('*')].rstrip() + match.group(2) + line[match.end():]
for line in sys.stdin:
sys.stdout.write(conv(re.search(pat, line), line))
llvm-svn: 235145
2015-04-17 01:24:18 +02:00
|
|
|
call void (float) bitcast (void (i32)* @one_arg to void (float)*)(float 0.0)
|
2010-04-30 21:05:00 +02:00
|
|
|
|
2010-05-28 19:44:00 +02:00
|
|
|
; CHECK: Write to read-only memory
|
|
|
|
|
call void @llvm.memcpy.p0i8.p0i8.i64(i8* bitcast (i32* @CG to i8*), i8* bitcast (i32* @CG to i8*), i64 1, i32 1, i1 0)
|
|
|
|
|
|
2012-09-26 09:45:36 +02:00
|
|
|
; CHECK: Undefined behavior: Buffer overflow
|
|
|
|
|
%wider = bitcast i8* %buf to i16*
|
|
|
|
|
store i16 0, i16* %wider
|
|
|
|
|
; CHECK: Undefined behavior: Buffer overflow
|
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-27 20:29:02 +01:00
|
|
|
%inner = getelementptr {i8, i8}, {i8, i8}* %buf2, i32 0, i32 1
|
2012-09-26 09:45:36 +02:00
|
|
|
%wider2 = bitcast i8* %inner to i16*
|
|
|
|
|
store i16 0, i16* %wider2
|
|
|
|
|
; CHECK: Undefined behavior: Buffer overflow
|
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-27 20:29:02 +01:00
|
|
|
%before = getelementptr i8, i8* %buf, i32 -1
|
2012-09-26 09:45:36 +02:00
|
|
|
%wider3 = bitcast i8* %before to i16*
|
|
|
|
|
store i16 0, i16* %wider3
|
|
|
|
|
|
2010-04-08 20:47:09 +02:00
|
|
|
br label %next
|
|
|
|
|
|
|
|
|
|
next:
|
|
|
|
|
; CHECK: Static alloca outside of entry block
|
|
|
|
|
%a = alloca i32
|
|
|
|
|
; CHECK: Return statement in function with noreturn attribute
|
|
|
|
|
ret i32 0
|
2010-04-09 03:39:53 +02:00
|
|
|
|
|
|
|
|
foo:
|
2012-09-30 09:30:10 +02:00
|
|
|
; CHECK-NOT: Undefined behavior: Buffer overflow
|
|
|
|
|
; CHECK-NOT: Memory reference address is misaligned
|
|
|
|
|
%e = bitcast i8* @E to i64*
|
|
|
|
|
store i64 0, i64* %e
|
2010-04-09 03:39:53 +02:00
|
|
|
%z = add i32 0, 0
|
|
|
|
|
; CHECK: unreachable immediately preceded by instruction without side effects
|
|
|
|
|
unreachable
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; CHECK: Unnamed function with non-local linkage
|
|
|
|
|
define void @0() nounwind {
|
|
|
|
|
ret void
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; CHECK: va_start called in a non-varargs function
|
|
|
|
|
declare void @llvm.va_start(i8*)
|
|
|
|
|
define void @not_vararg(i8* %p) nounwind {
|
|
|
|
|
call void @llvm.va_start(i8* %p)
|
|
|
|
|
ret void
|
2010-04-08 20:47:09 +02:00
|
|
|
}
|
2010-04-30 21:05:00 +02:00
|
|
|
|
2010-05-26 23:46:36 +02:00
|
|
|
; CHECK: Undefined behavior: Branch to non-blockaddress
|
2010-04-30 21:05:00 +02:00
|
|
|
define void @use_indbr() {
|
|
|
|
|
indirectbr i8* bitcast (i32()* @foo to i8*), [label %block]
|
|
|
|
|
block:
|
|
|
|
|
unreachable
|
|
|
|
|
}
|
2010-05-26 23:46:36 +02:00
|
|
|
|
2010-05-28 18:34:49 +02:00
|
|
|
; CHECK: Undefined behavior: Call with "tail" keyword references alloca
|
2010-05-26 23:46:36 +02:00
|
|
|
declare void @tailcallee(i8*)
|
|
|
|
|
define void @use_tail(i8* %valist) {
|
|
|
|
|
%t = alloca i8
|
|
|
|
|
tail call void @tailcallee(i8* %t)
|
|
|
|
|
ret void
|
|
|
|
|
}
|
2010-05-28 06:33:42 +02:00
|
|
|
|
2010-05-28 18:34:49 +02:00
|
|
|
; CHECK: Unusual: Returning alloca value
|
2010-05-28 06:33:42 +02:00
|
|
|
define i8* @return_local(i32 %n, i32 %m) {
|
|
|
|
|
%t = alloca i8, i32 %n
|
[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
llvm-svn: 230786
2015-02-27 20:29:02 +01:00
|
|
|
%s = getelementptr i8, i8* %t, i32 %m
|
2010-05-28 06:33:42 +02:00
|
|
|
ret i8* %s
|
|
|
|
|
}
|
2010-05-28 18:21:24 +02:00
|
|
|
|
2010-05-28 18:34:49 +02:00
|
|
|
; CHECK: Unusual: Returning alloca value
|
2010-05-28 18:21:24 +02:00
|
|
|
define i32* @return_obscured_local() {
|
|
|
|
|
entry:
|
|
|
|
|
%retval = alloca i32*
|
|
|
|
|
%x = alloca i32
|
|
|
|
|
store i32* %x, i32** %retval
|
|
|
|
|
br label %next
|
|
|
|
|
next:
|
2015-02-27 22:17:42 +01:00
|
|
|
%t0 = load i32*, i32** %retval
|
2010-05-28 18:21:24 +02:00
|
|
|
%t1 = insertvalue { i32, i32, i32* } zeroinitializer, i32* %t0, 2
|
|
|
|
|
%t2 = extractvalue { i32, i32, i32* } %t1, 2
|
|
|
|
|
br label %exit
|
|
|
|
|
exit:
|
|
|
|
|
%t3 = phi i32* [ %t2, %next ]
|
|
|
|
|
%t4 = bitcast i32* %t3 to i32*
|
|
|
|
|
%t5 = ptrtoint i32* %t4 to i64
|
|
|
|
|
%t6 = add i64 %t5, 0
|
|
|
|
|
%t7 = inttoptr i64 %t6 to i32*
|
|
|
|
|
ret i32* %t7
|
|
|
|
|
}
|
2010-05-28 18:45:33 +02:00
|
|
|
|
|
|
|
|
; CHECK: Undefined behavior: Undef pointer dereference
|
|
|
|
|
define i32* @self_reference() {
|
|
|
|
|
entry:
|
|
|
|
|
unreachable
|
|
|
|
|
exit:
|
|
|
|
|
%t3 = phi i32* [ %t4, %exit ]
|
|
|
|
|
%t4 = bitcast i32* %t3 to i32*
|
2015-02-27 22:17:42 +01:00
|
|
|
%x = load volatile i32, i32* %t3
|
2010-05-28 18:45:33 +02:00
|
|
|
br label %exit
|
|
|
|
|
}
|
2010-07-12 20:02:04 +02:00
|
|
|
|
|
|
|
|
; CHECK: Call return type mismatches callee return type
|
|
|
|
|
%struct = type { double, double }
|
|
|
|
|
declare i32 @nonstruct_callee() nounwind
|
|
|
|
|
define void @struct_caller() nounwind {
|
|
|
|
|
entry:
|
|
|
|
|
call %struct bitcast (i32 ()* @foo to %struct ()*)()
|
2010-08-03 01:06:43 +02:00
|
|
|
|
|
|
|
|
; CHECK: Undefined behavior: indirectbr with no destinations
|
|
|
|
|
indirectbr i8* null, []
|
2010-07-12 20:02:04 +02:00
|
|
|
}
|
