2012-12-12 20:29:35 +01:00
|
|
|
; RUN: llc -mcpu=pwr7 -O0 -relocation-model=pic < %s | FileCheck %s
|
|
|
|
|
|
|
|
|
|
; Test correct assembly code generation for thread-local storage using
|
|
|
|
|
; the local dynamic model.
|
|
|
|
|
|
|
|
|
|
target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
|
|
|
|
|
target triple = "powerpc64-unknown-linux-gnu"
|
|
|
|
|
|
|
|
|
|
@a = hidden thread_local global i32 0, align 4
|
|
|
|
|
|
|
|
|
|
define signext i32 @main() nounwind {
|
|
|
|
|
entry:
|
|
|
|
|
%retval = alloca i32, align 4
|
|
|
|
|
store i32 0, i32* %retval
|
|
|
|
|
%0 = load i32* @a, align 4
|
|
|
|
|
ret i32 %0
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
; CHECK: addis [[REG:[0-9]+]], 2, a@got@tlsld@ha
|
|
|
|
|
; CHECK-NEXT: addi 3, [[REG]], a@got@tlsld@l
|
[PowerPC] Revert r185476 and fix up TLS variant kinds
In the commit message to r185476 I wrote:
>The PowerPC-specific modifiers VK_PPC_TLSGD and VK_PPC_TLSLD
>correspond exactly to the generic modifiers VK_TLSGD and VK_TLSLD.
>This causes some confusion with the asm parser, since VK_PPC_TLSGD
>is output as @tlsgd, which is then read back in as VK_TLSGD.
>
>To avoid this confusion, this patch removes the PowerPC-specific
>modifiers and uses the generic modifiers throughout. (The only
>drawback is that the generic modifiers are printed in upper case
>while the usual convention on PowerPC is to use lower-case modifiers.
>But this is just a cosmetic issue.)
This was unfortunately incorrect, there is is fact another,
serious drawback to using the default VK_TLSLD/VK_TLSGD
variant kinds: using these causes ELFObjectWriter::RelocNeedsGOT
to return true, which in turn causes the ELFObjectWriter to emit
an undefined reference to _GLOBAL_OFFSET_TABLE_.
This is a problem on powerpc64, because it uses the TOC instead
of the GOT, and the linker does not provide _GLOBAL_OFFSET_TABLE_,
so the symbol remains undefined. This means shared libraries
using TLS built with the integrated assembler are currently
broken.
While the whole RelocNeedsGOT / _GLOBAL_OFFSET_TABLE_ situation
probably ought to be properly fixed at some point, for now I'm
simply reverting the r185476 commit. Now this in turn exposes
the breakage of handling @tlsgd/@tlsld in the asm parser that
this check-in was originally intended to fix.
To avoid this regression, I'm also adding a different fix for
this problem: while common code now parses @tlsgd as VK_TLSGD,
a special hack in the asm parser translates this code to the
platform-specific VK_PPC_TLSGD that the back-end now expects.
While this is not really pretty, it's self-contained and
shouldn't hurt anything else for now. One the underlying
problem is fixed, this hack can be reverted again.
llvm-svn: 185945
2013-07-09 18:41:09 +02:00
|
|
|
; CHECK: bl __tls_get_addr(a@tlsld)
|
2012-12-12 20:29:35 +01:00
|
|
|
; CHECK-NEXT: nop
|
2013-03-27 03:40:14 +01:00
|
|
|
; CHECK: addis [[REG2:[0-9]+]], 3, a@dtprel@ha
|
2012-12-12 20:29:35 +01:00
|
|
|
; CHECK-NEXT: addi {{[0-9]+}}, [[REG2]], a@dtprel@l
|
