2003-12-18 14:06:04 +01:00
|
|
|
//===-- TwoAddressInstructionPass.cpp - Two-Address instruction pass ------===//
|
|
|
|
//
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
//
|
|
|
|
// This file was developed by the LLVM research group and is distributed under
|
|
|
|
// the University of Illinois Open Source License. See LICENSE.TXT for details.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
2004-01-05 00:09:24 +01:00
|
|
|
// This file implements the TwoAddress instruction pass which is used
|
|
|
|
// by most register allocators. Two-Address instructions are rewritten
|
|
|
|
// from:
|
|
|
|
//
|
|
|
|
// A = B op C
|
|
|
|
//
|
|
|
|
// to:
|
|
|
|
//
|
|
|
|
// A = B
|
2004-02-04 23:17:40 +01:00
|
|
|
// A op= C
|
2003-12-18 14:06:04 +01:00
|
|
|
//
|
2004-02-04 23:17:40 +01:00
|
|
|
// Note that if a register allocator chooses to use this pass, that it
|
|
|
|
// has to be capable of handling the non-SSA nature of these rewritten
|
|
|
|
// virtual registers.
|
|
|
|
//
|
|
|
|
// It is also worth noting that the duplicate operand of the two
|
|
|
|
// address instruction is removed.
|
2004-01-31 22:07:15 +01:00
|
|
|
//
|
2003-12-18 14:06:04 +01:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#define DEBUG_TYPE "twoaddrinstr"
|
2004-01-31 22:07:15 +01:00
|
|
|
#include "llvm/CodeGen/Passes.h"
|
2004-07-22 01:17:57 +02:00
|
|
|
#include "llvm/Function.h"
|
2003-12-18 14:06:04 +01:00
|
|
|
#include "llvm/CodeGen/LiveVariables.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
|
|
#include "llvm/CodeGen/SSARegMap.h"
|
|
|
|
#include "llvm/Target/MRegisterInfo.h"
|
|
|
|
#include "llvm/Target/TargetInstrInfo.h"
|
|
|
|
#include "llvm/Target/TargetMachine.h"
|
2004-09-02 00:55:40 +02:00
|
|
|
#include "llvm/Support/Debug.h"
|
2006-08-27 14:54:02 +02:00
|
|
|
#include "llvm/Support/Compiler.h"
|
2004-09-02 00:55:40 +02:00
|
|
|
#include "llvm/ADT/Statistic.h"
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
2006-01-23 00:41:00 +01:00
|
|
|
#include <iostream>
|
2003-12-18 14:06:04 +01:00
|
|
|
using namespace llvm;
|
|
|
|
|
|
|
|
namespace {
|
2006-07-20 19:28:38 +02:00
|
|
|
static Statistic<> NumTwoAddressInstrs("twoaddressinstruction",
|
2004-07-22 17:26:23 +02:00
|
|
|
"Number of two-address instructions");
|
2006-07-20 19:28:38 +02:00
|
|
|
static Statistic<> NumCommuted("twoaddressinstruction",
|
2005-10-26 20:41:41 +02:00
|
|
|
"Number of instructions commuted to coalesce");
|
2006-07-20 19:28:38 +02:00
|
|
|
static Statistic<> NumConvertedTo3Addr("twoaddressinstruction",
|
Make the 2-address instruction lowering pass smarter in two ways:
1. If we are two-addressing a commutable instruction and the LHS is not the
last use of the variable, see if the instruction is the last use of the
RHS. If so, commute the instruction, allowing us to avoid a
register-register copy in many cases for common instructions like ADD, OR,
AND, etc on X86.
2. If #1 doesn't hold, and if this is an instruction that also existing in
3-address form, promote the instruction to a 3-address instruction to
avoid the register-register copy. We can do this for several common
instructions in X86, including ADDrr, INC, DEC, etc.
This patch implements test/Regression/CodeGen/X86/commute-two-addr.ll,
overlap-add.ll, and overlap-shift.ll when I check in the X86 support for it.
llvm-svn: 19245
2005-01-02 03:34:12 +01:00
|
|
|
"Number of instructions promoted to 3-address");
|
2004-01-31 22:07:15 +01:00
|
|
|
|
2006-06-29 00:17:39 +02:00
|
|
|
struct VISIBILITY_HIDDEN TwoAddressInstructionPass
|
|
|
|
: public MachineFunctionPass {
|
2004-07-22 17:26:23 +02:00
|
|
|
virtual void getAnalysisUsage(AnalysisUsage &AU) const;
|
2003-12-18 23:40:24 +01:00
|
|
|
|
2004-07-22 17:26:23 +02:00
|
|
|
/// runOnMachineFunction - pass entry point
|
|
|
|
bool runOnMachineFunction(MachineFunction&);
|
|
|
|
};
|
2003-12-18 23:40:24 +01:00
|
|
|
|
2005-04-22 00:36:52 +02:00
|
|
|
RegisterPass<TwoAddressInstructionPass>
|
2004-07-22 17:26:23 +02:00
|
|
|
X("twoaddressinstruction", "Two-Address instruction pass");
|
2006-05-24 19:04:05 +02:00
|
|
|
}
|
2003-12-18 14:06:04 +01:00
|
|
|
|
2003-12-18 23:40:24 +01:00
|
|
|
const PassInfo *llvm::TwoAddressInstructionPassID = X.getPassInfo();
|
|
|
|
|
2004-07-22 17:26:23 +02:00
|
|
|
void TwoAddressInstructionPass::getAnalysisUsage(AnalysisUsage &AU) const {
|
Make the 2-address instruction lowering pass smarter in two ways:
1. If we are two-addressing a commutable instruction and the LHS is not the
last use of the variable, see if the instruction is the last use of the
RHS. If so, commute the instruction, allowing us to avoid a
register-register copy in many cases for common instructions like ADD, OR,
AND, etc on X86.
2. If #1 doesn't hold, and if this is an instruction that also existing in
3-address form, promote the instruction to a 3-address instruction to
avoid the register-register copy. We can do this for several common
instructions in X86, including ADDrr, INC, DEC, etc.
This patch implements test/Regression/CodeGen/X86/commute-two-addr.ll,
overlap-add.ll, and overlap-shift.ll when I check in the X86 support for it.
llvm-svn: 19245
2005-01-02 03:34:12 +01:00
|
|
|
AU.addRequired<LiveVariables>();
|
2004-07-22 17:26:23 +02:00
|
|
|
AU.addPreserved<LiveVariables>();
|
|
|
|
AU.addPreservedID(PHIEliminationID);
|
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
2003-12-18 14:06:04 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/// runOnMachineFunction - Reduce two-address instructions to two
|
2004-01-31 22:14:04 +01:00
|
|
|
/// operands.
|
2003-12-18 14:06:04 +01:00
|
|
|
///
|
2004-01-31 22:14:04 +01:00
|
|
|
bool TwoAddressInstructionPass::runOnMachineFunction(MachineFunction &MF) {
|
2004-07-22 17:26:23 +02:00
|
|
|
DEBUG(std::cerr << "Machine Function\n");
|
|
|
|
const TargetMachine &TM = MF.getTarget();
|
|
|
|
const MRegisterInfo &MRI = *TM.getRegisterInfo();
|
|
|
|
const TargetInstrInfo &TII = *TM.getInstrInfo();
|
Make the 2-address instruction lowering pass smarter in two ways:
1. If we are two-addressing a commutable instruction and the LHS is not the
last use of the variable, see if the instruction is the last use of the
RHS. If so, commute the instruction, allowing us to avoid a
register-register copy in many cases for common instructions like ADD, OR,
AND, etc on X86.
2. If #1 doesn't hold, and if this is an instruction that also existing in
3-address form, promote the instruction to a 3-address instruction to
avoid the register-register copy. We can do this for several common
instructions in X86, including ADDrr, INC, DEC, etc.
This patch implements test/Regression/CodeGen/X86/commute-two-addr.ll,
overlap-add.ll, and overlap-shift.ll when I check in the X86 support for it.
llvm-svn: 19245
2005-01-02 03:34:12 +01:00
|
|
|
LiveVariables &LV = getAnalysis<LiveVariables>();
|
2004-07-22 17:26:23 +02:00
|
|
|
|
|
|
|
bool MadeChange = false;
|
|
|
|
|
|
|
|
DEBUG(std::cerr << "********** REWRITING TWO-ADDR INSTRS **********\n");
|
|
|
|
DEBUG(std::cerr << "********** Function: "
|
|
|
|
<< MF.getFunction()->getName() << '\n');
|
|
|
|
|
|
|
|
for (MachineFunction::iterator mbbi = MF.begin(), mbbe = MF.end();
|
|
|
|
mbbi != mbbe; ++mbbi) {
|
|
|
|
for (MachineBasicBlock::iterator mi = mbbi->begin(), me = mbbi->end();
|
|
|
|
mi != me; ++mi) {
|
|
|
|
unsigned opcode = mi->getOpcode();
|
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
bool FirstTied = true;
|
|
|
|
for (unsigned si = 1, e = TII.getNumOperands(opcode); si < e; ++si) {
|
|
|
|
int ti = TII.getOperandConstraint(opcode, si, TargetInstrInfo::TIED_TO);
|
|
|
|
if (ti == -1)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (FirstTied) {
|
|
|
|
++NumTwoAddressInstrs;
|
|
|
|
DEBUG(std::cerr << '\t'; mi->print(std::cerr, &TM));
|
|
|
|
}
|
|
|
|
FirstTied = false;
|
|
|
|
|
|
|
|
assert(mi->getOperand(si).isRegister() && mi->getOperand(si).getReg() &&
|
|
|
|
mi->getOperand(si).isUse() && "two address instruction invalid");
|
|
|
|
|
|
|
|
// if the two operands are the same we just remove the use
|
|
|
|
// and mark the def as def&use, otherwise we have to insert a copy.
|
|
|
|
if (mi->getOperand(ti).getReg() != mi->getOperand(si).getReg()) {
|
|
|
|
// rewrite:
|
|
|
|
// a = b op c
|
|
|
|
// to:
|
|
|
|
// a = b
|
|
|
|
// a = a op c
|
|
|
|
unsigned regA = mi->getOperand(ti).getReg();
|
|
|
|
unsigned regB = mi->getOperand(si).getReg();
|
|
|
|
|
|
|
|
assert(MRegisterInfo::isVirtualRegister(regA) &&
|
|
|
|
MRegisterInfo::isVirtualRegister(regB) &&
|
|
|
|
"cannot update physical register live information");
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2004-07-22 01:17:57 +02:00
|
|
|
#ifndef NDEBUG
|
2006-11-02 00:06:55 +01:00
|
|
|
// First, verify that we don't have a use of a in the instruction (a =
|
|
|
|
// b + a for example) because our transformation will not work. This
|
|
|
|
// should never occur because we are in SSA form.
|
|
|
|
for (unsigned i = 0; i != mi->getNumOperands(); ++i)
|
|
|
|
assert((int)i == ti ||
|
|
|
|
!mi->getOperand(i).isRegister() ||
|
|
|
|
mi->getOperand(i).getReg() != regA);
|
2004-07-22 01:17:57 +02:00
|
|
|
#endif
|
2004-02-04 23:17:40 +01:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
// If this instruction is not the killing user of B, see if we can
|
|
|
|
// rearrange the code to make it so. Making it the killing user will
|
|
|
|
// allow us to coalesce A and B together, eliminating the copy we are
|
|
|
|
// about to insert.
|
|
|
|
if (!LV.KillsRegister(mi, regB)) {
|
|
|
|
const TargetInstrDescriptor &TID = TII.get(opcode);
|
|
|
|
|
|
|
|
// If this instruction is commutative, check to see if C dies. If
|
|
|
|
// so, swap the B and C operands. This makes the live ranges of A
|
|
|
|
// and C joinable.
|
|
|
|
// FIXME: This code also works for A := B op C instructions.
|
|
|
|
if ((TID.Flags & M_COMMUTABLE) && mi->getNumOperands() == 3) {
|
|
|
|
assert(mi->getOperand(3-si).isRegister() &&
|
|
|
|
"Not a proper commutative instruction!");
|
|
|
|
unsigned regC = mi->getOperand(3-si).getReg();
|
|
|
|
if (LV.KillsRegister(mi, regC)) {
|
|
|
|
DEBUG(std::cerr << "2addr: COMMUTING : " << *mi);
|
|
|
|
MachineInstr *NewMI = TII.commuteInstruction(mi);
|
|
|
|
if (NewMI == 0) {
|
|
|
|
DEBUG(std::cerr << "2addr: COMMUTING FAILED!\n");
|
|
|
|
} else {
|
|
|
|
DEBUG(std::cerr << "2addr: COMMUTED TO: " << *NewMI);
|
|
|
|
// If the instruction changed to commute it, update livevar.
|
|
|
|
if (NewMI != mi) {
|
|
|
|
LV.instructionChanged(mi, NewMI); // Update live variables
|
|
|
|
mbbi->insert(mi, NewMI); // Insert the new inst
|
|
|
|
mbbi->erase(mi); // Nuke the old inst.
|
|
|
|
mi = NewMI;
|
|
|
|
}
|
|
|
|
|
|
|
|
++NumCommuted;
|
|
|
|
regB = regC;
|
|
|
|
goto InstructionRearranged;
|
2005-04-22 00:36:52 +02:00
|
|
|
}
|
2005-01-19 08:08:42 +01:00
|
|
|
}
|
Make the 2-address instruction lowering pass smarter in two ways:
1. If we are two-addressing a commutable instruction and the LHS is not the
last use of the variable, see if the instruction is the last use of the
RHS. If so, commute the instruction, allowing us to avoid a
register-register copy in many cases for common instructions like ADD, OR,
AND, etc on X86.
2. If #1 doesn't hold, and if this is an instruction that also existing in
3-address form, promote the instruction to a 3-address instruction to
avoid the register-register copy. We can do this for several common
instructions in X86, including ADDrr, INC, DEC, etc.
This patch implements test/Regression/CodeGen/X86/commute-two-addr.ll,
overlap-add.ll, and overlap-shift.ll when I check in the X86 support for it.
llvm-svn: 19245
2005-01-02 03:34:12 +01:00
|
|
|
}
|
2006-11-02 00:06:55 +01:00
|
|
|
|
|
|
|
// If this instruction is potentially convertible to a true
|
|
|
|
// three-address instruction,
|
|
|
|
if (TID.Flags & M_CONVERTIBLE_TO_3_ADDR)
|
|
|
|
// FIXME: This assumes there are no more operands which are tied
|
|
|
|
// to another register.
|
|
|
|
#ifndef NDEBUG
|
|
|
|
for (unsigned i = si+1, e = TII.getNumOperands(opcode); i < e; ++i)
|
|
|
|
assert(TII.getOperandConstraint(opcode, i,
|
|
|
|
TargetInstrInfo::TIED_TO) == -1);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
if (MachineInstr *New = TII.convertToThreeAddress(mi)) {
|
|
|
|
DEBUG(std::cerr << "2addr: CONVERTING 2-ADDR: " << *mi);
|
|
|
|
DEBUG(std::cerr << "2addr: TO 3-ADDR: " << *New);
|
|
|
|
LV.instructionChanged(mi, New); // Update live variables
|
|
|
|
mbbi->insert(mi, New); // Insert the new inst
|
|
|
|
mbbi->erase(mi); // Nuke the old inst.
|
|
|
|
mi = New;
|
|
|
|
++NumConvertedTo3Addr;
|
|
|
|
// Done with this instruction.
|
|
|
|
break;
|
|
|
|
}
|
Make the 2-address instruction lowering pass smarter in two ways:
1. If we are two-addressing a commutable instruction and the LHS is not the
last use of the variable, see if the instruction is the last use of the
RHS. If so, commute the instruction, allowing us to avoid a
register-register copy in many cases for common instructions like ADD, OR,
AND, etc on X86.
2. If #1 doesn't hold, and if this is an instruction that also existing in
3-address form, promote the instruction to a 3-address instruction to
avoid the register-register copy. We can do this for several common
instructions in X86, including ADDrr, INC, DEC, etc.
This patch implements test/Regression/CodeGen/X86/commute-two-addr.ll,
overlap-add.ll, and overlap-shift.ll when I check in the X86 support for it.
llvm-svn: 19245
2005-01-02 03:34:12 +01:00
|
|
|
}
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
InstructionRearranged:
|
|
|
|
const TargetRegisterClass* rc = MF.getSSARegMap()->getRegClass(regA);
|
|
|
|
MRI.copyRegToReg(*mbbi, mi, regA, regB, rc);
|
|
|
|
|
|
|
|
MachineBasicBlock::iterator prevMi = prior(mi);
|
|
|
|
DEBUG(std::cerr << "\t\tprepend:\t"; prevMi->print(std::cerr, &TM));
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
// Update live variables for regA
|
|
|
|
LiveVariables::VarInfo& varInfo = LV.getVarInfo(regA);
|
|
|
|
varInfo.DefInst = prevMi;
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
// update live variables for regB
|
|
|
|
if (LV.removeVirtualRegisterKilled(regB, mbbi, mi))
|
|
|
|
LV.addVirtualRegisterKilled(regB, prevMi);
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
if (LV.removeVirtualRegisterDead(regB, mbbi, mi))
|
|
|
|
LV.addVirtualRegisterDead(regB, prevMi);
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
// replace all occurences of regB with regA
|
|
|
|
for (unsigned i = 0, e = mi->getNumOperands(); i != e; ++i) {
|
|
|
|
if (mi->getOperand(i).isRegister() &&
|
|
|
|
mi->getOperand(i).getReg() == regB)
|
|
|
|
mi->getOperand(i).setReg(regA);
|
|
|
|
}
|
2004-07-22 17:26:23 +02:00
|
|
|
}
|
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
assert(mi->getOperand(ti).isDef() && mi->getOperand(si).isUse());
|
|
|
|
mi->getOperand(ti).setReg(mi->getOperand(si).getReg());
|
|
|
|
MadeChange = true;
|
2004-07-22 17:26:23 +02:00
|
|
|
|
2006-11-02 00:06:55 +01:00
|
|
|
DEBUG(std::cerr << "\t\trewrite to:\t"; mi->print(std::cerr, &TM));
|
|
|
|
}
|
2003-12-18 14:06:04 +01:00
|
|
|
}
|
2004-07-22 17:26:23 +02:00
|
|
|
}
|
2003-12-18 14:06:04 +01:00
|
|
|
|
2004-07-22 17:26:23 +02:00
|
|
|
return MadeChange;
|
2003-12-18 14:06:04 +01:00
|
|
|
}
|