RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

Remove code that's almost always dead, and harmful if not.

Browse Source 
lit's util.which() would check if the passed-in path existed directly,
and if so return it as-is.  This is never the case when running llvm's, clang's,
or lld's tests normally.  But when running `./llvm-lit path/to/clang/test`
with a cwd of llvm-build/bin, this if would detect that clang exists at path
'clang' and return 'clang' as the discovered clang binary -- and then lit would
use the " clang " -> "*** Do not use 'clang' in tests, use '%clang'. ***"
substitution to replace that with a broken test.  By removing this early
return, lit ends up with the usual absolute path and everything works even
in this uncommon case.

llvm-svn: 330672
This commit is contained in:
Nico Weber 2018-04-24 01:05:04 +00:00
parent db543185c7
commit 00c5136820
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
utils/lit/lit/util.py
View File

@ -193,10 +193,6 @@ def which(command, paths=None):
if paths is None: if paths is None:
paths = os.environ.get('PATH', '') paths = os.environ.get('PATH', '')
# Check for absolute match first.
if os.path.isfile(command):
return os.path.normpath(command)
# Would be nice if Python had a lib function for this. # Would be nice if Python had a lib function for this.
if not paths: if not paths:
paths = os.defpath paths = os.defpath