RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-25 20:23:11 +01:00
Code Issues Projects Releases Wiki Activity

[ThinLTO] Clear dllimport when setting dso_local.

Browse Source 
This is PR36686.

If a user of a library is LTOed with that library we take the
opportunity to set dso_local, but we don't clear dllimport, which
creates an invalid IR.

llvm-svn: 327408
This commit is contained in:
Rafael Espindola 2018-03-13 15:24:51 +00:00
parent 8dd53cb24b
commit 0107e8f243
3 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Transforms/Utils/FunctionImportUtils.cpp
View File

@ -206,8 +206,11 @@ void FunctionImportGlobalProcessing::processGlobalForThinLTO(GlobalValue &GV) {
// definition.
if (GV.hasName()) {
ValueInfo VI = ImportIndex.getValueInfo(GV.getGUID());
if (VI && VI.isDSOLocal())
if (VI && VI.isDSOLocal()) {
GV.setDSOLocal(true);
if (GV.hasDLLImportStorageClass())
GV.setDLLStorageClass(GlobalValue::DefaultStorageClass);
}
}
bool DoPromote = false;

5
test/ThinLTO/X86/Inputs/dsolocal_dllimport.ll Normal file
View File

@ -0,0 +1,5 @@
target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-msvc19.11.0"
define dso_local dllexport i32 @foo() {
ret i32 42
}

16
test/ThinLTO/X86/dsolocal_dllimport.ll Normal file
View File

@ -0,0 +1,16 @@
; RUN: opt -module-summary %s -o %t1.bc
; RUN: opt -module-summary %S/Inputs/dsolocal_dllimport.ll -o %t2.bc
; RUN: llvm-lto2 run %t1.bc %t2.bc -o %t -r=%t1.bc,bar,px -r=%t1.bc,__imp_foo, -r=%t2.bc,foo -save-temps
; RUN: llvm-dis < %t.1.3.import.bc | FileCheck %s
; If a user (dllimport) is LTOed with a library, check that we replace dllimport with dso_local.
; CHECK: declare dso_local void @foo()
target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-msvc19.11.0"
define void @bar() {
call void @foo()
ret void
}
declare dllimport void @foo()