1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 02:52:53 +02:00

[DA] Don't propagate from unreachable blocks

Summary: Fixes crash that could occur when a divergent terminator has an unreachable parent.

Reviewers: rampitec, nhaehnle, arsenm

Subscribers: jvesely, wdng, hiraditya, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73323
This commit is contained in:
Austin Kerbow 2020-01-23 19:49:20 -08:00
parent 988d443521
commit 06d4a892b3
2 changed files with 21 additions and 0 deletions

View File

@ -301,6 +301,10 @@ void DivergenceAnalysis::propagateBranchDivergence(const Instruction &Term) {
markDivergent(Term);
// Don't propagate divergence from unreachable blocks.
if (!DT.isReachableFromEntry(Term.getParent()))
return;
const auto *BranchLoop = LI.getLoopFor(Term.getParent());
// whether there is a divergent loop exit from BranchLoop (if any)

View File

@ -0,0 +1,17 @@
; RUN: opt %s -mtriple amdgcn-- -analyze -divergence -use-gpu-divergence-analysis | FileCheck %s
; CHECK: DIVERGENT: %tmp = cmpxchg volatile
define amdgpu_kernel void @unreachable_loop(i32 %tidx) #0 {
entry:
unreachable
unreachable_loop: ; preds = %do.body.i, %if.then11
%tmp = cmpxchg volatile i32 addrspace(1)* null, i32 0, i32 0 seq_cst seq_cst
%cmp.i = extractvalue { i32, i1 } %tmp, 1
br i1 %cmp.i, label %unreachable_loop, label %end
end: ; preds = %do.body.i51, %atomicAdd_g_f.exit
unreachable
}
attributes #0 = { norecurse nounwind }