1
0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 02:52:53 +02:00

several improvements suggested by Dan, thanks!

llvm-svn: 43237
This commit is contained in:
Chris Lattner 2007-10-23 04:27:44 +00:00
parent 252d9ddb4d
commit 0705dd275a
2 changed files with 20 additions and 9 deletions

View File

@ -65,7 +65,7 @@ public:
class NumberExprAST : public ExprAST {
double Val;
public:
NumberExprAST(double val) : Val(val) {}
explicit NumberExprAST(double val) : Val(val) {}
};
</pre>
</div>
@ -87,7 +87,7 @@ in the basic form of the Kaleidoscope language.
class VariableExprAST : public ExprAST {
std::string Name;
public:
VariableExprAST(const std::string &amp;name) : Name(name) {}
explicit VariableExprAST(const std::string &amp;name) : Name(name) {}
};
/// BinaryExprAST - Expression class for a binary operator.
@ -850,14 +850,14 @@ public:
class NumberExprAST : public ExprAST {
double Val;
public:
NumberExprAST(double val) : Val(val) {}
explicit NumberExprAST(double val) : Val(val) {}
};
/// VariableExprAST - Expression class for referencing a variable, like "a".
class VariableExprAST : public ExprAST {
std::string Name;
public:
VariableExprAST(const std::string &amp;name) : Name(name) {}
explicit VariableExprAST(const std::string &amp;name) : Name(name) {}
};
/// BinaryExprAST - Expression class for a binary operator.

View File

@ -56,15 +56,26 @@ public:
class NumberExprAST : public ExprAST {
double Val;
public:
NumberExprAST(double val) : Val(val) {}
explicit NumberExprAST(double val) : Val(val) {}
virtual Value *Codegen();
};
...
</pre>
</div>
<p>"Value" is the class used to represent a "register" in LLVM. The Codegen()
method says to emit IR for that AST node and all things it depends on. The
<p>The Codegen() method says to emit IR for that AST node and all things it
depends on, and they all return an LLVM Value object.
"Value" is the class used to represent a "<a
href="http://en.wikipedia.org/wiki/Static_single_assignment_form">Static Single
Assignment (SSA)</a> register" or "SSA value" in LLVM. The most distinct aspect
of SSA values is that their value is computed as the related instruction
executes, and it does not get a new value until (and if) the instruction
re-executes. In order words, there is no way to "change" an SSA value. For
more information, please read up on <a
href="http://en.wikipedia.org/wiki/Static_single_assignment_form">Static Single
Assignment</a> - the concepts are really quite natural once you grok them.</p>
<p>The
second thing we want is an "Error" method like we used for parser, which will
be used to report errors found during code generation (for example, use of an
undeclared parameter):</p>
@ -299,7 +310,7 @@ public:
class NumberExprAST : public ExprAST {
double Val;
public:
NumberExprAST(double val) : Val(val) {}
explicit NumberExprAST(double val) : Val(val) {}
virtual Value *Codegen();
};
@ -307,7 +318,7 @@ public:
class VariableExprAST : public ExprAST {
std::string Name;
public:
VariableExprAST(const std::string &amp;name) : Name(name) {}
explicit VariableExprAST(const std::string &amp;name) : Name(name) {}
virtual Value *Codegen();
};