RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

[Hexagon] Return the correct chain edge for i1 function calls

Browse Source 
In HexagonISelLowering, there is code to handle the case when
a function returns an i1 type. In this case, we need to generate
extra nodes to copy the result from R0 to a predicate register.

The code was returning the wrong value for the chain edge which
caused an assert "Wrong topological sorting" when converting the
instructions to MIs.

This patch fixes the problem by returning the chain for the final
copy.

Patch by Brendon Cahoon.

llvm-svn: 316367
This commit is contained in:
Krzysztof Parzyszek 2017-10-23 19:35:25 +00:00
parent 789ee2f699
commit 07f5a8acc7
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Target/Hexagon/HexagonISelLowering.cpp
View File

@ -677,13 +677,14 @@ SDValue HexagonTargetLowering::LowerCallResult(
// as an implicit def to the call (EmitMachineNode).
RetVal = DAG.getCopyFromReg(TPR.getValue(0), dl, PredR, MVT::i1);
Glue = TPR.getValue(1);
Chain = TPR.getValue(0);
} else {
RetVal = DAG.getCopyFromReg(Chain, dl, RVLocs[i].getLocReg(),
RVLocs[i].getValVT(), Glue);
Glue = RetVal.getValue(2);
Chain = RetVal.getValue(1);
}
InVals.push_back(RetVal.getValue(0));
Chain = RetVal.getValue(1);
}
return Chain;

23
test/CodeGen/Hexagon/call-ret-i1.ll Normal file
View File

@ -0,0 +1,23 @@
; RUN: llc -march=hexagon < %s
; REQUIRES: asserts
; Test that the compiler does not assert because the DAG is not correct.
; CHECK: call foo
%returntype = type { i1, i32 }
define i32 @test(i32* %a0, i32* %a1, i32* %a2) #0 {
b3:
br i1 undef, label %b6, label %b4
b4: ; preds = %b3
%v5 = call %returntype @foo(i32* nonnull undef, i32* %a2, i32* %a0) #0
ret i32 1
b6: ; preds = %b3
unreachable
}
declare %returntype @foo(i32*, i32*, i32*) #0
attributes #0 = { nounwind }