RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

[Alignment] Add a None() member function

Browse Source 
Summary:
This will allow writing `if(A != llvm::Align::None())` which is clearer than `if(A > llvm::Align(1))`

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Reviewers: courbet

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67697

llvm-svn: 372207
This commit is contained in:
Guillaume Chatelet 2019-09-18 09:24:40 +00:00
parent 30475093d7
commit 08358b1ba1
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/llvm/Support/Alignment.h
View File

@ -55,7 +55,7 @@ private:
public: public:
/// Default is byte-aligned. /// Default is byte-aligned.
Align() = default; constexpr Align() = default;
/// Do not perform checks in case of copy/move construct/assign, because the /// Do not perform checks in case of copy/move construct/assign, because the
/// checks have been performed when building `Other`. /// checks have been performed when building `Other`.
Align(const Align &Other) = default; Align(const Align &Other) = default;
@ -73,6 +73,13 @@ public:
/// This is a hole in the type system and should not be abused. /// This is a hole in the type system and should not be abused.
/// Needed to interact with C for instance. /// Needed to interact with C for instance.
uint64_t value() const { return uint64_t(1) << ShiftValue; } uint64_t value() const { return uint64_t(1) << ShiftValue; }
/// Returns a default constructed Align which corresponds to no alignment.
/// This is useful to test for unalignment as it conveys clear semantic.
/// `if (A != llvm::Align::None())`
/// would be better than
/// `if (A > llvm::Align(1))`
constexpr static const Align None() { return llvm::Align(); }
}; };
/// Treats the value 0 as a 1, so Align is always at least 1. /// Treats the value 0 as a 1, so Align is always at least 1.

5
unittests/Support/AlignmentTest.cpp
View File

@ -28,7 +28,10 @@ std::vector<uint64_t> getValidAlignments() {
return Out; return Out;
} }
TEST(AlignmentTest, AlignDefaultCTor) { EXPECT_EQ(Align().value(), 1ULL); } TEST(AlignmentTest, AlignDefaultCTor) {
EXPECT_EQ(Align().value(), 1ULL);
EXPECT_EQ(Align::None().value(), 1ULL);
}
TEST(AlignmentTest, MaybeAlignDefaultCTor) { TEST(AlignmentTest, MaybeAlignDefaultCTor) {
EXPECT_FALSE(MaybeAlign().hasValue()); EXPECT_FALSE(MaybeAlign().hasValue());