RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

Any size of integral indices are allowed in gep for indexing into sequential types. Also adding a test case to check the indices type allowed into struct.

Browse Source 
llvm-svn: 70134
This commit is contained in:
Sanjiv Gupta 2009-04-26 17:14:35 +00:00
parent d31285fdb7
commit 0877e1eabe
3 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/LangRef.html
View File

@ -3629,7 +3629,7 @@ the pointer before continuing calculation.</p>
<p>The type of each index argument depends on the type it is indexing into. <p>The type of each index argument depends on the type it is indexing into.
When indexing into a (packed) structure, only <tt>i32</tt> integer When indexing into a (packed) structure, only <tt>i32</tt> integer
<b>constants</b> are allowed. When indexing into an array, pointer or vector, <b>constants</b> are allowed. When indexing into an array, pointer or vector,
only integers of 16, 32 or 64 bits are allowed (also non-constants). 16-bit integers of any width are allowed (also non-constants). 16-bit
values will be sign extended to 32-bits if required, and 32-bit values values will be sign extended to 32-bits if required, and 32-bit values
will be sign extended to 64-bits if required.</p> will be sign extended to 64-bits if required.</p>

5
lib/VMCore/Type.cpp
View File

@ -1410,9 +1410,8 @@ void PointerType::typeBecameConcrete(const DerivedType *AbsTy) {
} }
bool SequentialType::indexValid(const Value *V) const { bool SequentialType::indexValid(const Value *V) const {
if (const IntegerType *IT = dyn_cast<IntegerType>(V->getType())) if (isa<IntegerType>(V->getType()))
return IT->getBitWidth() == 16 || IT->getBitWidth() == 32 || return true;
IT->getBitWidth() == 64;
return false; return false;
} }

12
test/Assembler/getelementptr_struct.ll Normal file
View File

@ -0,0 +1,12 @@
; RUN: not llvm-as < %s >/dev/null |& grep {invalid getelementptr indices}
; Test the case of a incorrect indices type into struct
%RT = type { i8 , [10 x [20 x i32]], i8 }
%ST = type { i32, double, %RT }
define i32* @foo(%ST* %s) {
entry:
%reg = getelementptr %ST* %s, i32 1, i64 2, i32 1, i32 5, i32 13
ret i32* %reg
}