diff --git a/include/llvm/TextAPI/ELF/ELFStub.h b/include/llvm/TextAPI/ELF/ELFStub.h index 6a4f92f2d41..fa54e6f8b71 100644 --- a/include/llvm/TextAPI/ELF/ELFStub.h +++ b/include/llvm/TextAPI/ELF/ELFStub.h @@ -54,7 +54,7 @@ class ELFStub { // TODO: Add support for symbol versioning. public: VersionTuple TbeVersion; - std::string SoName; + Optional SoName; ELFArch Arch; std::vector NeededLibs; std::set Symbols; diff --git a/lib/TextAPI/ELF/TBEHandler.cpp b/lib/TextAPI/ELF/TBEHandler.cpp index 8eb60b592dd..dde980292a1 100644 --- a/lib/TextAPI/ELF/TBEHandler.cpp +++ b/lib/TextAPI/ELF/TBEHandler.cpp @@ -132,7 +132,7 @@ template <> struct MappingTraits { if (!IO.mapTag("!tapi-tbe", true)) IO.setError("Not a .tbe YAML file."); IO.mapRequired("TbeVersion", Stub.TbeVersion); - IO.mapRequired("SoName", Stub.SoName); + IO.mapOptional("SoName", Stub.SoName); IO.mapRequired("Arch", (ELFArchMapper &)Stub.Arch); IO.mapOptional("NeededLibs", Stub.NeededLibs); IO.mapRequired("Symbols", Stub.Symbols); diff --git a/unittests/TextAPI/ELFYAMLTest.cpp b/unittests/TextAPI/ELFYAMLTest.cpp index 1797c0b2d79..802a2d7127b 100644 --- a/unittests/TextAPI/ELFYAMLTest.cpp +++ b/unittests/TextAPI/ELFYAMLTest.cpp @@ -37,7 +37,6 @@ void compareByLine(StringRef LHS, StringRef RHS) { TEST(ElfYamlTextAPI, YAMLReadableTBE) { const char Data[] = "--- !tapi-tbe\n" "TbeVersion: 1.0\n" - "SoName: test.so\n" "Arch: x86_64\n" "NeededLibs: [libc.so, libfoo.so, libbar.so]\n" "Symbols:\n" @@ -47,8 +46,8 @@ TEST(ElfYamlTextAPI, YAMLReadableTBE) { ASSERT_THAT_ERROR(StubOrErr.takeError(), Succeeded()); std::unique_ptr Stub = std::move(StubOrErr.get()); EXPECT_NE(Stub.get(), nullptr); + EXPECT_FALSE(Stub->SoName.hasValue()); EXPECT_EQ(Stub->Arch, (uint16_t)llvm::ELF::EM_X86_64); - EXPECT_STREQ(Stub->SoName.c_str(), "test.so"); EXPECT_EQ(Stub->NeededLibs.size(), 3u); EXPECT_STREQ(Stub->NeededLibs[0].c_str(), "libc.so"); EXPECT_STREQ(Stub->NeededLibs[1].c_str(), "libfoo.so"); @@ -72,6 +71,8 @@ TEST(ElfYamlTextAPI, YAMLReadsTBESymbols) { ASSERT_THAT_ERROR(StubOrErr.takeError(), Succeeded()); std::unique_ptr Stub = std::move(StubOrErr.get()); EXPECT_NE(Stub.get(), nullptr); + EXPECT_TRUE(Stub->SoName.hasValue()); + EXPECT_STREQ(Stub->SoName->c_str(), "test.so"); EXPECT_EQ(Stub->Symbols.size(), 5u); auto Iterator = Stub->Symbols.begin(); @@ -143,7 +144,6 @@ TEST(ElfYamlTextAPI, YAMLWritesTBESymbols) { const char Expected[] = "--- !tapi-tbe\n" "TbeVersion: 1.0\n" - "SoName: test.so\n" "Arch: AArch64\n" "Symbols: \n" " foo: { Type: NoType, Size: 99, Warning: Does nothing }\n" @@ -152,7 +152,6 @@ TEST(ElfYamlTextAPI, YAMLWritesTBESymbols) { "...\n"; ELFStub Stub; Stub.TbeVersion = VersionTuple(1, 0); - Stub.SoName = "test.so"; Stub.Arch = ELF::EM_AARCH64; ELFSymbol SymFoo("foo");