diff --git a/utils/lit/lit/TestRunner.py b/utils/lit/lit/TestRunner.py index e4bc48daa7f..5ef1b2b304b 100644 --- a/utils/lit/lit/TestRunner.py +++ b/utils/lit/lit/TestRunner.py @@ -379,11 +379,17 @@ def _executeShCmd(cmd, shenv, results, timeoutHelper): # Ensure the resulting output is always of string type. try: - out = to_string(out.decode('utf-8')) + if out is None: + out = '' + else: + out = to_string(out.decode('utf-8', errors='replace')) except: out = str(out) try: - err = to_string(err.decode('utf-8')) + if err is None: + err = '' + else: + err = to_string(err.decode('utf-8', errors='replace')) except: err = str(err) @@ -438,14 +444,31 @@ def executeScriptInternal(test, litConfig, tmpBase, commands, cwd): out = err = '' for i,result in enumerate(results): - out += 'Command %d: %s\n' % (i, ' '.join('"%s"' % s - for s in result.command.args)) - out += 'Command %d Result: %r\n' % (i, result.exitCode) + # Write the command line run. + out += '$ %s\n' % (' '.join('"%s"' % s + for s in result.command.args),) + + # If nothing interesting happened, move on. + if litConfig.maxIndividualTestTime == 0 and \ + result.exitCode == 0 and \ + not result.stdout.strip() and not result.stderr.strip(): + continue + + # Otherwise, something failed or was printed, show it. + if result.stdout.strip(): + out += '# command output:\n%s\n' % (result.stdout,) + if result.stderr.strip(): + out += '# command stderr:\n%s\n' % (result.stderr,) + if not result.stdout.strip() and not result.stderr.strip(): + out += "note: command had no output on stdout or stderr\n" + + # Show the error conditions: + if result.exitCode != 0: + out += "error: command failed with exit status: %d\n" % ( + result.exitCode,) if litConfig.maxIndividualTestTime > 0: - out += 'Command %d Reached Timeout: %s\n\n' % ( + out += 'error: command reached timeout: %s\n' % ( i, str(result.timeoutReached)) - out += 'Command %d Output:\n%s\n\n' % (i, result.stdout) - out += 'Command %d Stderr:\n%s\n\n' % (i, result.stderr) return out, err, exitCode, timeoutInfo diff --git a/utils/lit/tests/Inputs/shtest-output-printing/basic.txt b/utils/lit/tests/Inputs/shtest-output-printing/basic.txt new file mode 100644 index 00000000000..1720c6097bd --- /dev/null +++ b/utils/lit/tests/Inputs/shtest-output-printing/basic.txt @@ -0,0 +1,3 @@ +# RUN: true +# RUN: echo hi +# RUN: false diff --git a/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg b/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg new file mode 100644 index 00000000000..4fe698d7336 --- /dev/null +++ b/utils/lit/tests/Inputs/shtest-output-printing/lit.cfg @@ -0,0 +1,4 @@ +import lit.formats +config.name = 'shtest-output-printing' +config.suffixes = ['.txt'] +config.test_format = lit.formats.ShTest(execute_external=False) diff --git a/utils/lit/tests/shtest-format.py b/utils/lit/tests/shtest-format.py index 39b0e9c9c62..20884f8c485 100644 --- a/utils/lit/tests/shtest-format.py +++ b/utils/lit/tests/shtest-format.py @@ -39,9 +39,8 @@ # # CHECK: Command Output (stdout): # CHECK-NEXT: -- -# CHECK-NEXT: Command 0: "printf" -# CHECK-NEXT: Command 0 Result: 0 -# CHECK-NEXT: Command 0 Output: +# CHECK-NEXT: $ "printf" +# CHECK-NEXT: # command output: # CHECK-NEXT: line 1: failed test output on stdout # CHECK-NEXT: line 2: failed test output on stdout diff --git a/utils/lit/tests/shtest-output-printing.py b/utils/lit/tests/shtest-output-printing.py new file mode 100644 index 00000000000..1d5fc04ab81 --- /dev/null +++ b/utils/lit/tests/shtest-output-printing.py @@ -0,0 +1,26 @@ +# Check the various features of the ShTest format. +# +# RUN: not %{lit} -j 1 -v %{inputs}/shtest-output-printing > %t.out +# RUN: FileCheck < %t.out %s +# +# END. + +# CHECK: -- Testing: + +# CHECK: FAIL: shtest-output-printing :: basic.txt +# CHECK-NEXT: *** TEST 'shtest-output-printing :: basic.txt' FAILED *** +# CHECK-NEXT: Script: +# CHECK-NEXT: -- +# CHECK: -- +# CHECK-NEXT: Exit Code: 1 +# +# CHECK: Command Output +# CHECK-NEXT: -- +# CHECK-NEXT: $ "true" +# CHECK-NEXT: $ "echo" "hi" +# CHECK-NEXT: # command output: +# CHECK-NEXT: hi +# +# CHECK: $ "false" +# CHECK-NEXT: note: command had no output on stdout or stderr +# CHECK-NEXT: error: command failed with exit status: 1 diff --git a/utils/lit/tests/shtest-shell.py b/utils/lit/tests/shtest-shell.py index 32479e19a10..379b040fc45 100644 --- a/utils/lit/tests/shtest-shell.py +++ b/utils/lit/tests/shtest-shell.py @@ -9,10 +9,10 @@ # CHECK: FAIL: shtest-shell :: error-0.txt # CHECK: *** TEST 'shtest-shell :: error-0.txt' FAILED *** -# CHECK: Command 0: "not-a-real-command" -# CHECK: Command 0 Result: 127 -# CHECK: Command 0 Stderr: +# CHECK: $ "not-a-real-command" +# CHECK: # command stderr: # CHECK: 'not-a-real-command': command not found +# CHECK: error: command failed with exit status: 127 # CHECK: *** # FIXME: The output here sucks.