From 0d9dbe87cd4323b897b3a41119cf8d4fc6dd1f23 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault@amd.com>
Date: Fri, 18 Jan 2019 21:04:59 +0000
Subject: [PATCH] GlobalISel: Verify G_BITCAST

llvm-svn: 351594
---
 lib/CodeGen/MachineVerifier.cpp               | 13 +++++++
 .../AArch64/GlobalISel/legalize-simple.mir    |  8 ++--
 test/Verifier/test_g_bitcast.mir              | 37 +++++++++++++++++++
 3 files changed, 54 insertions(+), 4 deletions(-)
 create mode 100644 test/Verifier/test_g_bitcast.mir

diff --git a/lib/CodeGen/MachineVerifier.cpp b/lib/CodeGen/MachineVerifier.cpp
index a36c13f537d..a19049c7cd3 100644
--- a/lib/CodeGen/MachineVerifier.cpp
+++ b/lib/CodeGen/MachineVerifier.cpp
@@ -1022,6 +1022,19 @@ void MachineVerifier::visitMachineInstrBefore(const MachineInstr *MI) {
              MI);
     break;
   }
+  case TargetOpcode::G_BITCAST: {
+    LLT DstTy = MRI->getType(MI->getOperand(0).getReg());
+    LLT SrcTy = MRI->getType(MI->getOperand(1).getReg());
+    if (!DstTy.isValid() || !SrcTy.isValid())
+      break;
+
+    if (SrcTy.isPointer() != DstTy.isPointer())
+      report("bitcast cannot convert between pointers and other types", MI);
+
+    if (SrcTy.getSizeInBits() != DstTy.getSizeInBits())
+      report("bitcast sizes must match", MI);
+    break;
+  }
   case TargetOpcode::G_SEXT:
   case TargetOpcode::G_ZEXT:
   case TargetOpcode::G_ANYEXT:
diff --git a/test/CodeGen/AArch64/GlobalISel/legalize-simple.mir b/test/CodeGen/AArch64/GlobalISel/legalize-simple.mir
index 51cda7d793e..b4ba35dddf5 100644
--- a/test/CodeGen/AArch64/GlobalISel/legalize-simple.mir
+++ b/test/CodeGen/AArch64/GlobalISel/legalize-simple.mir
@@ -37,10 +37,10 @@ body:             |
   ; CHECK:   $x0 = COPY [[BITCAST1]](s64)
   ; CHECK:   [[BITCAST2:%[0-9]+]]:_(s32) = G_BITCAST [[SELECT3]](s32)
   ; CHECK:   $w0 = COPY [[BITCAST2]](s32)
-  ; CHECK:   [[BITCAST3:%[0-9]+]]:_(<4 x s8>) = G_BITCAST [[COPY]](s64)
+  ; CHECK:   [[BITCAST3:%[0-9]+]]:_(<4 x s8>) = G_BITCAST [[TRUNC1]](s32)
   ; CHECK:   [[BITCAST4:%[0-9]+]]:_(s32) = G_BITCAST [[BITCAST3]](<4 x s8>)
   ; CHECK:   $w0 = COPY [[BITCAST4]](s32)
-  ; CHECK:   [[BITCAST5:%[0-9]+]]:_(<2 x s16>) = G_BITCAST [[COPY]](s64)
+  ; CHECK:   [[BITCAST5:%[0-9]+]]:_(<2 x s16>) = G_BITCAST [[TRUNC1]](s32)
   ; CHECK:   [[BITCAST6:%[0-9]+]]:_(s32) = G_BITCAST [[BITCAST5]](<2 x s16>)
   ; CHECK:   $w0 = COPY [[BITCAST6]](s32)
   bb.0.entry:
@@ -74,10 +74,10 @@ body:             |
     $x0 = COPY %13(s64)
     %14:_(s32) = G_BITCAST %10(s32)
     $w0 = COPY %14(s32)
-    %15:_(<4 x s8>) = G_BITCAST %0(s64)
+    %15:_(<4 x s8>) = G_BITCAST %4(s32)
     %20:_(s32) = G_BITCAST %15(<4 x s8>)
     $w0 = COPY %20(s32)
-    %16:_(<2 x s16>) = G_BITCAST %0(s64)
+    %16:_(<2 x s16>) = G_BITCAST %4(s32)
     %21:_(s32) = G_BITCAST %16(<2 x s16>)
     $w0 = COPY %21(s32)
 
diff --git a/test/Verifier/test_g_bitcast.mir b/test/Verifier/test_g_bitcast.mir
new file mode 100644
index 00000000000..3446d5fc86e
--- /dev/null
+++ b/test/Verifier/test_g_bitcast.mir
@@ -0,0 +1,37 @@
+#RUN: not llc -mtriple=amdgcn-amd-amdhsa -o - -global-isel -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: global-isel, amdgpu-registered-target
+
+---
+name:            test_bitcast
+legalized:       true
+regBankSelected: false
+selected:        false
+tracksRegLiveness: true
+liveins:
+body:             |
+  bb.0:
+   ; CHECK:  Bad machine code: bitcast cannot convert between pointers and other types
+    %0:_(s64) = G_IMPLICIT_DEF
+    %1:_(p0) = G_BITCAST %0
+
+    ; CHECK:  Bad machine code: bitcast cannot convert between pointers and other
+    %2:_(p0) = G_IMPLICIT_DEF
+    %3:_(s64) = G_BITCAST %2
+
+    ; CHECK: Bad machine code: bitcast sizes must match
+    %4:_(s32) = G_IMPLICIT_DEF
+    %5:_(s64) = G_BITCAST %4
+
+    ; CHECK: Bad machine code: bitcast sizes must match
+    %6:_(s32) = G_IMPLICIT_DEF
+    %7:_(<3 x s8>) = G_BITCAST %6
+
+    ; CHECK: Bad machine code: bitcast sizes must match
+    %8:_(p1) = G_IMPLICIT_DEF
+    %9:_(p3) = G_BITCAST %8
+
+    ; CHECK: Bad machine code: bitcast sizes must match
+    %10:_(p1) = G_IMPLICIT_DEF
+    %11:_(p3) = G_BITCAST %8
+
+...