From 0f9f8a6cb6b8649b079732a799c6a5643deaddf0 Mon Sep 17 00:00:00 2001
From: Hubert Tong <hubert.reinterpretcast@gmail.com>
Date: Sat, 17 Oct 2020 22:22:43 -0400
Subject: [PATCH] [test][NFC] Do ptrdiff_t comparison with signed instead of
 unsigned constants

... because using unsigned constants for comparing against signed values
is liable to mutate the signed value via conversion to an unsigned type
due to the usual arithmetic conversions.
---
 unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp b/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
index face8ec024f..bdd4ca5b019 100644
--- a/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
+++ b/unittests/DebugInfo/DWARF/DWARFDebugArangeSetTest.cpp
@@ -200,7 +200,7 @@ TEST(DWARFDebugArangeSet, ZeroAddressEntry) {
                     Succeeded());
   auto Range = Set.descriptors();
   auto Iter = Range.begin();
-  ASSERT_EQ(std::distance(Iter, Range.end()), 1u);
+  ASSERT_EQ(std::distance(Iter, Range.end()), 1);
   EXPECT_EQ(Iter->Address, 0u);
   EXPECT_EQ(Iter->Length, 1u);
 }
@@ -227,7 +227,7 @@ TEST(DWARFDebugArangeSet, ZeroLengthEntry) {
                     Succeeded());
   auto Range = Set.descriptors();
   auto Iter = Range.begin();
-  ASSERT_EQ(std::distance(Iter, Range.end()), 1u);
+  ASSERT_EQ(std::distance(Iter, Range.end()), 1);
   EXPECT_EQ(Iter->Address, 1u);
   EXPECT_EQ(Iter->Length, 0u);
 }
@@ -256,7 +256,7 @@ TEST(DWARFDebugArangesSet, PrematureTerminator) {
   ASSERT_THAT_ERROR(Set.extract(Extractor, &Offset, Warnings), Succeeded());
   auto Range = Set.descriptors();
   auto Iter = Range.begin();
-  ASSERT_EQ(std::distance(Iter, Range.end()), 2u);
+  ASSERT_EQ(std::distance(Iter, Range.end()), 2);
   EXPECT_EQ(Iter->Address, 0u);
   EXPECT_EQ(Iter->Length, 0u);
   ++Iter;