RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

Fix off-by-one error in Regex::isValid

Browse Source 
llvm-svn: 187992
This commit is contained in:
Alexey Samsonov 2013-08-08 17:32:45 +00:00
parent 20c4077bf5
commit 1021d4d06d
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Support/Regex.cpp
View File

@ -43,7 +43,7 @@ bool Regex::isValid(std::string &Error) {
size_t len = llvm_regerror(error, preg, NULL, 0); size_t len = llvm_regerror(error, preg, NULL, 0);
Error.resize(len); Error.resize(len - 1);
llvm_regerror(error, preg, &Error[0], len); llvm_regerror(error, preg, &Error[0], len);
return false; return false;
} }

8
unittests/Support/RegexTest.cpp
View File

@ -127,4 +127,12 @@ TEST_F(RegexTest, IsLiteralERE) {
EXPECT_FALSE(Regex::isLiteralERE("abc{1,2}")); EXPECT_FALSE(Regex::isLiteralERE("abc{1,2}"));
} }
TEST_F(RegexTest, IsValid) {
std::string Error;
EXPECT_FALSE(Regex("(foo").isValid(Error));
EXPECT_EQ("parentheses not balanced", Error);
EXPECT_FALSE(Regex("a[b-").isValid(Error));
EXPECT_EQ("invalid character range", Error);
}
} }