RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

[MemorySSA] Fix comment + remove redundant dyn_casts; NFC

Browse Source 
StartingAccess is already a MemoryUseOrDef.

llvm-svn: 327235
This commit is contained in:
George Burgess IV 2018-03-11 04:16:12 +00:00
parent b887b909c1
commit 1155b8ca45
1 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lib/Analysis/MemorySSA.cpp
View File

@ -2074,18 +2074,16 @@ MemorySSA::CachingWalker::getClobberingMemoryAccess(MemoryAccess *MA) {
const Instruction *I = StartingAccess->getMemoryInst();
UpwardsMemoryQuery Q(I, StartingAccess);
// We can't sanely do anything with a fences, they conservatively
// clobber all memory, and have no locations to get pointers from to
// try to disambiguate.
// We can't sanely do anything with a fence, since they conservatively clobber
// all memory, and have no locations to get pointers from to try to
// disambiguate.
if (!Q.IsCall && I->isFenceLike())
return StartingAccess;
if (isUseTriviallyOptimizableToLiveOnEntry(*MSSA->AA, I)) {
MemoryAccess *LiveOnEntry = MSSA->getLiveOnEntryDef();
if (auto *MUD = dyn_cast<MemoryUseOrDef>(StartingAccess)) {
MUD->setOptimized(LiveOnEntry);
MUD->setOptimizedAccessType(None);
}
StartingAccess->setOptimized(LiveOnEntry);
StartingAccess->setOptimizedAccessType(None);
return LiveOnEntry;
}
@ -2095,10 +2093,8 @@ MemorySSA::CachingWalker::getClobberingMemoryAccess(MemoryAccess *MA) {
// At this point, DefiningAccess may be the live on entry def.
// If it is, we will not get a better result.
if (MSSA->isLiveOnEntryDef(DefiningAccess)) {
if (auto *MUD = dyn_cast<MemoryUseOrDef>(StartingAccess)) {
MUD->setOptimized(DefiningAccess);
MUD->setOptimizedAccessType(None);
}
StartingAccess->setOptimized(DefiningAccess);
StartingAccess->setOptimizedAccessType(None);
return DefiningAccess;
}
@ -2108,13 +2104,11 @@ MemorySSA::CachingWalker::getClobberingMemoryAccess(MemoryAccess *MA) {
DEBUG(dbgs() << "Final Memory SSA clobber for " << *I << " is ");
DEBUG(dbgs() << *Result << "\n");
if (auto *MUD = dyn_cast<MemoryUseOrDef>(StartingAccess)) {
MUD->setOptimized(Result);
if (MSSA->isLiveOnEntryDef(Result))
MUD->setOptimizedAccessType(None);
else if (Q.AR == MustAlias)
MUD->setOptimizedAccessType(MustAlias);
}
StartingAccess->setOptimized(Result);
if (MSSA->isLiveOnEntryDef(Result))
StartingAccess->setOptimizedAccessType(None);
else if (Q.AR == MustAlias)
StartingAccess->setOptimizedAccessType(MustAlias);
return Result;
}