RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

[mips] Do not allow -opt-bisect-limit to skip the PIC call optimization pass.

Browse Source 
r282428 added the MipsOptimizePICCall as an opt-in pass that can be
skipped when using the -opt-bisect-limit option. However, this pass is
needed because it generates code that conforms to the o32 ABI
specification by using the $t9 register for PIC calls with JALR
instructions.

This bug was exposed by the fact that skipFunction() also checks for
the "optnone" attribute. This caused functions with that attribute to
break the requirements of the o32 ABI.

llvm-svn: 285305
This commit is contained in:
Vasileios Kalintiris 2016-10-27 15:50:36 +00:00
parent 268d797e5a
commit 119c41482e
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Target/Mips/MipsOptimizePICCall.cpp
View File

@ -174,9 +174,6 @@ void MBBInfo::postVisit() {
// OptimizePICCall methods.
bool OptimizePICCall::runOnMachineFunction(MachineFunction &F) {
if (skipFunction(*F.getFunction()))
return false;
if (static_cast<const MipsSubtarget &>(F.getSubtarget()).inMips16Mode())
return false;

14
test/CodeGen/Mips/call-optimization.ll
View File

@ -89,3 +89,17 @@ entry:
}
declare double @ceil(double)
; Make sure that the MipsOptimizePICCall pass is run even for optnone functions,
; as we have to make sure that jalr uses $t9 for PIC code in order to adhere to
; the MIPS o32 ABI.
define hidden double @foo(double %dbl) #0 {
entry:
; O32: jalr $25
%res = call double @sqrt(double %dbl)
ret double %res
}
declare double @sqrt(double)
attributes #0 = { noinline optnone }