RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 19:52:54 +01:00
Code Issues Projects Releases Wiki Activity

Rework comment slightly and fix a few typos.

Browse Source 
llvm-svn: 176223
This commit is contained in:
Eric Christopher 2013-02-27 23:49:47 +00:00
parent 2ecf246ca9
commit 12c6402c57
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
View File

@ -1349,17 +1349,14 @@ void CompileUnit::createGlobalVariableDIE(const MDNode *N) {
// Add linkage name. // Add linkage name.
StringRef LinkageName = GV.getLinkageName(); StringRef LinkageName = GV.getLinkageName();
if (!LinkageName.empty() && isGlobalVariable) { if (!LinkageName.empty() && isGlobalVariable) {
// From dwarf-4: DIE to which DW_AT_linkage_name may apply include: // From DWARF4: DIEs to which DW_AT_linkage_name may apply include:
// TAG_commono_block, TAG_constant, TAG_entry_point, TAG_subporgram and // TAG_common_block, TAG_constant, TAG_entry_point, TAG_subprogram and
// TAG_variable. For static member variables, gcc 4.7 puts // TAG_variable.
// MIPS_linkage_name on the definition DIE only, but Darwin gdb needs
// MIPS_linkage_name at both places.
// Per discussion with Eric, for static member variables, we put
// MIPS_linkage_name on the definition DIE (TAG_variable) and conditionaly
// put MIPS_linkage_name on TAG_member when DarwinGDBCompat is on.
addString(IsStaticMember && VariableSpecDIE ? addString(IsStaticMember && VariableSpecDIE ?
VariableSpecDIE : VariableDIE, dwarf::DW_AT_MIPS_linkage_name, VariableSpecDIE : VariableDIE, dwarf::DW_AT_MIPS_linkage_name,
getRealLinkageName(LinkageName)); getRealLinkageName(LinkageName));
// In compatibility mode with older gdbs we put the linkage name on both
// the TAG_variable DIE and on the TAG_member DIE.
if (IsStaticMember && VariableSpecDIE && DD->useDarwinGDBCompat()) if (IsStaticMember && VariableSpecDIE && DD->useDarwinGDBCompat())
addString(VariableDIE, dwarf::DW_AT_MIPS_linkage_name, addString(VariableDIE, dwarf::DW_AT_MIPS_linkage_name,
getRealLinkageName(LinkageName)); getRealLinkageName(LinkageName));