RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-23 19:23:23 +01:00
Code Issues Projects Releases Wiki Activity

A few of the changes suggested in code review (by Nick Lewycky)

Browse Source 
llvm-svn: 149472
This commit is contained in:
Hal Finkel 2012-02-01 05:51:45 +00:00
parent 492f34016f
commit 15dafd979c
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm-c/Transforms/Vectorize.h
View File

@ -1,4 +1,4 @@
/*===---------------------------Vectorize.h ------------------- -*- C++ -*-===*\
/*===---------------------------Vectorize.h --------------------- -*- C -*-===*\
|*===----------- Vectorization Transformation Library C Interface ---------===*|
|* *|
|* The LLVM Compiler Infrastructure *|

15
lib/Transforms/Vectorize/BBVectorize.cpp
View File

@ -300,6 +300,7 @@ namespace {
AU.addRequired<ScalarEvolution>();
AU.addPreserved<AliasAnalysis>();
AU.addPreserved<ScalarEvolution>();
AU.setPreservesCFG();
}
// This returns the vector type that holds a pair of the provided type.
@ -308,9 +309,9 @@ namespace {
if (VectorType *VTy = dyn_cast<VectorType>(ElemTy)) {
unsigned numElem = VTy->getNumElements();
return VectorType::get(ElemTy->getScalarType(), numElem*2);
} else {
return VectorType::get(ElemTy, 2);
}
return VectorType::get(ElemTy, 2);
}
// Returns the weight associated with the provided value. A chain of
@ -431,7 +432,7 @@ namespace {
std::vector<Value *> PairableInsts;
std::multimap<Value *, Value *> CandidatePairs;
getCandidatePairs(BB, CandidatePairs, PairableInsts);
if (PairableInsts.size() == 0) return false;
if (PairableInsts.empty()) return false;
// Now we have a map of all of the pairable instructions and we need to
// select the best possible pairing. A good pairing is one such that the
@ -444,7 +445,7 @@ namespace {
std::multimap<ValuePair, ValuePair> ConnectedPairs;
computeConnectedPairs(CandidatePairs, PairableInsts, ConnectedPairs);
if (ConnectedPairs.size() == 0) return false;
if (ConnectedPairs.empty()) return false;
// Build the pairable-instruction dependency map
DenseSet<ValuePair> PairableInstUsers;
@ -459,7 +460,7 @@ namespace {
choosePairs(CandidatePairs, PairableInsts, ConnectedPairs,
PairableInstUsers, ChosenPairs);
if (ChosenPairs.size() == 0) return false;
if (ChosenPairs.empty()) return false;
NumFusedOps += ChosenPairs.size();
// A set of pairs has now been selected. It is now necessary to replace the
@ -647,8 +648,8 @@ namespace {
UsesI = true;
if (!UsesI)
for (User::op_iterator JU = J->op_begin(), e = J->op_end();
JU != e; ++JU) {
for (User::op_iterator JU = J->op_begin(), JE = J->op_end();
JU != JE; ++JU) {
Value *V = *JU;
if (I == V || Users.count(V)) {
UsesI = true;