RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 20:51:52 +01:00
Code Issues Projects Releases Wiki Activity

[MC] Allow assembling .secidx and .secrel32 for undefined symbols

Browse Source 
There's nothing incorrect about emitting such relocations against
symbols defined in other objects. The code in EmitCOFFSec* was missing
the visitUsedExpr part of MCStreamer::EmitValueImpl, so these symbols
were not being registered with the object file assembler.

This will be used to make reduced test cases for LLD.

llvm-svn: 306057
This commit is contained in:
Reid Kleckner 2017-06-22 21:02:14 +00:00
parent 6535c568ef
commit 1ad2576dfe
3 changed files with 34 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/MC/MCWinCOFFStreamer.cpp
View File

@ -190,7 +190,8 @@ void MCWinCOFFStreamer::EmitCOFFSafeSEH(MCSymbol const *Symbol) {
<< COFF::SCT_COMPLEX_TYPE_SHIFT);
}
void MCWinCOFFStreamer::EmitCOFFSectionIndex(MCSymbol const *Symbol) {
void MCWinCOFFStreamer::EmitCOFFSectionIndex(const MCSymbol *Symbol) {
visitUsedSymbol(*Symbol);
MCDataFragment *DF = getOrCreateDataFragment();
const MCSymbolRefExpr *SRE = MCSymbolRefExpr::create(Symbol, getContext());
MCFixup Fixup = MCFixup::create(DF->getContents().size(), SRE, FK_SecRel_2);
@ -198,8 +199,9 @@ void MCWinCOFFStreamer::EmitCOFFSectionIndex(MCSymbol const *Symbol) {
DF->getContents().resize(DF->getContents().size() + 2, 0);
}
void MCWinCOFFStreamer::EmitCOFFSecRel32(MCSymbol const *Symbol,
void MCWinCOFFStreamer::EmitCOFFSecRel32(const MCSymbol *Symbol,
uint64_t Offset) {
visitUsedSymbol(*Symbol);
MCDataFragment *DF = getOrCreateDataFragment();
// Create Symbol A for the relocation relative reference.
const MCExpr *MCE = MCSymbolRefExpr::create(Symbol, getContext());

10
test/MC/COFF/secidx-diagnostic.s
View File

@ -1,10 +0,0 @@
// RUN: not llvm-mc -filetype=obj -triple i686-pc-win32 %s 2>%t
// RUN: FileCheck %s < %t
// CHECK: symbol 'bar' can not be undefined
// CHECK: symbol 'baz' can not be undefined
.data
foo:
.secidx bar
.secidx baz

30
test/MC/COFF/secrel32-undef.s Normal file
View File

@ -0,0 +1,30 @@
# RUN: llvm-mc -filetype=obj -triple i686-pc-win32 %s -o %t.obj
# RUN: llvm-readobj -symbols -relocations %t.obj | FileCheck %s
# Previously .secrel32 and .secidx relocations against undefined symbols
# resulted in an error. That was a mistake. The linker is fully capable of
# resolving these relocations against symbols in other object files. Such
# relocations can be found in the MSVCRT debug info describing linker-provided
# symbols like __safe_se_handler_table and __guard_fids_table.
.data
foo:
.secrel32 bar
.secidx baz
# CHECK: Relocations [
# CHECK: Section (2) .data {
# CHECK: 0x0 IMAGE_REL_I386_SECREL bar
# CHECK: 0x4 IMAGE_REL_I386_SECTION baz
# CHECK: }
# CHECK: ]
# CHECK: Symbol {
# CHECK: Name: bar
# CHECK-NEXT: Value: 0
# CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED (0)
# CHECK: Symbol {
# CHECK: Name: baz
# CHECK-NEXT: Value: 0
# CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED (0)