RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-24 03:33:20 +01:00
Code Issues Projects Releases Wiki Activity

[IRVerifier] Prefer dyn_cast<> over isa<> + cast<>.

Browse Source 
Thanks to Rafael for the suggestion!

llvm-svn: 265579
This commit is contained in:
Davide Italiano 2016-04-06 18:13:44 +00:00
parent 3ca438a215
commit 1eb7bb3604
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/IR/Verifier.cpp
View File

@ -4375,15 +4375,14 @@ void Verifier::verifyTypeRefs() {
// Visit all the compile units again to map the type references. // Visit all the compile units again to map the type references.
SmallDenseMap<const MDString *, const DIType *, 32> TypeRefs; SmallDenseMap<const MDString *, const DIType *, 32> TypeRefs;
for (auto *CU : CUs->operands()) for (auto *MD : CUs->operands())
if (isa<DICompileUnit>(CU)) if (auto *CU = dyn_cast<DICompileUnit>(MD))
if (auto Ts = cast<DICompileUnit>(CU)->getRetainedTypes()) for (DIType *Op : CU->getRetainedTypes())
for (DIType *Op : Ts) if (auto *T = dyn_cast_or_null<DICompositeType>(Op))
if (auto *T = dyn_cast_or_null<DICompositeType>(Op)) if (auto *S = T->getRawIdentifier()) {
if (auto *S = T->getRawIdentifier()) { UnresolvedTypeRefs.erase(S);
UnresolvedTypeRefs.erase(S); TypeRefs.insert(std::make_pair(S, T));
TypeRefs.insert(std::make_pair(S, T)); }
}
// Verify debug info intrinsic bit piece expressions. This needs a second // Verify debug info intrinsic bit piece expressions. This needs a second
// pass through the intructions, since we haven't built TypeRefs yet when // pass through the intructions, since we haven't built TypeRefs yet when