RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

[ARM] Disable sign extended SSAT pattern recognition.

Browse Source 
I may have given bad advice, and skipping sext_inreg when matching SSAT
patterns is not valid on it's own. It at least needs to sext_inreg the
input again, but as far as I can tell is still only valid based on
demanded bits. For the moment disable that part of the combine,
hopefully reimplementing it in the future more correctly.
This commit is contained in:
David Green 2021-01-22 14:07:48 +00:00
parent 64b62b62ba
commit 1fb0315b7d
3 changed files with 62 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/ARM/ARMISelLowering.cpp
View File

@ -5062,12 +5062,6 @@ static SDValue LowerSaturatingConditional(SDValue Op, SelectionDAG &DAG) {
SDValue V1Tmp = V1;
SDValue V2Tmp = V2;
if (V1.getOpcode() == ISD::SIGN_EXTEND_INREG &&
V2.getOpcode() == ISD::SIGN_EXTEND_INREG) {
V1Tmp = V1.getOperand(0);
V2Tmp = V2.getOperand(0);
}
// Check that the registers and the constants match a max(min()) or min(max())
// pattern
if (V1Tmp != TrueVal1 || V2Tmp != TrueVal2 || K1 != FalseVal1 ||

38
test/CodeGen/ARM/ssat.ll
View File

@ -68,7 +68,15 @@ define i16 @sat_base_16bit(i16 %x) #0 {
;
; V6T2-LABEL: sat_base_16bit:
; V6T2: @ %bb.0: @ %entry
; V6T2-NEXT: ssat r0, #12, r0
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: movw r2, #2047
; V6T2-NEXT: cmp r1, r2
; V6T2-NEXT: movlt r2, r0
; V6T2-NEXT: movw r0, #63488
; V6T2-NEXT: sxth r1, r2
; V6T2-NEXT: movt r0, #65535
; V6T2-NEXT: cmn r1, #2048
; V6T2-NEXT: movgt r0, r2
; V6T2-NEXT: bx lr
entry:
%0 = icmp slt i16 %x, 2047
@ -95,7 +103,12 @@ define i8 @sat_base_8bit(i8 %x) #0 {
;
; V6T2-LABEL: sat_base_8bit:
; V6T2: @ %bb.0: @ %entry
; V6T2-NEXT: ssat r0, #6, r0
; V6T2-NEXT: sxtb r1, r0
; V6T2-NEXT: cmp r1, #31
; V6T2-NEXT: movge r0, #31
; V6T2-NEXT: sxtb r1, r0
; V6T2-NEXT: cmn r1, #32
; V6T2-NEXT: mvnle r0, #31
; V6T2-NEXT: bx lr
entry:
%0 = icmp slt i8 %x, 31
@ -547,7 +560,12 @@ define void @extended(i32 %xx, i16 signext %y, i8* nocapture %z) {
; V6T2-LABEL: extended:
; V6T2: @ %bb.0: @ %entry
; V6T2-NEXT: add r0, r1, r0, lsr #16
; V6T2-NEXT: ssat r0, #8, r0
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: cmp r1, #127
; V6T2-NEXT: movge r0, #127
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: cmn r1, #128
; V6T2-NEXT: mvnle r0, #127
; V6T2-NEXT: strb r0, [r2]
; V6T2-NEXT: bx lr
entry:
@ -582,7 +600,12 @@ define i32 @formulated_valid(i32 %a) {
;
; V6T2-LABEL: formulated_valid:
; V6T2: @ %bb.0:
; V6T2-NEXT: ssat r0, #8, r0
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: cmp r1, #127
; V6T2-NEXT: movge r0, #127
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: cmn r1, #128
; V6T2-NEXT: mvnle r0, #127
; V6T2-NEXT: uxth r0, r0
; V6T2-NEXT: bx lr
%x1 = trunc i32 %a to i16
@ -613,7 +636,12 @@ define i32 @formulated_invalid(i32 %a) {
;
; V6T2-LABEL: formulated_invalid:
; V6T2: @ %bb.0:
; V6T2-NEXT: ssat r0, #8, r0
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: cmp r1, #127
; V6T2-NEXT: movge r0, #127
; V6T2-NEXT: sxth r1, r0
; V6T2-NEXT: cmn r1, #128
; V6T2-NEXT: mvnle r0, #127
; V6T2-NEXT: bic r0, r0, #-16777216
; V6T2-NEXT: bx lr
%x1 = trunc i32 %a to i16

33
test/CodeGen/ARM/usat.ll
View File

@ -67,12 +67,27 @@ define i16 @unsigned_sat_base_16bit(i16 %x) #0 {
;
; V6-LABEL: unsigned_sat_base_16bit:
; V6: @ %bb.0: @ %entry
; V6-NEXT: usat r0, #11, r0
; V6-NEXT: mov r1, #255
; V6-NEXT: sxth r2, r0
; V6-NEXT: orr r1, r1, #1792
; V6-NEXT: cmp r2, r1
; V6-NEXT: movlt r1, r0
; V6-NEXT: sxth r0, r1
; V6-NEXT: cmp r0, #0
; V6-NEXT: movle r1, #0
; V6-NEXT: mov r0, r1
; V6-NEXT: bx lr
;
; V6T2-LABEL: unsigned_sat_base_16bit:
; V6T2: @ %bb.0: @ %entry
; V6T2-NEXT: usat r0, #11, r0
; V6T2-NEXT: sxth r2, r0
; V6T2-NEXT: movw r1, #2047
; V6T2-NEXT: cmp r2, r1
; V6T2-NEXT: movlt r1, r0
; V6T2-NEXT: sxth r0, r1
; V6T2-NEXT: cmp r0, #0
; V6T2-NEXT: movle r1, #0
; V6T2-NEXT: mov r0, r1
; V6T2-NEXT: bx lr
entry:
%0 = icmp slt i16 %x, 2047
@ -99,12 +114,22 @@ define i8 @unsigned_sat_base_8bit(i8 %x) #0 {
;
; V6-LABEL: unsigned_sat_base_8bit:
; V6: @ %bb.0: @ %entry
; V6-NEXT: usat r0, #5, r0
; V6-NEXT: sxtb r1, r0
; V6-NEXT: cmp r1, #31
; V6-NEXT: movge r0, #31
; V6-NEXT: sxtb r1, r0
; V6-NEXT: cmp r1, #0
; V6-NEXT: movle r0, #0
; V6-NEXT: bx lr
;
; V6T2-LABEL: unsigned_sat_base_8bit:
; V6T2: @ %bb.0: @ %entry
; V6T2-NEXT: usat r0, #5, r0
; V6T2-NEXT: sxtb r1, r0
; V6T2-NEXT: cmp r1, #31
; V6T2-NEXT: movge r0, #31
; V6T2-NEXT: sxtb r1, r0
; V6T2-NEXT: cmp r1, #0
; V6T2-NEXT: movle r0, #0
; V6T2-NEXT: bx lr
entry:
%0 = icmp slt i8 %x, 31