RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-01 05:01:59 +01:00
Code Issues Projects Releases Wiki Activity

CodeGen: Don't try to canonicalize Unix-style paths in CodeView debug info.

Browse Source 
Most importantly, we should not replace slashes with backslashes
because that would invalidate the path.

Differential Revision: https://reviews.llvm.org/D45473

llvm-svn: 329838
This commit is contained in:
Peter Collingbourne 2018-04-11 18:24:03 +00:00
parent c09c832a8e
commit 2047ab334e
4 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
View File

@ -114,6 +114,16 @@ StringRef CodeViewDebug::getFullFilepath(const DIFile *File) {
StringRef Dir = File->getDirectory(), Filename = File->getFilename();
// If this is a Unix-style path, just use it as is. Don't try to canonicalize
// it textually because one of the path components could be a symlink.
if (!Dir.empty() && Dir[0] == '/') {
Filepath = Dir;
if (Dir.back() != '/')
Filepath += '/';
Filepath += Filename;
return Filepath;
}
// Clang emits directory and relative filename info into the IR, but CodeView
// operates on full paths. We could change Clang to emit full paths too, but
// that would increase the IR size and probably not needed for other users.

6
test/DebugInfo/COFF/enum.ll
View File

@ -26,12 +26,12 @@
; CHECK-NEXT: StringId (0x1002) {
; CHECK-NEXT: TypeLeafKind: LF_STRING_ID (0x1605)
; CHECK-NEXT: Id: 0x0
; CHECK-NEXT: StringData: \<stdin>
; CHECK-NEXT: StringData: /foo/bar.cpp
; CHECK-NEXT: }
; CHECK-NEXT: UdtSourceLine (0x1003) {
; CHECK-NEXT: TypeLeafKind: LF_UDT_SRC_LINE (0x1606)
; CHECK-NEXT: UDT: E (0x1001)
; CHECK-NEXT: SourceFile: \<stdin> (0x1002)
; CHECK-NEXT: SourceFile: /foo/bar.cpp (0x1002)
; CHECK-NEXT: LineNumber: 1
; CHECK_NEXT }
@ -51,7 +51,7 @@ target triple = "i686-pc-windows-msvc18.0.0"
!3 = !DIFile(filename: "-", directory: "/")
!4 = !{!5}
!5 = !DICompositeType(tag: DW_TAG_enumeration_type, name: "E", file: !6, line: 1, baseType: !7, size: 32, align: 32, elements: !8)
!6 = !DIFile(filename: "<stdin>", directory: "/")
!6 = !DIFile(filename: "bar.cpp", directory: "/foo")
!7 = !DIBasicType(name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
!8 = !{!9}
!9 = !DIEnumerator(name: "BLAH", value: 0)

4
test/DebugInfo/COFF/types-array-advanced.ll
View File

@ -142,12 +142,12 @@
; CHECK: StringId (0x100D) {
; CHECK: TypeLeafKind: LF_STRING_ID (0x1605)
; CHECK: Id: 0x0
; CHECK: StringData: \t.cpp
; CHECK: StringData: /t.cpp
; CHECK: }
; CHECK: UdtSourceLine (0x100E) {
; CHECK: TypeLeafKind: LF_UDT_SRC_LINE (0x1606)
; CHECK: UDT: incomplete_struct (0x100C)
; CHECK: SourceFile: \t.cpp (0x100D)
; CHECK: SourceFile: /t.cpp (0x100D)
; CHECK: LineNumber: 4
; CHECK: }
; CHECK: Modifier (0x100F) {

6
test/DebugInfo/COFF/types-non-virtual-methods.ll
View File

@ -121,12 +121,12 @@
; CHECK: StringId (0x1008) {
; CHECK: TypeLeafKind: LF_STRING_ID (0x1605)
; CHECK: Id: 0x0
; CHECK: StringData: \t.cpp
; CHECK: StringData: /t.cpp
; CHECK: }
; CHECK: UdtSourceLine (0x1009) {
; CHECK: TypeLeafKind: LF_UDT_SRC_LINE (0x1606)
; CHECK: UDT: A (0x1007)
; CHECK: SourceFile: \t.cpp (0x1008)
; CHECK: SourceFile: /t.cpp (0x1008)
; CHECK: LineNumber: 1
; CHECK: }
; CHECK: Class (0x100A) {
@ -241,7 +241,7 @@
; CHECK: UdtSourceLine (0x1014) {
; CHECK: TypeLeafKind: LF_UDT_SRC_LINE (0x1606)
; CHECK: UDT: B (0x1013)
; CHECK: SourceFile: \t.cpp (0x1008)
; CHECK: SourceFile: /t.cpp (0x1008)
; CHECK: LineNumber: 11
; CHECK: }
; CHECK: ]