RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-31 12:41:49 +01:00
Code Issues Projects Releases Wiki Activity

Simplify PackedVector by removing user-defined special members that aren't any different than the defaults

Browse Source 
This causes the other special members (like move and copy construction,
and move assignment) to come through for free. Some code in clang was
depending on the (deprecated, in the original code) copy ctor. Now that
there's no user-defined special members, they're all available without
any deprecation concerns.

llvm-svn: 244835
This commit is contained in:
David Blaikie 2015-08-12 23:26:12 +00:00
parent 056b2063fb
commit 2063494b0a
2 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
include/llvm/ADT/PackedVector.h
View File

@ -96,7 +96,7 @@ public:
}
};
PackedVector() { }
PackedVector() = default;
explicit PackedVector(unsigned size) : Bits(size << (BitNum-1)) { }
bool empty() const { return Bits.empty(); }
@ -135,19 +135,10 @@ public:
return Bits != RHS.Bits;
}
const PackedVector &operator=(const PackedVector &RHS) {
Bits = RHS.Bits;
return *this;
}
PackedVector &operator|=(const PackedVector &RHS) {
Bits |= RHS.Bits;
return *this;
}
void swap(PackedVector &RHS) {
Bits.swap(RHS.Bits);
}
};
// Leave BitNum=0 undefined.

12
unittests/ADT/PackedVectorTest.cpp
View File

@ -52,18 +52,6 @@ TEST(PackedVectorTest, Operation) {
EXPECT_FALSE(Vec == Vec2);
EXPECT_TRUE(Vec != Vec2);
Vec2.swap(Vec);
EXPECT_EQ(3U, Vec.size());
EXPECT_FALSE(Vec.empty());
EXPECT_EQ(0U, Vec[0]);
EXPECT_EQ(0U, Vec[1]);
EXPECT_EQ(0U, Vec[2]);
EXPECT_EQ(2U, Vec2[0]);
EXPECT_EQ(0U, Vec2[1]);
EXPECT_EQ(1U, Vec2[2]);
EXPECT_EQ(3U, Vec2[3]);
Vec = Vec2;
EXPECT_TRUE(Vec == Vec2);
EXPECT_FALSE(Vec != Vec2);