RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-20 03:23:01 +02:00
Code Issues Projects Releases Wiki Activity

Don't fallback to copy + delete in rename.

Browse Source 
Rename's documentation says "Files are renamed as if by POSIX rename()". and it
is used for atomically updating output files from a temporary. Having rename
fallback to a non atomic copy has the potential to hide bugs, like using
a temporary file in /tmp instead of a unique name next to the final destination.

llvm-svn: 186483
This commit is contained in:
Rafael Espindola 2013-07-17 03:33:41 +00:00
parent c6d133943e
commit 2451973efd
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Support/Unix/Path.inc
View File

@ -456,17 +456,8 @@ error_code rename(const Twine &from, const Twine &to) {
StringRef f = from.toNullTerminatedStringRef(from_storage);
StringRef t = to.toNullTerminatedStringRef(to_storage);
if (::rename(f.begin(), t.begin()) == -1) {
// If it's a cross device link, copy then delete, otherwise return the error
if (errno == EXDEV) {
if (error_code ec = copy_file(from, to, copy_option::overwrite_if_exists))
return ec;
bool Existed;
if (error_code ec = remove(from, Existed))
return ec;
} else
return error_code(errno, system_category());
}
if (::rename(f.begin(), t.begin()) == -1)
return error_code(errno, system_category());
return error_code::success();
}