RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 18:54:02 +01:00
Code Issues Projects Releases Wiki Activity

[InstNamer] use 'i' for Instructions, not 'tmp'

Browse Source 
As discussed in https://bugs.llvm.org/show_bug.cgi?id=45951 and
D80584, the name 'tmp' is almost always a bad choice, but we have
a legacy of regression tests with that name because it was baked
into utils/update_test_checks.py.

This change makes -instnamer more consistent (already using "arg"
and "bb", the common LLVM shorthand). And it avoids the conflict
in telling users of the FileCheck script to run "-instnamer" to
create a better regression test and having that cause a warn/fail
in update_test_checks.py.
This commit is contained in:
Sanjay Patel 2020-06-01 10:56:27 -04:00
parent 1b0a29266b
commit 24f9324c29
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Transforms/Utils/InstructionNamer.cpp
View File

@ -42,7 +42,7 @@ namespace {
for (Instruction &I : BB) for (Instruction &I : BB)
if (!I.hasName() && !I.getType()->isVoidTy()) if (!I.hasName() && !I.getType()->isVoidTy())
I.setName("tmp"); I.setName("i");
} }
return true; return true;
} }

4
test/Transforms/InstNamer/basic.ll
View File

@ -6,10 +6,10 @@ target triple = "x86_64-unknown-linux-gnu"
define i32 @f_0(i32) { define i32 @f_0(i32) {
; CHECK-LABEL: @f_0( ; CHECK-LABEL: @f_0(
; CHECK: bb: ; CHECK: bb:
; CHECK-NEXT: %tmp = add i32 %arg, 2 ; CHECK-NEXT: %i = add i32 %arg, 2
; CHECK-NEXT: br label %bb1 ; CHECK-NEXT: br label %bb1
; CHECK: bb1: ; CHECK: bb1:
; CHECK-NEXT: ret i32 %tmp ; CHECK-NEXT: ret i32 %i
%2 = add i32 %0, 2 %2 = add i32 %0, 2
br label %3 br label %3