RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 02:52:53 +02:00
Code Issues Projects Releases Wiki Activity

[TableGen] Don't elide bitconverts in PatFrag fragments.

Browse Source 
Summary:
In the DAG pattern backend, `SimplifyTree` simplifies a pattern by
removing bitconverts between two identical types. But that function is
also run on the fragments list in instances of `PatFrags`, in which
the types haven't been specified yet. So the input and output of the
bitconvert always evaluate to the empty set of types, which makes them
compare equal. So the test always passes, and bitconverts are
unconditionally removed from the PatFrag RHS.

Fixed by spotting the empty type set and using it to inhibit the
optimization.

Reviewers: nhaehnle, hfinkel

Reviewed By: nhaehnle

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74627
This commit is contained in:
Simon Tatham 2020-02-17 09:11:35 +00:00
parent 743f6f19e1
commit 270ded9a96
2 changed files with 45 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
test/TableGen/simplify-patfrag.td Normal file
View File

@ -0,0 +1,38 @@
// RUN: llvm-tblgen -gen-dag-isel -I %p/../../include %s 2>&1 | FileCheck %s
include "llvm/Target/Target.td"
// Minimal Target definition
def DemoInstrInfo : InstrInfo;
def Demo : Target {
let InstructionSet = DemoInstrInfo;
}
// Some registers which can hold ints or floats
foreach i = 0-7 in
def "R" # i: Register<"r" # i>;
def GPR : RegisterClass<"Demo", [i32, f32], 32, (sequence "R%u", 0, 7)>;
// Instruction to convert an int to a float
def i2f : Instruction {
let Size = 2;
let OutOperandList = (outs GPR:$dst);
let InOperandList = (ins GPR:$src);
let AsmString = "i2f $dst, $src";
}
// Some kind of special type-conversion node supported by this target
def specialconvert : SDNode<"TEST_TARGET_ISD::SPECIAL_CONVERT", SDTUnaryOp>;
// A PatFrags that matches either bitconvert or the special version
def anyconvert : PatFrags<(ops node:$src),
[(bitconvert node:$src),
(specialconvert node:$src)]>;
// And a rule that matches that PatFrag and turns it into i2f
def : Pat<(f32 (anyconvert (i32 GPR:$val))), (i2f GPR:$val)>;
// CHECK: SwitchOpcode{{.*}}ISD::BITCAST
// CHECK: MorphNodeTo1{{.*}}i2f
// CHECK: SwitchOpcode{{.*}}TEST_TARGET_ISD::SPECIAL_CONVERT
// CHECK: MorphNodeTo1{{.*}}i2f

7
utils/TableGen/CodeGenDAGPatterns.cpp
View File

@ -2918,8 +2918,15 @@ static bool SimplifyTree(TreePatternNodePtr &N) {
// If we have a bitconvert with a resolved type and if the source and
// destination types are the same, then the bitconvert is useless, remove it.
//
// We make an exception if the types are completely empty. This can come up
// when the pattern being simplified is in the Fragments list of a PatFrags,
// so that the operand is just an untyped "node". In that situation we leave
// bitconverts unsimplified, and simplify them later once the fragment is
// expanded into its true context.
if (N->getOperator()->getName() == "bitconvert" &&
N->getExtType(0).isValueTypeByHwMode(false) &&
!N->getExtType(0).empty() &&
N->getExtType(0) == N->getChild(0)->getExtType(0) &&
N->getName().empty()) {
N = N->getChildShared(0);