From 27e18491ee0f4323af39a7f2e77b5a76d69e85d9 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Mon, 14 Apr 2014 16:38:25 +0000 Subject: [PATCH] tools: fix heap-buffer-overrun detected via ASAN Once the auxiliary fields relating to the filename have been inspected, any following auxiliary fields need not be visited as they have been consumed (the following fields comprise the filepath as a single unit). Adjust the test to catch this even if ASAN is not enabled. llvm-svn: 206190 --- test/tools/llvm-objdump/coff-file.test | 1 + tools/llvm-objdump/llvm-objdump.cpp | 3 +++ 2 files changed, 4 insertions(+) diff --git a/test/tools/llvm-objdump/coff-file.test b/test/tools/llvm-objdump/coff-file.test index ba345b4d426..75d02b8a495 100644 --- a/test/tools/llvm-objdump/coff-file.test +++ b/test/tools/llvm-objdump/coff-file.test @@ -2,4 +2,5 @@ RUN: llvm-objdump -t %p/Inputs/file.obj.coff-arm | FileCheck %s CHECK: .file CHECK-NEXT: AUX /Users/compnerd/work/llvm/test/tools/llvm-readobj/Inputs/file.asm +CHECK-NEXT: [{{[ 0-9]+}}] diff --git a/tools/llvm-objdump/llvm-objdump.cpp b/tools/llvm-objdump/llvm-objdump.cpp index aff83f0cbd1..42c61c6386d 100644 --- a/tools/llvm-objdump/llvm-objdump.cpp +++ b/tools/llvm-objdump/llvm-objdump.cpp @@ -708,6 +708,9 @@ static void PrintCOFFSymbolTable(const COFFObjectFile *coff) { StringRef Name(AF->FileName, Symbol->NumberOfAuxSymbols * COFF::SymbolSize); outs() << "AUX " << Name.rtrim(StringRef("\0", 1)) << '\n'; + + SI = SI + Symbol->NumberOfAuxSymbols; + break; } else { outs() << "AUX Unknown\n"; }