RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-20 03:23:01 +02:00
Code Issues Projects Releases Wiki Activity

Relocation against a symbol, instead of against section. We had some extreme

Browse Source 
test cases where there were a lot of relocations applied relative to a large
rodata section. Gas would create a symbol for each of these whereas we would
be relative to the beginning of the rodata section. This change mimics what
gas does.

Patch by Jack Carter.

llvm-svn: 146468
This commit is contained in:
Akira Hatanaka 2011-12-13 02:27:40 +00:00
parent 0c3a49b88e
commit 28140f744a
2 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/MC/ELFObjectWriter.cpp
View File

@ -1851,7 +1851,8 @@ const MCSymbol *MipsELFObjectWriter::ExplicitRelSym(const MCAssembler &Asm,
assert(Target.getSymA() && "SymA cannot be 0.");
const MCSymbol &Sym = Target.getSymA()->getSymbol();
if (Sym.getSection().getKind().isMergeable1ByteCString())
if (Sym.getSection().getKind().isMergeableCString() ||
Sym.getSection().getKind().isMergeableConst())
return &Sym;
return NULL;
@ -1914,4 +1915,3 @@ unsigned MipsELFObjectWriter::GetRelocType(const MCValue &Target,
return Type;
}

29
test/CodeGen/Mips/DO-relsym.ll Normal file
View File

@ -0,0 +1,29 @@
; RUN: llc -filetype=obj -mtriple mipsel-unknown-linux %s -o - | elf-dump --dump-section-data | FileCheck %s
; Check that the appropriate symbols were created.
; CHECK: (('st_name', 0x{{[0-9|a-f]+}}) # '$.str'
; CHECK: (('st_name', 0x{{[0-9|a-f]+}}) # '$.str1'
; CHECK: (('st_name', 0x{{[0-9|a-f]+}}) # '$CPI0_0'
; CHECK: (('st_name', 0x{{[0-9|a-f]+}}) # '$CPI0_1'
@.str = private unnamed_addr constant [6 x i8] c"abcde\00", align 1
@gc1 = external global i8*
@.str1 = private unnamed_addr constant [5 x i8] c"fghi\00", align 1
@gc2 = external global i8*
@gd1 = external global double
@gd2 = external global double
define void @foo1() nounwind {
entry:
store i8* getelementptr inbounds ([6 x i8]* @.str, i32 0, i32 0), i8** @gc1, align 4
store i8* getelementptr inbounds ([5 x i8]* @.str1, i32 0, i32 0), i8** @gc2, align 4
%0 = load double* @gd1, align 8
%add = fadd double %0, 2.500000e+00
store double %add, double* @gd1, align 8
%1 = load double* @gd2, align 8
%add1 = fadd double %1, 4.500000e+00
store double %add1, double* @gd2, align 8
ret void
}