RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-19 11:02:59 +02:00
Code Issues Projects Releases Wiki Activity

[DebugInfo] Maintain DI for sunken bitcasts

Browse Source 
When a bitcast is being sunk in -codegenprepare pass, its DI wasn't
copied over to the newly created instruction. This patch fixes that
bug.

Patch by Kareem Ergawy!

Differential Revision: https://reviews.llvm.org/D47282

llvm-svn: 333133
This commit is contained in:
Vedant Kumar 2018-05-23 22:03:48 +00:00
parent 078a9b9c6c
commit 2bea9c3519
2 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/CodeGen/CodeGenPrepare.cpp
View File

@ -1050,6 +1050,7 @@ static bool SinkCast(CastInst *CI) {
assert(InsertPt != UserBB->end());
InsertedCast = CastInst::Create(CI->getOpcode(), CI->getOperand(0),
CI->getType(), "", &*InsertPt);
InsertedCast->setDebugLoc(CI->getDebugLoc());
}
// Replace a use of the cast with a use of the new cast.

37
test/DebugInfo/sink-bitcast-di.ll Normal file
View File

@ -0,0 +1,37 @@
; RUN: opt -S -debugify -codegenprepare < %s | FileCheck %s
target datalayout =
"e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
target triple = "x86_64-unknown-linux-gnu"
declare void @foo(i32)
declare void @slowpath(i32, i32*)
; Is DI maintained after sinking bitcast?
define void @test(i1 %cond, i64* %base) {
; CHECK-LABEL: @test
entry:
%addr = getelementptr inbounds i64, i64* %base, i64 5
%casted = bitcast i64* %addr to i32*
br i1 %cond, label %if.then, label %fallthrough
if.then:
; CHECK-LABEL: if.then:
; CHECK: bitcast i64* %addr to i32*, !dbg ![[castLoc:[0-9]+]]
%v1 = load i32, i32* %casted, align 4
call void @foo(i32 %v1)
%cmp = icmp eq i32 %v1, 0
br i1 %cmp, label %rare.1, label %fallthrough
fallthrough:
ret void
rare.1:
; CHECK-LABEL: rare.1:
; CHECK: bitcast i64* %addr to i32*, !dbg ![[castLoc]]
call void @slowpath(i32 %v1, i32* %casted) ;; NOT COLD
br label %fallthrough
}
; CHECK: ![[castLoc]] = !DILocation(line: 2