From 2c063c848d7fbdfd6dc06ce5e72c5923c791f897 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Tue, 21 Oct 2003 16:09:23 +0000 Subject: [PATCH] Pull the PHI special case into it's own visit* method llvm-svn: 9332 --- lib/Target/Sparc/PreSelection.cpp | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/Target/Sparc/PreSelection.cpp b/lib/Target/Sparc/PreSelection.cpp index 014725a73f1..d4f4398b4a3 100644 --- a/lib/Target/Sparc/PreSelection.cpp +++ b/lib/Target/Sparc/PreSelection.cpp @@ -73,6 +73,7 @@ namespace { void visitInstruction(Instruction &I); // common work for every instr. void visitGetElementPtrInst(GetElementPtrInst &I); void visitCallInst(CallInst &I); + void visitPHINode(PHINode &PN); // Helper functions for visiting operands of every instruction // @@ -210,19 +211,21 @@ PreSelection::visitOneOperand(Instruction &I, Value* Op, unsigned opNum, // inline void PreSelection::visitOperands(Instruction &I, int firstOp) { // For any instruction other than PHI, copies go just before the instr. + for (unsigned i = firstOp, e = I.getNumOperands(); i != e; ++i) + visitOneOperand(I, I.getOperand(i), i, I); +} + + +void PreSelection::visitPHINode(PHINode &PN) { // For a PHI, operand copies must be before the terminator of the // appropriate predecessor basic block. Remaining logic is simple // so just handle PHIs and other instructions separately. // - if (PHINode* phi = dyn_cast(&I)) { - for (unsigned i=firstOp, N=phi->getNumIncomingValues(); i != N; ++i) - visitOneOperand(I, phi->getIncomingValue(i), - phi->getOperandNumForIncomingValue(i), - * phi->getIncomingBlock(i)->getTerminator()); - } else { - for (unsigned i=firstOp, N=lastOp; i != I.getNumOperands(); ++i) - visitOneOperand(I, I.getOperand(i), i, I); - } + for (unsigned i = 0, e = PN.getNumIncomingValues(); i != e; ++i) + visitOneOperand(I, PN.getIncomingValue(i), + PN.getOperandNumForIncomingValue(i), + *PN.getIncomingBlock(i)->getTerminator()); + // do not call visitOperands! }